Re: [Qemu-devel] [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

2016-09-15 Thread Alberto Garcia
On Wed 14 Sep 2016 08:54:19 PM CEST, Jeff Cody wrote: >> If an image is opened with snapshot=on, its flags are modified by >> bdrv_backing_options() and then bs->open_flags is updated accordingly. >> This last step is unnecessary if we calculate the new flags before >> setting bs->open_flags. >>

Re: [Qemu-devel] [Qemu-block] [PATCH 2/7] block: Set BDRV_O_ALLOW_RDWR and snapshot_options before storing the flags

2016-09-14 Thread Jeff Cody
On Wed, Sep 14, 2016 at 06:52:15PM +0300, Alberto Garcia wrote: > If an image is opened with snapshot=on, its flags are modified by > bdrv_backing_options() and then bs->open_flags is updated accordingly. > This last step is unnecessary if we calculate the new flags before > setting