Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Philippe, On Mon, Sep 18, 2017 at 5:27 AM, Philippe Mathieu-Daudé wrote: > Hi Sundeep, > > On 09/14/2017 01:36 AM, Philippe Mathieu-Daudé wrote: > >> On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: >> > [...] > >> +static inline int msf2_divbits(uint32_t div) >>> >> >>

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Sundeep, On 09/14/2017 01:36 AM, Philippe Mathieu-Daudé wrote: On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: [...] +static inline int msf2_divbits(uint32_t div) Please directly use ctz32() instead of msf2_divbits() It seems you missed this review comment in your v9. +{ +    int

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

+static uint64_t msf2_sysreg_read(void *opaque, hwaddr offset, +unsigned size) +{ +MSF2SysregState *s = opaque; +uint32_t ret = 0; + +offset >>= 2; +if (offset < ARRAY_SIZE(s->regs)) { This comment is controversial, I'll let Peter nod. The SYSREG behaves differently

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Philippe, On Thu, Sep 14, 2017 at 10:06 AM, Philippe Mathieu-Daudé wrote: > Hi Sundeep, > > > On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: > >> Added Sytem register block of Smartfusion2. >> This block has PLL registers which are accessed by guest. >> >> Signed-off-by:

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Philippe, On Thu, Sep 14, 2017 at 6:43 PM, Peter Maydell wrote: > On 14 September 2017 at 05:36, Philippe Mathieu-Daudé > wrote: > > On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: > >> +static uint64_t msf2_sysreg_read(void *opaque, hwaddr

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

On 14 September 2017 at 05:36, Philippe Mathieu-Daudé wrote: > On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: >> +static uint64_t msf2_sysreg_read(void *opaque, hwaddr offset, >> +unsigned size) >> +{ >> +MSF2SysregState *s = opaque; >> +uint32_t ret = 0; >> + >> +

Re: [Qemu-devel] [Qemu devel v8 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

Hi Sundeep, On 09/07/2017 04:24 PM, Subbaraya Sundeep wrote: Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis ---