Re: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support
On Thu, Oct 13, 2016 at 09:10:22PM -0700, no-re...@patchew.org wrote:
> Hi,
>
> Your series seems to have some coding style problems. See output below for
> more information:
checkpatch generates a fair few false positives. However, having had
a look, these don't appear to be so.
>
> Subject: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and
> memory unplug support
> Type: series
> Message-id: 1476314039-9520-1-git-send-email-mdr...@linux.vnet.ibm.com
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> b6c6ecd spapr: Memory hot-unplug support
> 74753f0 spapr: use count+index for memory hotplug
> 2de1399 spapr: Add DRC count indexed hotplug identifier type
> 860a9e5 spapr_events: add support for dedicated hotplug event source
> 895d1aa spapr: add hotplug interrupt machine options
> fffa858 spapr: update spapr hotplug documentation
> e9df226 spapr: fix inheritance chain for default machine options
> dc9b8b1 spapr: improve ibm, architecture-vec-5 property handling
> be26f44 spapr: add option vector handling in CAS-generated resets
> cc5d859 spapr_hcall: use spapr_ovec_* interfaces for CAS options
> 90daf38 spapr_ovec: initial implementation of option vector helpers
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/11: spapr_ovec: initial implementation of option vector
> helpers...
> WARNING: architecture specific defines should be avoided
> #338: FILE: include/hw/ppc/spapr_ovec.h:36:
> +#if !defined(__HW_SPAPR_OPTION_VECTORS_H__)
... uh, except for this one. I think this one can be ignored, the
rest should be addressed.
> total: 0 errors, 1 warnings, 314 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> Checking PATCH 2/11: spapr_hcall: use spapr_ovec_* interfaces for CAS
> options...
> Checking PATCH 3/11: spapr: add option vector handling in CAS-generated
> resets...
> Checking PATCH 4/11: spapr: improve ibm, architecture-vec-5 property
> handling...
> Checking PATCH 5/11: spapr: fix inheritance chain for default machine
> options...
> Checking PATCH 6/11: spapr: update spapr hotplug documentation...
> Checking PATCH 7/11: spapr: add hotplug interrupt machine options...
> Checking PATCH 8/11: spapr_events: add support for dedicated hotplug event
> source...
> ERROR: switch and case should be at the same indent
> #164: FILE: hw/ppc/spapr_events.c:283:
> +switch (log_type) {
> +case RTAS_LOG_TYPE_HOTPLUG:
> [...]
> +case RTAS_LOG_TYPE_EPOW:
> [...]
> +default:
>
> total: 1 errors, 0 warnings, 272 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Checking PATCH 9/11: spapr: Add DRC count indexed hotplug identifier type...
> WARNING: line over 80 characters
> #85: FILE: hw/ppc/spapr_events.c:538:
> +hp->drc_id.count_indexed.count =
> cpu_to_be32(drc_id->count_indexed.count);
>
> WARNING: line over 80 characters
> #86: FILE: hw/ppc/spapr_events.c:539:
> +hp->drc_id.count_indexed.index =
> cpu_to_be32(drc_id->count_indexed.index);
>
> total: 0 errors, 2 warnings, 144 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> Checking PATCH 10/11: spapr: use count+index for memory hotplug...
> WARNING: line over 80 characters
> #58: FILE: hw/ppc/spapr.c:2265:
> + addr_start /
> SPAPR_MEMORY_BLOCK_SIZE);
>
> WARNING: line over 80 characters
> #64: FILE: hw/ppc/spapr.c:2271:
> +spapr_hotplug_req_add_by_count(SPAPR_DR_CONNECTOR_TYPE_LMB,
> nr_lmbs);
>
> total: 0 errors, 2 warnings, 45 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to
Re: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory unplug support
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC PATCH 00/11] spapr: option vector re-work and memory
unplug support
Type: series
Message-id: 1476314039-9520-1-git-send-email-mdr...@linux.vnet.ibm.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
b6c6ecd spapr: Memory hot-unplug support
74753f0 spapr: use count+index for memory hotplug
2de1399 spapr: Add DRC count indexed hotplug identifier type
860a9e5 spapr_events: add support for dedicated hotplug event source
895d1aa spapr: add hotplug interrupt machine options
fffa858 spapr: update spapr hotplug documentation
e9df226 spapr: fix inheritance chain for default machine options
dc9b8b1 spapr: improve ibm, architecture-vec-5 property handling
be26f44 spapr: add option vector handling in CAS-generated resets
cc5d859 spapr_hcall: use spapr_ovec_* interfaces for CAS options
90daf38 spapr_ovec: initial implementation of option vector helpers
=== OUTPUT BEGIN ===
Checking PATCH 1/11: spapr_ovec: initial implementation of option vector
helpers...
WARNING: architecture specific defines should be avoided
#338: FILE: include/hw/ppc/spapr_ovec.h:36:
+#if !defined(__HW_SPAPR_OPTION_VECTORS_H__)
total: 0 errors, 1 warnings, 314 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/11: spapr_hcall: use spapr_ovec_* interfaces for CAS options...
Checking PATCH 3/11: spapr: add option vector handling in CAS-generated
resets...
Checking PATCH 4/11: spapr: improve ibm, architecture-vec-5 property handling...
Checking PATCH 5/11: spapr: fix inheritance chain for default machine options...
Checking PATCH 6/11: spapr: update spapr hotplug documentation...
Checking PATCH 7/11: spapr: add hotplug interrupt machine options...
Checking PATCH 8/11: spapr_events: add support for dedicated hotplug event
source...
ERROR: switch and case should be at the same indent
#164: FILE: hw/ppc/spapr_events.c:283:
+switch (log_type) {
+case RTAS_LOG_TYPE_HOTPLUG:
[...]
+case RTAS_LOG_TYPE_EPOW:
[...]
+default:
total: 1 errors, 0 warnings, 272 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/11: spapr: Add DRC count indexed hotplug identifier type...
WARNING: line over 80 characters
#85: FILE: hw/ppc/spapr_events.c:538:
+hp->drc_id.count_indexed.count =
cpu_to_be32(drc_id->count_indexed.count);
WARNING: line over 80 characters
#86: FILE: hw/ppc/spapr_events.c:539:
+hp->drc_id.count_indexed.index =
cpu_to_be32(drc_id->count_indexed.index);
total: 0 errors, 2 warnings, 144 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 10/11: spapr: use count+index for memory hotplug...
WARNING: line over 80 characters
#58: FILE: hw/ppc/spapr.c:2265:
+ addr_start /
SPAPR_MEMORY_BLOCK_SIZE);
WARNING: line over 80 characters
#64: FILE: hw/ppc/spapr.c:2271:
+spapr_hotplug_req_add_by_count(SPAPR_DR_CONNECTOR_TYPE_LMB,
nr_lmbs);
total: 0 errors, 2 warnings, 45 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/11: spapr: Memory hot-unplug support...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
