Re: [Qemu-devel] [RFC PATCH 01/56] qobject: Touch up comments to say @param instead of 'param'

[Markus Armbruster]

Eric Blake  writes:

> On 08/07/2017 09:45 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster 
>> ---
>>  qobject/qdict.c | 68 
>> -
>>  qobject/qlist.c |  2 +-
>>  2 files changed, 35 insertions(+), 35 deletions(-)
>> 
>> diff --git a/qobject/qdict.c b/qobject/qdict.c
>> index 576018e..d795079 100644
>> --- a/qobject/qdict.c
>> +++ b/qobject/qdict.c
>> @@ -116,13 +116,13 @@ static QDictEntry *qdict_find(const QDict *qdict,
>>  /**
>>   * qdict_put_obj(): Put a new QObject into the dictionary
>>   *
>> - * Insert the pair 'key:value' into 'qdict', if 'key' already exists
>> - * its 'value' will be replaced.
>> + * Insert the pair @key:@value into @qdict, if @key already exists
>> + * its value will be replaced.
>
> Maybe s/,/;/ while at it.

Or even *gasp* a period.

> Reviewed-by: Eric Blake 

Thanks!

Re: [Qemu-devel] [RFC PATCH 01/56] qobject: Touch up comments to say @param instead of 'param'

[Eric Blake]

On 08/07/2017 09:45 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster 
> ---
>  qobject/qdict.c | 68 
> -
>  qobject/qlist.c |  2 +-
>  2 files changed, 35 insertions(+), 35 deletions(-)
> 
> diff --git a/qobject/qdict.c b/qobject/qdict.c
> index 576018e..d795079 100644
> --- a/qobject/qdict.c
> +++ b/qobject/qdict.c
> @@ -116,13 +116,13 @@ static QDictEntry *qdict_find(const QDict *qdict,
>  /**
>   * qdict_put_obj(): Put a new QObject into the dictionary
>   *
> - * Insert the pair 'key:value' into 'qdict', if 'key' already exists
> - * its 'value' will be replaced.
> + * Insert the pair @key:@value into @qdict, if @key already exists
> + * its value will be replaced.

Maybe s/,/;/ while at it.

Reviewed-by: Eric Blake 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.   +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



signature.asc
Description: OpenPGP digital signature