Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/30/2017 10:50 AM, Cornelia Huck wrote: > On Wed, 29 Nov 2017 19:51:23 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 03:45 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 15:17:49 +0100 >>> Christian Borntraeger wrote: >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Wed, 29 Nov 2017 19:51:23 +0100 Christian Borntraeger wrote: > On 11/28/2017 03:45 PM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 15:17:49 +0100 > > Christian Borntraeger wrote: > > > >> On 11/28/2017 03:01 PM, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 03:45 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 15:17:49 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 03:01 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 14:25:08 +0100 >>> Christian Borntraeger wrote: >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 28 Nov 2017 15:17:49 +0100 Christian Borntraeger wrote: > On 11/28/2017 03:01 PM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 14:25:08 +0100 > > Christian Borntraeger wrote: > >> What I want now is to enable vfio-ccw for libvirt and

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 03:01 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 14:25:08 +0100 > Christian Borntraeger wrote: > >> On 11/28/2017 02:17 PM, Halil Pasic wrote: > >>> In the meanwhile I strongly prefer option 1 (at the ccw devices). I've just >>> sent a v2, and IMHO it

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/24/2017 01:46 PM, Cornelia Huck wrote: > On Thu, 23 Nov 2017 14:33:56 +0100 > Halil Pasic wrote: > >> Having an adequate representation for the css in QOM would be certainly >> interesting, but at the same time (IMHO) is somewhat challenging. Let me >> make some

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 28 Nov 2017 14:25:08 +0100 Christian Borntraeger wrote: > On 11/28/2017 02:17 PM, Halil Pasic wrote: > > In the meanwhile I strongly prefer option 1 (at the ccw devices). I've just > > sent a v2, and IMHO it shows the limitations of machine properties very > >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 02:17 PM, Halil Pasic wrote: > > > On 11/28/2017 01:24 PM, Christian Borntraeger wrote: >> >> >> On 11/28/2017 01:14 PM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 12:49:04 +0100 >>> Boris Fiuczynski wrote: >>> On 11/28/2017 11:22 AM, Cornelia

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 01:24 PM, Christian Borntraeger wrote: > > > On 11/28/2017 01:14 PM, Cornelia Huck wrote: >> On Tue, 28 Nov 2017 12:49:04 +0100 >> Boris Fiuczynski wrote: >> >>> On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 01:14 PM, Cornelia Huck wrote: > On Tue, 28 Nov 2017 12:49:04 +0100 > Boris Fiuczynski wrote: > >> On 11/28/2017 11:22 AM, Cornelia Huck wrote: >>> On Tue, 28 Nov 2017 09:53:15 +0100 >>> Boris Fiuczynski wrote: >>> On

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 28 Nov 2017 12:49:04 +0100 Boris Fiuczynski wrote: > On 11/28/2017 11:22 AM, Cornelia Huck wrote: > > On Tue, 28 Nov 2017 09:53:15 +0100 > > Boris Fiuczynski wrote: > > > >> On 11/27/2017 05:56 PM, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/28/2017 11:22 AM, Cornelia Huck wrote: On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: On 11/27/2017 05:56 PM, Cornelia Huck wrote: Proposal 2: Export the default cssid as a machine property. If this property exists, it also implies that devices

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 28 Nov 2017 09:53:15 +0100 Boris Fiuczynski wrote: > On 11/27/2017 05:56 PM, Cornelia Huck wrote: > > Proposal 2: Export the default cssid as a machine property. If this > > property exists, it also implies that devices can be put into any css > > image

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 05:56 PM, Cornelia Huck wrote: Proposal 2: Export the default cssid as a machine property. If this property exists, it also implies that devices can be put into any css image (although it makes the most sense to put them into the default css image as indicated by the property). Can

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

* Cornelia Huck [2017-11-27 13:58:16 +0100]: > On Mon, 27 Nov 2017 10:20:56 +0800 > Dong Jia Shi wrote: > > > * Halil Pasic [2017-11-24 17:39:04 +0100]: > > > > > > > > > > > On 11/24/2017 05:15 PM, Cornelia Huck

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

* Cornelia Huck [2017-11-27 17:56:07 +0100]: > On Mon, 27 Nov 2017 16:09:09 +0100 > Boris Fiuczynski wrote: > > > On 11/27/2017 03:13 PM, Halil Pasic wrote: > > > > > > > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: > > >> On Mon, 27 Nov

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 05:56 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 16:09:09 +0100 > Boris Fiuczynski wrote: > >> On 11/27/2017 03:13 PM, Halil Pasic wrote: >>> >>> >>> On 11/27/2017 02:19 PM, Cornelia Huck wrote: On Mon, 27 Nov 2017 14:11:57 +0100 Halil

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Mon, 27 Nov 2017 16:09:09 +0100 Boris Fiuczynski wrote: > On 11/27/2017 03:13 PM, Halil Pasic wrote: > > > > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: > >> On Mon, 27 Nov 2017 14:11:57 +0100 > >> Halil Pasic wrote: > >> > >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 03:13 PM, Halil Pasic wrote: On 11/27/2017 02:19 PM, Cornelia Huck wrote: On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: On 11/27/2017 01:56 PM, Cornelia Huck wrote: On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 03:03 PM, Christian Borntraeger wrote: > > > On 11/27/2017 02:19 PM, Cornelia Huck wrote: >> On Mon, 27 Nov 2017 14:11:57 +0100 >> Halil Pasic wrote: >> >>> On 11/27/2017 01:56 PM, Cornelia Huck wrote: On Fri, 24 Nov 2017 17:39:04 +0100 Halil

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 02:19 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 14:11:57 +0100 > Halil Pasic wrote: > >> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >>> On Fri, 24 Nov 2017 17:39:04 +0100 >>> Halil Pasic wrote: >>> On 11/24/2017

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 02:19 PM, Cornelia Huck wrote: > On Mon, 27 Nov 2017 14:11:57 +0100 > Halil Pasic wrote: > >> On 11/27/2017 01:56 PM, Cornelia Huck wrote: >>> On Fri, 24 Nov 2017 17:39:04 +0100 >>> Halil Pasic wrote: >>> On 11/24/2017

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Mon, 27 Nov 2017 14:11:57 +0100 Halil Pasic wrote: > On 11/27/2017 01:56 PM, Cornelia Huck wrote: > > On Fri, 24 Nov 2017 17:39:04 +0100 > > Halil Pasic wrote: > > > >> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > >>> (Unless we

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/27/2017 01:56 PM, Cornelia Huck wrote: > On Fri, 24 Nov 2017 17:39:04 +0100 > Halil Pasic wrote: > >> On 11/24/2017 05:15 PM, Cornelia Huck wrote: > In theory this should work. > > In reality it seems more complicated. A per-device property is easy

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Mon, 27 Nov 2017 10:20:56 +0800 Dong Jia Shi wrote: > * Halil Pasic [2017-11-24 17:39:04 +0100]: > > > > > > > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > > >>> In theory this should work. > > >>> > > >>> In reality it seems

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Fri, 24 Nov 2017 17:39:04 +0100 Halil Pasic wrote: > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > >>> In theory this should work. > >>> > >>> In reality it seems more complicated. A per-device property is easy and > >>> can be > >>> inspected on the command line

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

* Halil Pasic [2017-11-24 17:39:04 +0100]: > > > On 11/24/2017 05:15 PM, Cornelia Huck wrote: > >>> In theory this should work. > >>> > >>> In reality it seems more complicated. A per-device property is easy and > >>> can be > >>> inspected on the command line (e.g.

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/24/2017 05:15 PM, Cornelia Huck wrote: >>> In theory this should work. >>> >>> In reality it seems more complicated. A per-device property is easy and can >>> be >>> inspected on the command line (e.g. -device virtio-blk-ccw,help), while a >>> new >>> machine property would require to

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Fri, 24 Nov 2017 16:30:24 +0100 Halil Pasic wrote: > On 11/24/2017 03:58 PM, Christian Borntraeger wrote: > > > > > > On 11/24/2017 02:27 PM, Cornelia Huck wrote: > >> On Fri, 24 Nov 2017 14:01:20 +0100 > >> Christian Borntraeger wrote: >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/24/2017 03:58 PM, Christian Borntraeger wrote: > > > On 11/24/2017 02:27 PM, Cornelia Huck wrote: >> On Fri, 24 Nov 2017 14:01:20 +0100 >> Christian Borntraeger wrote: >> >>> I first liked the idea to have it as a property of the css, but >>> this is all pretty

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/24/2017 02:27 PM, Cornelia Huck wrote: > On Fri, 24 Nov 2017 14:01:20 +0100 > Christian Borntraeger wrote: > >> I first liked the idea to have it as a property of the css, but >> this is all pretty unclear how to do right. I start to think that going with >>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Fri, 24 Nov 2017 14:01:20 +0100 Christian Borntraeger wrote: > I first liked the idea to have it as a property of the css, but > this is all pretty unclear how to do right. I start to think that going with > Halils first patch (a property per virtio device) is going

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/24/2017 01:46 PM, Cornelia Huck wrote: > On Thu, 23 Nov 2017 14:33:56 +0100 > Halil Pasic wrote: > >> Having an adequate representation for the css in QOM would be certainly >> interesting, but at the same time (IMHO) is somewhat challenging. Let me >> make some

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Thu, 23 Nov 2017 14:33:56 +0100 Halil Pasic wrote: > Having an adequate representation for the css in QOM would be certainly > interesting, but at the same time (IMHO) is somewhat challenging. Let me > make some observations, which should some of my concerns. > >

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Thu, 23 Nov 2017 17:09:16 +0100 Halil Pasic wrote: [I need time to process your other remarks.] > On 11/22/2017 01:13 PM, Cornelia Huck wrote: > >> Also I can't find anything about vfio-ccw in the upstream users > >> manual for 2.10.91. > > > > We have an

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/22/2017 01:13 PM, Cornelia Huck wrote: [..] >> The original question was about weather keep the start putting >> non-virtual devices into (the non-guest-visible) 0 if no devno is >> specified, or rather fill the default first and only then spill >> to the next css. > > Combined with what

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/22/2017 05:25 PM, Cornelia Huck wrote: > On Wed, 22 Nov 2017 15:45:56 +0100 > Boris Fiuczynski wrote: > >> On 11/22/2017 01:13 PM, Cornelia Huck wrote: +object_class_property_add_bool(klass, "cssid-unrestricted", +

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Wed, 22 Nov 2017 15:45:56 +0100 Boris Fiuczynski wrote: > On 11/22/2017 01:13 PM, Cornelia Huck wrote: > >> +object_class_property_add_bool(klass, "cssid-unrestricted", > >> + prop_get_true, NULL, NULL); > > This

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/22/2017 01:13 PM, Cornelia Huck wrote: +object_class_property_add_bool(klass, "cssid-unrestricted", + prop_get_true, NULL, NULL); This looks really, really strange. This is a property that is always true if it exists. Won't argue about that.

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 12:18 PM, Halil Pasic wrote: The default css 0xFE is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 19:10:15 +0100 Christian Borntraeger wrote: > On 11/21/2017 05:06 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 15:45:17 +0100 > > Christian Borntraeger wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>>

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 18:05:46 +0100 Halil Pasic wrote: > On 11/21/2017 05:20 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 16:47:29 +0100 > > Halil Pasic wrote: > > > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: > >>> On Tue, 21 Nov

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 05:06 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 15:45:17 +0100 > Christian Borntraeger wrote: > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: >>> On Tue, 21 Nov 2017 12:18:25 +0100 >>> Halil Pasic wrote: >>> >>> Subject:

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 05:20 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 16:47:29 +0100 > Halil Pasic wrote: > >> On 11/21/2017 02:44 PM, Cornelia Huck wrote: >>> On Tue, 21 Nov 2017 12:18:25 +0100 >>> Halil Pasic wrote: [..] >>> >>> - Add a

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 16:47:29 +0100 Halil Pasic wrote: > On 11/21/2017 02:44 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 12:18:25 +0100 > > Halil Pasic wrote: > > > > Subject: s/unresrict/unrestrict/ > > Sure! > > > > >> The

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 15:45:17 +0100 Christian Borntraeger wrote: > On 11/21/2017 02:44 PM, Cornelia Huck wrote: > > On Tue, 21 Nov 2017 12:18:25 +0100 > > Halil Pasic wrote: > > > > Subject: s/unresrict/unrestrict/ > > > >> The default css

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 02:44 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 12:18:25 +0100 > Halil Pasic wrote: > > Subject: s/unresrict/unrestrict/ Sure! > >> The default css 0xFE is currently restricted to virtual subchannel >> devices. The hope when the decision was made

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 02:44 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 12:18:25 +0100 > Halil Pasic wrote: > > Subject: s/unresrict/unrestrict/ > >> The default css 0xFE is currently restricted to virtual subchannel >> devices. The hope when the decision was made was,

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On 11/21/2017 02:44 PM, Cornelia Huck wrote: > On Tue, 21 Nov 2017 12:18:25 +0100 > Halil Pasic wrote: > > Subject: s/unresrict/unrestrict/ > >> The default css 0xFE is currently restricted to virtual subchannel >> devices. The hope when the decision was made was,

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

On Tue, 21 Nov 2017 12:18:25 +0100 Halil Pasic wrote: Subject: s/unresrict/unrestrict/ > The default css 0xFE is currently restricted to virtual subchannel > devices. The hope when the decision was made was, that non-virtual > subchannel devices will come around when