Re: [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions

2018-02-08 Thread Paolo Bonzini
On 07/02/2018 21:15, Roman Kagan wrote: >> Hmm, these are a bit harder to unify with hw/usb/dev-network.c. Still >> not _that_ hard, just that the USB version has two fields for message >> type/length at the beginning. > This is my "fault". At some point I got tired of this pattern so I >

Re: [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions

2018-02-07 Thread Roman Kagan
On Wed, Feb 07, 2018 at 01:00:14PM +0100, Paolo Bonzini wrote: > On 06/02/2018 21:30, Roman Kagan wrote: > > +/* NdisInitialize message */ > > +struct rndis_initialize_request { > > +uint32_t req_id; > > +uint32_t major_ver; > > +uint32_t minor_ver; > > +uint32_t max_xfer_size; > >

Re: [Qemu-devel] [RFC PATCH 29/34] net: add Hyper-V/VMBus network protocol definitions

2018-02-07 Thread Paolo Bonzini
On 06/02/2018 21:30, Roman Kagan wrote: > +/* NdisInitialize message */ > +struct rndis_initialize_request { > +uint32_t req_id; > +uint32_t major_ver; > +uint32_t minor_ver; > +uint32_t max_xfer_size; > +}; > + > +/* Response to NdisInitialize */ > +struct