Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts
Hi Paolo, On 07/28/2017 08:50 AM, Paolo Bonzini wrote: On 28/07/2017 08:24, Fam Zheng wrote: On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 224890643d..7854792765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1537,6 +1537,12 @@ Checkpatch S: Odd Fixes F: scripts/checkpatch.pl +Coccinelle scripts +R: Philippe Mathieu-Daudé +S: Orphan "Orphan" sounds like we don't care much anymore but I suppose this is not the case. But I don't have any better idea either. Just don't add it to the file. It doesn't have a specific owner I thought an entry with F: but no M: was incorrect but apparently get_maintainer.pl works and report it as "unknown" status, as for the "Coroutines" section: $ ./scripts/get_maintainer.pl -f util/coroutine-ucontext.c Stefan Hajnoczi (unknown:Coroutines) Kevin Wolf (unknown:Coroutines) qemu-devel@nongnu.org (open list:All patches CC here) So to enjoy the R-tag I'll remove the S-tag in v2 and see if Eric is ok with it :) Regards, Phil. Paolo Fam +F: scripts/cocci-macro-file.h +F: scripts/coccinelle/ + Migration M: Juan Quintela M: Dr. David Alan Gilbert @@ -1970,4 +1976,3 @@ Build system architecture M: Daniel P. Berrange S: Odd Fixes F: docs/devel/build-system.txt
Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts
On 07/28/2017 08:50 AM, Paolo Bonzini wrote: On 28/07/2017 08:24, Fam Zheng wrote: On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: diff --git a/MAINTAINERS b/MAINTAINERS index 224890643d..7854792765 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1537,6 +1537,12 @@ Checkpatch S: Odd Fixes F: scripts/checkpatch.pl +Coccinelle scripts +R: Philippe Mathieu-Daudé +S: Orphan "Orphan" sounds like we don't care much anymore but I suppose this is not the case. But I don't have any better idea either. M: Mail patches to: FullName R: Designated reviewer: FullName M: is mail of maintainer R: is mail of reviewer S: Status, one of the following: Maintained: Someone actually looks after it. Odd Fixes: It has a maintainer but they don't have time to do much other than throw the odd patch in. -> Orphan: No current maintainer "Orphan" sounds the best fit... Do you want to raise it to "Odd Fixes"? This implies having a maintainer... I don't feel confident enough to Ack cocci scripts but an incorrect cocci script will not break QEMU so maybe I cat take M: for Odd Fixes, and lowering it back to Orphan without maintainer is 1 commit easy :) Just don't add it to the file. It doesn't have a specific owner. Paolo you mean don't add the "S: Status" to the MAINTAINERS file, or the "F: *cocci*" entries? Regards, Phil. Paolo Fam +F: scripts/cocci-macro-file.h +F: scripts/coccinelle/ + Migration M: Juan Quintela M: Dr. David Alan Gilbert @@ -1970,4 +1976,3 @@ Build system architecture M: Daniel P. Berrange S: Odd Fixes F: docs/devel/build-system.txt
Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts
On 07/28/2017 12:36 AM, Philippe Mathieu-Daudé wrote: > and voluntary myself as reviewer s/voluntary/volunteer/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > > I'm not a Coccinelle specialist but willing to learn and help! > I'm not sure adding an orphan-only section helps; and some of the particular scripts have specific maintainers (qobject.cocci). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts
On 28/07/2017 08:24, Fam Zheng wrote: > On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 224890643d..7854792765 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1537,6 +1537,12 @@ Checkpatch >> S: Odd Fixes >> F: scripts/checkpatch.pl >> >> +Coccinelle scripts >> +R: Philippe Mathieu-Daudé >> +S: Orphan > > "Orphan" sounds like we don't care much anymore but I suppose this is not the > case. But I don't have any better idea either. Just don't add it to the file. It doesn't have a specific owner. Paolo > > Fam > >> +F: scripts/cocci-macro-file.h >> +F: scripts/coccinelle/ >> + >> Migration >> M: Juan Quintela >> M: Dr. David Alan Gilbert >> @@ -1970,4 +1976,3 @@ Build system architecture >> M: Daniel P. Berrange >> S: Odd Fixes >> F: docs/devel/build-system.txt
Re: [Qemu-devel] [RFC PATCH 46/47] MAINTAINERS: add missing entries for Coccinelle scripts
On Fri, 07/28 02:36, Philippe Mathieu-Daudé wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > index 224890643d..7854792765 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1537,6 +1537,12 @@ Checkpatch > S: Odd Fixes > F: scripts/checkpatch.pl > > +Coccinelle scripts > +R: Philippe Mathieu-Daudé > +S: Orphan "Orphan" sounds like we don't care much anymore but I suppose this is not the case. But I don't have any better idea either. Fam > +F: scripts/cocci-macro-file.h > +F: scripts/coccinelle/ > + > Migration > M: Juan Quintela > M: Dr. David Alan Gilbert > @@ -1970,4 +1976,3 @@ Build system architecture > M: Daniel P. Berrange > S: Odd Fixes > F: docs/devel/build-system.txt
