Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-08-25 Thread Pavel Dovgaluk
From: Paolo Bonzini [mailto:pbonz...@redhat.com] Il 31/07/2014 17:21, Pavel Dovgalyuk ha scritto: Pre load is necessary, because we switched off resetting VM while loading in the replay mode. Then you should not add it now, but rather when you add replay. Treat this part of the series

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-08-25 Thread Paolo Bonzini
Il 25/08/2014 13:40, Pavel Dovgaluk ha scritto: Do you mean, that I should separate the migration patches from the replay ones and submit them in another series? Yes, that will help getting the less controversial pieces in first. Paolo

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:54, Pavel Dovgalyuk ha scritto: +static int apic_pre_load(void *opaque) +{ +APICCommonState *s = APIC_COMMON(opaque); +s-sipi_vector = 0; +s-wait_for_sipi = 0; +s-vapic_paddr = 0; +return 0; Is this necessary? Or does reset already do that? +} +

Re: [Qemu-devel] [RFC PATCH v3 07/49] kvmapic: fixing loading vmstate

2014-07-31 Thread Pavel Dovgalyuk
Pre load is necessary, because we switched off resetting VM while loading in the replay mode. Calling reset handlers generates irqs, that make loading process non-deterministic. Sent from mobile device Исходное сообщение От: Paolo Bonzini pbonz...@redhat.com