Re: [Qemu-devel] [RFC PATCH v4 4/4] qcow2: Add full image preallocation option

2014-02-06 Thread Hu Tao
On Mon, Jan 20, 2014 at 10:16:23AM +0800, Hu Tao wrote: Stefan, On Fri, Jan 17, 2014 at 04:48:16PM +0800, Stefan Hajnoczi wrote: On Fri, Dec 27, 2013 at 11:05:54AM +0800, Hu Tao wrote: This approach seems okay but the calculation isn't quite right yet. On Windows an error would be

Re: [Qemu-devel] [RFC PATCH v4 4/4] qcow2: Add full image preallocation option

2014-01-19 Thread Hu Tao
Stefan, On Fri, Jan 17, 2014 at 04:48:16PM +0800, Stefan Hajnoczi wrote: On Fri, Dec 27, 2013 at 11:05:54AM +0800, Hu Tao wrote: This approach seems okay but the calculation isn't quite right yet. On Windows an error would be raised since we don't have preallocate=full support. That's

Re: [Qemu-devel] [RFC PATCH v4 4/4] qcow2: Add full image preallocation option

2014-01-17 Thread Stefan Hajnoczi
On Fri, Dec 27, 2013 at 11:05:54AM +0800, Hu Tao wrote: This approach seems okay but the calculation isn't quite right yet. On Windows an error would be raised since we don't have preallocate=full support. That's okay. @@ -1477,16 +1478,53 @@ static int qcow2_create2(const char *filename,