Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

2017-01-31 Thread Ed Swierk
On Tue, Jan 31, 2017 at 7:34 AM, Paolo Bonzini wrote: > > > On 31/01/2017 04:39, Daniel P. Berrange wrote: >> I don't think so - retrying in this way is pointless IMHO - it is just >> going to get the same result on every retry on 99% of occassions. > > Just to provide the

Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

2017-01-31 Thread Paolo Bonzini
On 31/01/2017 04:39, Daniel P. Berrange wrote: > On Mon, Jan 30, 2017 at 08:58:25PM -0800, Ed Swierk wrote: >> On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange >> wrote: >>> On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: Currently qemu_chr_fe_write()

Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

2017-01-31 Thread Daniel P. Berrange
On Mon, Jan 30, 2017 at 08:58:25PM -0800, Ed Swierk wrote: > On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange > wrote: > > On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: > >> Currently qemu_chr_fe_write() calls qemu_chr_fe_write_log() only for > >> data

Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

2017-01-30 Thread Ed Swierk
On Fri, Jan 27, 2017 at 1:40 AM, Daniel P. Berrange wrote: > On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: >> Currently qemu_chr_fe_write() calls qemu_chr_fe_write_log() only for >> data consumed by the backend chr_write function. With the pty backend, >>

Re: [Qemu-devel] [libvirt] char: Logging serial pty output when disconnected

2017-01-27 Thread Daniel P. Berrange
On Thu, Jan 26, 2017 at 05:07:16PM -0800, Ed Swierk wrote: > Interactive access to a guest serial console can be enabled by hooking > the serial device to a pty backend, e.g. -device > isa-serial,chardev=cs0 -chardev pty,id=cs0. With libvirt this can be > configured via port='0'/>. > > Output