Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Thomas Huth
On 19.02.2018 18:17, Collin L. Walling wrote: > On 02/19/2018 11:19 AM, Collin L. Walling wrote: >> On 02/19/2018 11:00 AM, Thomas Huth wrote: >>> On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: > On 16.02.2018 23:07, Collin L. Walling wrote: >

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Eric Blake
On 02/19/2018 11:17 AM, Collin L. Walling wrote: How is this for a compromise?     - start num_idx at 1, provide comment as for why     - change while loop comment to explain we are "counting the _indices_ _of_ _num_"     - str[num_idx] is assigned \0, and we also decrement num_idx in one

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:19 AM, Collin L. Walling wrote: On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Thomas Huth
On 19.02.2018 16:40, Collin L. Walling wrote: > On 02/17/2018 02:48 AM, Thomas Huth wrote: >> On 16.02.2018 23:07, Collin L. Walling wrote: >> [...] >>> +/** >>> + * uitoa: >>> + * @num: an integer (base 10) to be converted. >>> + * @str: a pointer to a string to store the conversion. >>> + *

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the conversion. + * @len: the length of the passed string. + * + * Given an integer @num,

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-16 Thread Thomas Huth
On 16.02.2018 23:07, Collin L. Walling wrote: [...] > +/** > + * uitoa: > + * @num: an integer (base 10) to be converted. > + * @str: a pointer to a string to store the conversion. > + * @len: the length of the passed string. > + * > + * Given an integer @num, convert it to a string. The string