Re: [Qemu-devel] GTK UI keycodes broken under Wayland
On Thu, Dec 1, 2016 at 9:35 AM, Daniel P. Berrange wrote: > On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote: >> On 01.12.2016 08:24, Stefan Hajnoczi wrote: >> > I recently upgraded to Fedora 25 which runs Wayland by default. >> > >> > The GTK UI is now sending unknown keycodes to the guests. Although >> > alphanumeric keys work, the cursor keys are broken. >> > >> > There is X11-specific code for keycode mapping in ui/gtk.c. Perhaps >> > something is needed to make that work under Wayland? >> >> There is certainly something missing for Wayland. Somebody already >> reported this issue here and posted a "quick and dirty" patch: >> >> https://bugs.launchpad.net/qemu/+bug/1578192 > > That patch doesn't seem to apply for me and does more than is > needed. I've just sent a simpler patch that ought to fix it, > though I've not personally tested it, so would appreciate > feedback from Stefan that his test VM keyboard works now. Cool, thank you! I will test it. Stefan
Re: [Qemu-devel] GTK UI keycodes broken under Wayland
On Thu, Dec 01, 2016 at 09:32:34AM +0100, Thomas Huth wrote: > On 01.12.2016 08:24, Stefan Hajnoczi wrote: > > I recently upgraded to Fedora 25 which runs Wayland by default. > > > > The GTK UI is now sending unknown keycodes to the guests. Although > > alphanumeric keys work, the cursor keys are broken. > > > > There is X11-specific code for keycode mapping in ui/gtk.c. Perhaps > > something is needed to make that work under Wayland? > > There is certainly something missing for Wayland. Somebody already > reported this issue here and posted a "quick and dirty" patch: > > https://bugs.launchpad.net/qemu/+bug/1578192 That patch doesn't seem to apply for me and does more than is needed. I've just sent a simpler patch that ought to fix it, though I've not personally tested it, so would appreciate feedback from Stefan that his test VM keyboard works now. Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o-http://search.cpan.org/~danberr/ :|
Re: [Qemu-devel] GTK UI keycodes broken under Wayland
On 01.12.2016 08:24, Stefan Hajnoczi wrote: > I recently upgraded to Fedora 25 which runs Wayland by default. > > The GTK UI is now sending unknown keycodes to the guests. Although > alphanumeric keys work, the cursor keys are broken. > > There is X11-specific code for keycode mapping in ui/gtk.c. Perhaps > something is needed to make that work under Wayland? There is certainly something missing for Wayland. Somebody already reported this issue here and posted a "quick and dirty" patch: https://bugs.launchpad.net/qemu/+bug/1578192 Thomas
