Re: [Qemu-devel] rate limiting issues

2018-02-06 Thread Stefan Hajnoczi
On Tue, Feb 06, 2018 at 11:54:51AM +0100, Wolfgang Bumiller wrote: > On Mon, Feb 05, 2018 at 03:31:40PM +, Stefan Hajnoczi wrote: > > On Fri, Feb 02, 2018 at 12:10:22PM +0100, Wolfgang Bumiller wrote: > (...) > > > Explanation: > > > The ratelimiting code in include/qemu/ratelimit.h currently u

Re: [Qemu-devel] rate limiting issues

2018-02-06 Thread Wolfgang Bumiller
On Mon, Feb 05, 2018 at 03:31:40PM +, Stefan Hajnoczi wrote: > On Fri, Feb 02, 2018 at 12:10:22PM +0100, Wolfgang Bumiller wrote: (...) > > Explanation: > > The ratelimiting code in include/qemu/ratelimit.h currently uses slices with > > quotas. Finishing up the quota for one slice means it'll

Re: [Qemu-devel] rate limiting issues

2018-02-05 Thread Stefan Hajnoczi
On Fri, Feb 02, 2018 at 12:10:22PM +0100, Wolfgang Bumiller wrote: > Summary: > Rate limit is effectively halved when the size of written chunks adds up to > exceeding the quota of a slice only slightly. This is surprisingly reliable. > > Explanation: > The ratelimiting code in include/qemu/rateli

Re: [Qemu-devel] rate limiting issues

2018-02-05 Thread Stefan Hajnoczi
On Fri, Feb 02, 2018 at 04:52:00PM -0500, John Snow wrote: > CCing qemu-block and Berto To avoid confusion: ratelimit.h is only used by block jobs. It is unrelated to throttle.h, which Berto maintains. Unifying the two came up in the past as a cleanup task. No one has attempted it yet. signat

Re: [Qemu-devel] rate limiting issues

2018-02-02 Thread John Snow
CCing qemu-block and Berto On 02/02/2018 06:10 AM, Wolfgang Bumiller wrote: > Summary: > Rate limit is effectively halved when the size of written chunks adds up to > exceeding the quota of a slice only slightly. This is surprisingly reliable. > > Explanation: > The ratelimiting code in include/q