Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-24 Thread Philippe Mathieu-Daudé
Hi Igor, On 10/9/19 3:22 PM, Igor Mammedov wrote: Extend CPU hotplug interface to return architecture specific identifier for current CPU (in case of x86, it's APIC ID). Signed-off-by: Igor Mammedov --- TODO: * cripple it to behave old way on old machine types so that new firmware

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-23 Thread Igor Mammedov
On Tue, 22 Oct 2019 17:49:06 +0200 Laszlo Ersek wrote: > On 10/22/19 16:42, Igor Mammedov wrote: > > On Tue, 22 Oct 2019 14:39:24 +0200 > > Laszlo Ersek wrote: > > > >> On 10/21/19 15:06, Laszlo Ersek wrote: > >>> On 10/18/19 18:18, Igor Mammedov wrote: > > Considering firmware

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-22 Thread Laszlo Ersek
On 10/22/19 16:42, Igor Mammedov wrote: > On Tue, 22 Oct 2019 14:39:24 +0200 > Laszlo Ersek wrote: > >> On 10/21/19 15:06, Laszlo Ersek wrote: >>> On 10/18/19 18:18, Igor Mammedov wrote: Considering firmware runs the first, it should enable modern interface on its own 1.

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-22 Thread Igor Mammedov
On Tue, 22 Oct 2019 14:39:24 +0200 Laszlo Ersek wrote: > On 10/21/19 15:06, Laszlo Ersek wrote: > > On 10/18/19 18:18, Igor Mammedov wrote: > >> On Thu, 10 Oct 2019 16:56:18 +0200 > >> Laszlo Ersek wrote: > > [...] > > >>> Can I use the following sequence to detect whether the interface

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-22 Thread Laszlo Ersek
On 10/21/19 15:06, Laszlo Ersek wrote: > On 10/18/19 18:18, Igor Mammedov wrote: >> On Thu, 10 Oct 2019 16:56:18 +0200 >> Laszlo Ersek wrote: [...] >>> Can I use the following sequence to detect whether the interface is >>> available? >>> >>> 1. Store 0x0 to command register. >>> 2. Store 0x0

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-21 Thread Laszlo Ersek
Hello Igor, On 10/18/19 18:18, Igor Mammedov wrote: > On Thu, 10 Oct 2019 16:56:18 +0200 > Laszlo Ersek wrote: [...] >> Right now, I can't offer testing for patch#3 (I'm quite far from the >> point where I'll be actually looking for a hotplugged CPU :) ), but >> based on the docs patches #1

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-18 Thread Igor Mammedov
On Thu, 10 Oct 2019 16:56:18 +0200 Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Extend CPU hotplug interface to return architecture specific > > identifier for current CPU (in case of x86, it's APIC ID). > > > > Signed-off-by: Igor Mammedov > > --- > > TODO: > > *

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-11 Thread Laszlo Ersek
On 10/10/19 21:26, Eduardo Habkost wrote: > Topology info is already available on CPUID. Independently of everything else, thanks for pointing this out. The edk2 library called "LocalApicLib" has two relevant functions: > /** > Get Package ID/Core ID/Thread ID of a processor. > > The

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Eduardo Habkost
On Thu, Oct 10, 2019 at 11:06:29AM -0400, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: > > On 10/09/19 15:22, Igor Mammedov wrote: > > > Extend CPU hotplug interface to return architecture specific > > > identifier for current CPU (in case of x86, it's

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Laszlo Ersek
On 10/10/19 17:06, Michael S. Tsirkin wrote: > On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: >> On 10/09/19 15:22, Igor Mammedov wrote: >>> Extend CPU hotplug interface to return architecture specific >>> identifier for current CPU (in case of x86, it's APIC ID). >>> >>>

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Igor Mammedov
rting_evt(uint32_t idx) "idx[0x%"PRIx32"]" > > > cpuhp_acpi_clear_remove_evt(uint32_t idx) "idx[0x%"PRIx32"]" > > > > > > > Looks plausible to me, thanks (discounting the TODO item). > > > > Right now, I can'

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Michael S. Tsirkin
On Thu, Oct 10, 2019 at 04:56:18PM +0200, Laszlo Ersek wrote: > On 10/09/19 15:22, Igor Mammedov wrote: > > Extend CPU hotplug interface to return architecture specific > > identifier for current CPU (in case of x86, it's APIC ID). > > > > Signed-off-by: Igor Mammedov > > --- > > TODO: > > *

Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command

2019-10-10 Thread Laszlo Ersek
On 10/09/19 15:22, Igor Mammedov wrote: > Extend CPU hotplug interface to return architecture specific > identifier for current CPU (in case of x86, it's APIC ID). > > Signed-off-by: Igor Mammedov > --- > TODO: > * cripple it to behave old way on old machine types so that > new firmware