Re: [RFC PATCH v2 09/30] target/loongarch: Add TLB instruction support

2021-11-17 Thread yangxiaojuan
On 11/17/2021 04:22 PM, Richard Henderson wrote: > On 11/17/21 8:29 AM, yangxiaojuan wrote: >> On 11/12/2021 02:14 AM, Richard Henderson wrote: >>> On 11/11/21 2:35 AM, Xiaojuan Yang wrote: +static bool trans_tlbwr(DisasContext *ctx, arg_tlbwr *a) +{ +

Re: [RFC PATCH v2 09/30] target/loongarch: Add TLB instruction support

2021-11-17 Thread Richard Henderson
On 11/17/21 8:29 AM, yangxiaojuan wrote: On 11/12/2021 02:14 AM, Richard Henderson wrote: On 11/11/21 2:35 AM, Xiaojuan Yang wrote: +static bool trans_tlbwr(DisasContext *ctx, arg_tlbwr *a) +{ +gen_helper_check_plv(cpu_env); +gen_helper_tlbwr(cpu_env); +tcg_gen_movi_tl(cpu_pc,

Re: [RFC PATCH v2 09/30] target/loongarch: Add TLB instruction support

2021-11-16 Thread yangxiaojuan
Hi, Richard: On 11/12/2021 02:14 AM, Richard Henderson wrote: > On 11/11/21 2:35 AM, Xiaojuan Yang wrote: >> +static bool trans_tlbwr(DisasContext *ctx, arg_tlbwr *a) >> +{ >> +gen_helper_check_plv(cpu_env); >> +gen_helper_tlbwr(cpu_env); >> +tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next

Re: [RFC PATCH v2 09/30] target/loongarch: Add TLB instruction support

2021-11-11 Thread Richard Henderson
On 11/11/21 2:35 AM, Xiaojuan Yang wrote: +static bool trans_tlbwr(DisasContext *ctx, arg_tlbwr *a) +{ +gen_helper_check_plv(cpu_env); +gen_helper_tlbwr(cpu_env); +tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next + 4); +ctx->base.is_jmp = DISAS_EXIT; +return true; +} I think you