Re: [RFC v5 121/126] hw/sd/ssi-sd.c: introduce ERRP_AUTO_PROPAGATE

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
14.10.2019 12:14, Philippe Mathieu-Daudé wrote: > On 10/14/19 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> 12.10.2019 9:33, Philippe Mathieu-Daudé wrote: >>> On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote: If we want to add some info to errp (by error_prepend() or

Re: [RFC v5 121/126] hw/sd/ssi-sd.c: introduce ERRP_AUTO_PROPAGATE

2019-10-14 Thread Philippe Mathieu-Daudé
On 10/14/19 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: 12.10.2019 9:33, Philippe Mathieu-Daudé wrote: On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote: If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro.

Re: [RFC v5 121/126] hw/sd/ssi-sd.c: introduce ERRP_AUTO_PROPAGATE

2019-10-14 Thread Vladimir Sementsov-Ogievskiy
12.10.2019 9:33, Philippe Mathieu-Daudé wrote: > On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote: >> If we want to add some info to errp (by error_prepend() or >> error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. >> Otherwise, this info will not be added when errp == _err >>

Re: [RFC v5 121/126] hw/sd/ssi-sd.c: introduce ERRP_AUTO_PROPAGATE

2019-10-12 Thread Philippe Mathieu-Daudé
On 10/11/19 6:05 PM, Vladimir Sementsov-Ogievskiy wrote: If we want to add some info to errp (by error_prepend() or error_append_hint()), we must use the ERRP_AUTO_PROPAGATE macro. Otherwise, this info will not be added when errp == _err (the program will exit prior to the error_append_hint() or