Re: [Qgis-developer] GSOC project idea

Hi Nyall, Thanks for your valuable reply. I will try to complete the project write-up(1-2 pages and with some additional features) within 2 days. Thanks & Regards, Harsh Sent with Mailtrack

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > So if we want to address both we need the layer_id and layer_name. I'd say > when you build a OGR URI (mostly in QgisApp::askUserForOGRSublayers()), > then look at the uniqueness of the layer names. If there's layer name > unicity, then use only the layer name. Otherwise fallback to uniquely

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Ok - I find this thread very confusing. Does this acknowledgement mean > > that you WILL remove these ifdefs from the PR? > > Yes, indeed. > >> Here's the thing: I *want* your work to land in QGIS. It's important > > stuff, and needs to be addressed. But in its current form it won't be > >

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On 21 March 2017 at 09:23, Mark Johnson wrote: >> Yet I still see lots of code in that PR like: >> >> if defined(GDAL_VERSION_NUM) && GDAL_VERSION_NUM >= >> GDAL_COMPUTE_VERSION(2,0,0) >> >> That's what I'm referring to. All this conditional code needs removal >> (unless

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Yet I still see lots of code in that PR like: > > if defined(GDAL_VERSION_NUM) && GDAL_VERSION_NUM >= > GDAL_COMPUTE_VERSION(2,0,0) > > That's what I'm referring to. All this conditional code needs removal > (unless it's testing for something in GDAL > 2.0 ). Mosty in the static functions -

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On 21 March 2017 at 09:03, Mark Johnson wrote: >> Great - looking forward to seeing you push this to the PR! It'll make >> the remaining changes much easier to review. > > > Thats the way it was done when submitted.. Yet I still see lots of code in that PR like: if

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Great - looking forward to seeing you push this to the PR! It'll make > the remaining changes much easier to review. Thats the way it was done when submitted.. Mark ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org List info:

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > The layer name can be stored in subLayers() for conveniency, since it has >> usually a short life. And for subLayers() / askUserForOGRSublayers() make >> the layer id what is used. > > subLayers is not used when read from a project, only when a new source is added. > >> Not sure to what you

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On 21 March 2017 at 08:45, Mark Johnson wrote: >> >> 1. No extra code will be allowed in master to handle GDAL < 2.0. QGIS >> 3.0 has a hard GDAL >= 2.0 requirement, and no code will be accepted >> to work around this requirement. > > > The original code did many tasks

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > > 1. No extra code will be allowed in master to handle GDAL < 2.0. QGIS > 3.0 has a hard GDAL >= 2.0 requirement, and no code will be accepted > to work around this requirement. The original code did many tasks being coded multiple times - these common tasks are written once in a extra

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> The proposed solution deals with problem in QgsOgrProvider::subLayers() > - searches for duplicate names > -- an extra parameter tells QgsOgrProvider if the given id or layername > should be used Perhaps we can avoid that extra parameter, and have the layer name prioritary over the layer id

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Isn't this about PR #3697 - which is opened against 2.18? If #3697 is > abandoned, can I close to clean up the PR queue? Since the problem is not resolved, no. The present QGIS 3.0 cannot table with more than geometry. - at that time there was no QGIS 3 I changed that to 3.0 this morning.

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

There are different issues you've raised and that we might want handle or > not: > > 1) make sure that a URI points to the same layer if the datasource evolves > (new layer) > > 2) be able to deal with the corner cases of layers with same name > > > > 1) involves that we cannot always rely on the

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On 21 March 2017 at 08:13, Mark Johnson wrote: >> Please keep in mind that's there's some non-negotiables here: > > >> One way or another this matter needs to be resolved before an initial >> release of QGIS 3. > > > This topic is only about QGIS 3.0 only. Isn't this

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Please keep in mind that's there's some non-negotiables here: > One way or another this matter needs to be resolved before an initial > release of QGIS 3. This topic is only about QGIS 3.0 only. Mark ___ Qgis-developer mailing list

Re: [Qgis-developer] GSOC project idea

Hi Sai! Thanks for raising interested in this - we'd love to have more GSOC candidates for the project! Some specific comments inline below: On 21 March 2017 at 06:03, Sai Harsh Tondomker wrote:> > 1. Without restarting qgis, it will display the newly added plugin. best

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On lundi 20 mars 2017 22:39:20 CET Mark Johnson wrote: > > In the provider we could decide to allocate layer ids diffently than OGR . > > > >> Example if you have a dataset with > > > > - layer1 (geom1, geom2) > > > > - layer2 (geom) > > > >> Then you would map that to : > > -

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On 21 March 2017 at 05:39, Mark Johnson wrote: >>> we only support GDAL >= 2.0 in master > and it is clear that if QGIS is called with a gdal 1.* version the > Application will crash with a Lookup error? Hi Mark! Please keep in mind that's there's some non-negotiables

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > Application will crash with a Lookup error? Yes. And that's perfectly fine. That's only an issue that can happen for us >> developers playing > > with different versions, and we know how to solve those issues. > > The proposed solution for this constellation for-sees - at application start:

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

> > In the provider we could decide to allocate layer ids diffently than OGR . > > >> Example if you have a dataset with > > - layer1 (geom1, geom2) > > - layer2 (geom) > > >> Then you would map that to : > > - qgis_ogr_provider_layer_id = 1: layer1, geom1 > > - qgis_ogr_provider_layer_id = 2:

Re: [Qgis-developer] FOSS4G Boston QGIS presentation?

Hi Larry, I would also welcome, if you could present on behalf of the project. I won't be there - I'd love to come. I like Boston / Cambridge. But I can't join FOSS4G this time. Thanks a lot, Andreas On 20.03.2017 22:05, Tim Sutton wrote: Hi Larry On 20 Mar 2017, at 6:33 PM, Larry

Re: [Qgis-developer] FOSS4G Boston QGIS presentation?

Hi Larry > On 20 Mar 2017, at 6:33 PM, Larry Shaffer wrote: > > Hi, > > Call for presentations ends today (or tomorrow?) for FOSS4G 2017 in Boston. > > Is someone from the QGIS project already giving, or submitted a proposal for, > a 'State of QGIS' type of

[Qgis-developer] GSOC project idea

Dear all, I am Sai Harsh from India, from past 8 months, I am using QGIS. These are the things I am thinking to add in qgis. 1. Without restarting qgis, it will display the newly added plugin. best of my knowledge this feature is not present in qgis. 2.Let us suppose if in a .csv file we have lat,

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On lundi 20 mars 2017 20:39:22 CET Mark Johnson wrote: > >> I see no use of OGR_F_GetGeomFieldRef() so it seems > > that you select among the various different geometry fields by relying on > the > "layer_name(geometry_field_name)" syntax > > That is caused by the fact that the initial list >

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

>> I see no use of OGR_F_GetGeomFieldRef() so it seems that you select among the various different geometry fields by relying on the "layer_name(geometry_field_name)" syntax That is caused by the fact that the initial list (QgsOgrProvider::subLayers()) returns only the

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

>>> Does anyone object to this change landing for 3.0 and 2.18? >> I wonder if it would be good to also: >> >> * set "show selected features" on by default >> * add a warning "no elemenent selected, please do a selection" or >> similar, to avoid the user to think the table is empty. > What about

[Qgis-developer] FOSS4G Boston QGIS presentation?

Hi, Call for presentations ends today (or tomorrow?) for FOSS4G 2017 in Boston. Is someone from the QGIS project already giving, or submitted a proposal for, a 'State of QGIS' type of presentation? If not I will be going and am willing to put in a proposal for such a talk, highlighting QGIS 3

Re: [Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

On lundi 20 mars 2017 11:19:57 CET Mark Johnson wrote: > https://github.com/qgis/QGIS/pull/3697 Mark, Most of my comments in https://github.com/qgis/QGIS/pull/3697#issuecomment-257366410 and https://github.com/qgis/QGIS/pull/3697#issuecomment-257571410 still hold true and I'd really like see

Re: [Qgis-developer] qgis-2.18.4 denies using QGIS_PLUGINPATH?

Hello Alessandro, thank you for the fast answer, but.. Am 20.03.2017 um 11:33 schrieb Alessandro Pasotti: > On Mon, Mar 20, 2017 at 11:17 AM, Jörg Habenicht > wrote: > > Hi all, > > I need some help setting up a separate path to the qgis plugin

Re: [Qgis-developer] qgis-2.18.4 denies using QGIS_PLUGINPATH?

On Mon, Mar 20, 2017 at 11:17 AM, Jörg Habenicht wrote: > Hi all, > > I need some help setting up a separate path to the qgis plugin libs. > I think the environment variable QGIS_PLUGINPATH or the --configpath > setting is not respected during the run of qgis_mapserv.fcgi? > >

[Qgis-developer] qgis-2.18.4 denies using QGIS_PLUGINPATH?

Hi all, I need some help setting up a separate path to the qgis plugin libs. I think the environment variable QGIS_PLUGINPATH or the --configpath setting is not respected during the run of qgis_mapserv.fcgi? Background: I try to setup multiple versions of qgis on our server in parallel. We need

[Qgis-developer] Corrections of QgsOgrProvider implementaion of GDAL 2.0

What is the status of the proper QgsOgrProvider implementaion of GDAL 2.0, as described at this offered solution: https://github.com/qgis/QGIS/pull/3697 And was first reported on the 31.03.2015: https://hub.qgis.org/issues/12479 One way or another this matter needs to be resolved before an

Re: [Qgis-developer] Ubuntu snap for QGIS

There is this PR about adding Snap: https://github.com/qgis/QGIS/pull/3545 2017-03-19 21:40 GMT+01:00 Luigi Pirelli : > hi Roy, I remember there were messages in the list history related with > this. > Luigi Pirelli > >