Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-30 Thread Martin Dobias
On Tue, Aug 30, 2011 at 4:47 PM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi Martin We might want to pick a rule of thumb saying when to safely drop support for old versions of software and what is the earliest time to depend on a recent release. I would say that e.g. 3 years

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Marco Hugentobler
Hi all Seems it depends also on the bison version. I'm getting some errors with bison 2.3. With bison 2.4.1, it works nicely. cd /opt/qgisms/src/Quantum-GIS/build/src/core /usr/bin/bison - o/opt/qgisms/src/Quantum-GIS/build/src/core/qgsexpressionparser.cpp -d -v -t

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Martin Dobias
Hi Tim On Sun, Aug 28, 2011 at 7:28 PM, Tim Sutton li...@linfiniti.com wrote: Hi I'm getting  a lot of win build errors relating to qgsexpression: http://pastie.org/2444030 It could just be some stale binaries left behind that msvc is hanging on to - still investigating... The

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Martin Dobias
Hi Marco On Mon, Aug 29, 2011 at 8:39 AM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi all Seems it depends also on the bison version. I'm getting some errors with bison 2.3. With bison 2.4.1, it works nicely.  cd /opt/qgisms/src/Quantum-GIS/build/src/core /usr/bin/bison -

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Tim Sutton
Hi On Mon, Aug 29, 2011 at 9:14 AM, Martin Dobias wonder...@gmail.com wrote: Hi Marco On Mon, Aug 29, 2011 at 8:39 AM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi all Seems it depends also on the bison version. I'm getting some errors with bison 2.3. With bison 2.4.1, it

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Marco Hugentobler
Hi Martin Looking at the version history of bison, the 2.4.x releases started in 2008 while the 2.3 release went out back in 2006. Maybe we could drop support for 2.3 ? Apparently even debian stable ships with 2.4.x. Debian stable isn't the most conservative distro any more. It's the

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Tim Sutton
Hi Ok it seems to been caused by me inadvertantly trying to build as Debug instead of RelWithDebInfo (well thats my best guess as to what caused it because the problem is gone now). Thanks Tim On Mon, Aug 29, 2011 at 9:58 AM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-29 Thread Martin Dobias
On Mon, Aug 29, 2011 at 9:58 AM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi Martin Looking at the version history of bison, the 2.4.x releases started in 2008 while the 2.3 release went out back in 2006. Maybe we could drop support for 2.3 ? Apparently even debian stable

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-28 Thread Tim Sutton
Hi I'm getting a lot of win build errors relating to qgsexpression: http://pastie.org/2444030 It could just be some stale binaries left behind that msvc is hanging on to - still investigating... Regards Tim On Sun, Aug 21, 2011 at 1:56 PM, Nathan Woodrow madman...@gmail.com wrote:

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-27 Thread Marco Hugentobler
Hi Martin If there are no objections I will apply the changes to master in few days No objections from me, the new class seems to work well. Are you going to remove the search string classes when merging or do you plain to wait until the first other api break has happened? Regards, Marco

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-27 Thread Martin Dobias
On Sat, Aug 27, 2011 at 11:47 AM, Marco Hugentobler marco.hugentob...@sourcepole.ch wrote: Hi Martin If there are no objections I will apply the changes to master in few days No objections from me, the new class seems to work well. Are you going to remove the search string classes when

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-27 Thread Mayeul Kauffmann
PostgreSQL is very strict about type conversions, Sqlite is not strict at all and MySQL is somewhere in the middle. I have ended up with these conversion rules: - implicit conversions to desired types - string-number conversions with invalid input return error - arithmetic operators

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-27 Thread Martin Dobias
On Sat, Aug 27, 2011 at 11:06 PM, Mayeul Kauffmann mayeul.kauffm...@free.fr wrote: PostgreSQL is very strict about type conversions, Sqlite is not strict at all and MySQL is somewhere in the middle. I have ended up with these conversion rules: - implicit conversions to desired types -

Re: [Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-21 Thread Nathan Woodrow
Looking good Martin. No objections from me. The old QgsSearchString was a bit string in the way it handled a few things so I'm glad it's been simplified in your chances. I'm just merging with my expression labeling branch, which used QgsSearchString at the moment. I will report if I find any

[Qgis-developer] QgsExpression: replacement for QgsSearchString

2011-08-19 Thread Martin Dobias
Hi everyone recently I have been trying to fix some flaws in search string implementation and it turned out that rather than fixing them one-by-one it will be easier to rewrite that code completely. Search string and associated searching in attribute table was one of my first contributions to