Re: [Qgis-developer] using indentation scripts

2011-05-06 Thread mayeul . kauffmann
: jef-n reply+p-26150-dcf470ddf5342821ac35239d6bd69865a2dbd...@reply.github.com Cc: qgis-developer qgis-developer@lists.osgeo.org Envoyé: Jeudi 5 Mai 2011 23h49:20 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne Objet: [Qgis-developer] using indentation scripts Hi Jef, Following

Re: [Qgis-developer] using indentation scripts

2011-05-06 Thread Jürgen E . Fischer
Hi Mayeul, On Fri, 06. May 2011 at 19:19:24 +0200, mayeul.kauffm...@free.fr wrote: I guess it's better to have this discussion here than on a comment of line 351 of src/core/symbology-ng/qgsrendererv2.cpp at https://github.com/qgis/Quantum-GIS/pull/3/files#r26150 This wasn't meant get a huge

Re: [Qgis-developer] using indentation scripts / update pull reques

2011-05-06 Thread Mayeul Kauffmann
Hi Jürgen, Thanks a lot for the detailed answer!! Sorry to have bothered you; I agree standardizing indentation can be useful [in fact, it does not make merging more difficult but easier: if indentation is standardized before each commit, nobody will never ever have to merge indentation]. But

[Qgis-developer] using indentation scripts

2011-05-05 Thread Mayeul Kauffmann
Hi Jef, Following your comments on indentation in my patch, I tried to use prepare-commit.sh for more than one hour in vain. When applied after git commit it says nothing has changed (in effect, after commit, my working copy is ahead). So I created a new branch locally to restart from scratch,