Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2024-01-03 Thread Nyall Dawson via QGIS-Developer
On Thu, 4 Jan 2024, 5:23 am Sandro Santilli, wrote: > On Mon, Nov 27, 2023 at 05:09:07PM +1000, Nyall Dawson via QGIS-PSC wrote: > > On Mon, 27 Nov 2023, 4:56 pm Alessandro Pasotti, > wrote: > > > > > https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755 > > > comment the instructions

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2024-01-03 Thread Sandro Santilli via QGIS-Developer
On Mon, Nov 27, 2023 at 05:09:07PM +1000, Nyall Dawson via QGIS-PSC wrote: > On Mon, 27 Nov 2023, 4:56 pm Alessandro Pasotti, wrote: > > > https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755 > > comment the instructions say: > > > > "The full test report (included comparison of

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2023-11-27 Thread Nyall Dawson via QGIS-Developer
On Mon, 27 Nov 2023 at 17:21, Laurențiu Nicola wrote: > On Mon, Nov 27, 2023, at 09:09, Nyall Dawson via QGIS-Developer wrote: > > That's caused by a limitation in GitHub API. We can't retrieve the > workflow run id in an action, so that link will always just point to the > most recent workflow

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2023-11-26 Thread Laurențiu Nicola via QGIS-Developer
On Mon, Nov 27, 2023, at 09:09, Nyall Dawson via QGIS-Developer wrote: > That's caused by a limitation in GitHub API. We can't retrieve the workflow > run id in an action, so that link will always just point to the most recent > workflow run for the PR. Hi Nyall, I'm not sure if that's the one

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2023-11-26 Thread Alessandro Pasotti via QGIS-Developer
On Mon, Nov 27, 2023 at 8:09 AM Nyall Dawson wrote: > > > > On Mon, 27 Nov 2023, 4:56 pm Alessandro Pasotti, wrote: >> >> Hi Nyall, >> >> good news, thank you for this improvement! >> >> Just a quick question, in the linked PR: >> https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2023-11-26 Thread Nyall Dawson via QGIS-Developer
On Mon, 27 Nov 2023, 4:56 pm Alessandro Pasotti, wrote: > Hi Nyall, > > good news, thank you for this improvement! > > Just a quick question, in the linked PR: > https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755 > comment the instructions say: > > "The full test report (included

Re: [QGIS-Developer] [Qgis-psc] QGIS grant report: Improve test result handling on QGIS CI

2023-11-26 Thread Alessandro Pasotti via QGIS-Developer
Hi Nyall, good news, thank you for this improvement! Just a quick question, in the linked PR: https://github.com/qgis/QGIS/pull/55417#issuecomment-1826995755 comment the instructions say: "The full test report (included comparison of rendered vs expected images) can be found under the 'Checks'