Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
On Tue, 21 May 2019 at 01:28, René-Luc Dhont wrote: > > Hi Devs, > > I have removed the commit cherry-picked from Nyall's pull-request that > update the layout designer dialog. > So my Pull-request only contains changes for QGIS Server to fix the > regression about printing selection. > > I have introduced the capability to print selection in QGIS Server for > version 3.4 LTR with the pull-request [Server] Reactivate the capability > to print selection with Server 3.4 https://github.com/qgis/QGIS/pull/8320 > This capability is available for image export and was tested and this > pull-request fix inconsistent use of layout render context flags and add > test to validate it. > > I really hope this will be fix it version 3.4.9. My concerns described in https://github.com/qgis/QGIS/pull/9692/files#r272405690 still stand. Nyall ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi Devs, I have removed the commit cherry-picked from Nyall's pull-request that update the layout designer dialog. So my Pull-request only contains changes for QGIS Server to fix the regression about printing selection. I have introduced the capability to print selection in QGIS Server for version 3.4 LTR with the pull-request [Server] Reactivate the capability to print selection with Server 3.4 https://github.com/qgis/QGIS/pull/8320 This capability is available for image export and was tested and this pull-request fix inconsistent use of layout render context flags and add test to validate it. I really hope this will be fix it version 3.4.9. Regards, René-Luc Le 14/05/2019 à 10:00, René-Luc Dhont a écrit : Hi all, In the PR to fix the QGIS Server regression I only need to backport 1 commit on the 2 provided by Nyall to fix the issue: Layout export - raster divided into tiles, edges evident in pdf/svg https://issues.qgis.org/issues/19500 in the Pull request [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 The one I need is a fix: Fix inconsistent use of layout render context flags https://github.com/qgis/QGIS/pull/9692/commits/0954deaf97638519e9f4b3e28855e03a8a34f5c1 This one concoenrs only render context flags for PDF and SVG output. In the case of image output, the layout render context flags are well set. So do you think, the Pull Request could be accepted, if I remove the UI modifed part and only conserve the modification needed for server ? Regards, René-Luc Le 13/05/2019 à 08:04, Paolo Cavallini a écrit : Hi all, On 12/05/19 09:41, Régis Haubourg wrote: I'd be pleased to test things here but use cases are so numerous that I fail to see how to do this efficiently. I hope we'll one day be able to run those smoke tests as discussed at La Coruna. I was about suggesting doing community-wide testing (having a test package would greatly help). Is it so difficult to identify and test possible regression areas? Cheers. ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi all, In the PR to fix the QGIS Server regression I only need to backport 1 commit on the 2 provided by Nyall to fix the issue: Layout export - raster divided into tiles, edges evident in pdf/svg https://issues.qgis.org/issues/19500 in the Pull request [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 The one I need is a fix: Fix inconsistent use of layout render context flags https://github.com/qgis/QGIS/pull/9692/commits/0954deaf97638519e9f4b3e28855e03a8a34f5c1 This one concoenrs only render context flags for PDF and SVG output. In the case of image output, the layout render context flags are well set. So do you think, the Pull Request could be accepted, if I remove the UI modifed part and only conserve the modification needed for server ? Regards, René-Luc Le 13/05/2019 à 08:04, Paolo Cavallini a écrit : Hi all, On 12/05/19 09:41, Régis Haubourg wrote: I'd be pleased to test things here but use cases are so numerous that I fail to see how to do this efficiently. I hope we'll one day be able to run those smoke tests as discussed at La Coruna. I was about suggesting doing community-wide testing (having a test package would greatly help). Is it so difficult to identify and test possible regression areas? Cheers. ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi all, On 12/05/19 09:41, Régis Haubourg wrote: > I'd be pleased to test things here but use cases are so numerous that I > fail to see how to do this efficiently. > I hope we'll one day be able to run those smoke tests as discussed at La > Coruna. I was about suggesting doing community-wide testing (having a test package would greatly help). Is it so difficult to identify and test possible regression areas? Cheers. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Le dim. 12 mai 2019 à 07:32, Nyall Dawson a écrit : > On Fri, 10 May 2019 at 18:31, René-Luc Dhont wrote: > > > > Hi devs, > > > > I am still waiting for a review about fixing 2 issues in printing for > > QGIS and QGIS Server 3.4 LTR. https://github.com/qgis/QGIS/pull/9692 > > > > This PR wil fix an issue https://issues.qgis.org/issues/19500 `Layout > > export - raster divided into tiles, edges evident in pdf/svg`. This > > issue has been identifed in version 3.2 and has been fixed in 3.6. > > This PR will also fix a regression in QGIS Server `Printing selection in > > PDF and SVG`. The selection is already printed in image output. > > > > The next LTR will be released in 10 mounths. QGIS Server 3.6, which > > already have the fix, is not available on Debian Stretch because it > > requires Qt 5.9 and Debian Buster will be freezed in 8 mounths. So the > > QGIS server regression will not be available since the end of 2019. > > > > I will appreciate a decision about this fix. Do you think QGIS Server > > users have to wait for the next LTR or Debian Buster release ? > > I'm still uncomfortable with the potential risk this has of breaking > layout export in 3.4 for desktop users. So I'm not going to approve > the backport, but if another dev is willing to take on this risk and > approve the backport then I won't stand in the way. > > Nyall > I agree with Nyall here unfortunately. Backporting this could be acceptable at the condition of having a wide integration test coverage and extensive real testing of the fixed branches. I'd be pleased to test things here but use cases are so numerous that I fail to see how to do this efficiently. I hope we'll one day be able to run those smoke tests as discussed at La Coruna. Best regards Régis > > > > Reagrds, > > René-Luc > > > > Le 19/04/2019 à 09:34, René-Luc Dhont a écrit : > > > Hi devs, > > > > > > I have cherry-picked the changes > > > > > > I have tested it without regressions or issues. > > > > > > Now I need some review to merge and fix 2 issues. > > > https://github.com/qgis/QGIS/pull/9692 > > > > > > Regards, > > > René-Luc > > > > > > Le 17/04/2019 à 14:18, René-Luc Dhont a écrit : > > >> Hi devs, > > >> > > >> Thanks Paolo for your agreement. > > >> > > >> I'd like to fix the QGIS Sever regression before friday and the > > >> version 3.4.7 released. > > >> > > >> So I'd like to have other point of view about backporting : > > >> [needs-docs][layouts] Add checkbox to disable raster tiling for > > >> PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 > > >> and finalizing Fix regression server print selection pdf release 3.4 > > >> https://github.com/qgis/QGIS/pull/9692 > > >> > > >> Thanks. > > >> René-Luc > > >> > > >> Le 12/04/2019 à 12:06, Paolo Cavallini a écrit : > > >>> Hi René, > > >>> > > >>> On 12/04/19 12:05, René-Luc Dhont wrote: > > >>> > > I would like to know if I can backport all the commits made by > > Nyall to > > fix issue 19500 even if it updates the User Interface ? > > >>> +1 from my side, but obviously Nyall has the final word on this. > > >>> Thanks. > > >>> > > >> > > > > > > > ___ > > QGIS-Developer mailing list > > QGIS-Developer@lists.osgeo.org > > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
On Fri, 10 May 2019 at 18:31, René-Luc Dhont wrote: > > Hi devs, > > I am still waiting for a review about fixing 2 issues in printing for > QGIS and QGIS Server 3.4 LTR. https://github.com/qgis/QGIS/pull/9692 > > This PR wil fix an issue https://issues.qgis.org/issues/19500 `Layout > export - raster divided into tiles, edges evident in pdf/svg`. This > issue has been identifed in version 3.2 and has been fixed in 3.6. > This PR will also fix a regression in QGIS Server `Printing selection in > PDF and SVG`. The selection is already printed in image output. > > The next LTR will be released in 10 mounths. QGIS Server 3.6, which > already have the fix, is not available on Debian Stretch because it > requires Qt 5.9 and Debian Buster will be freezed in 8 mounths. So the > QGIS server regression will not be available since the end of 2019. > > I will appreciate a decision about this fix. Do you think QGIS Server > users have to wait for the next LTR or Debian Buster release ? I'm still uncomfortable with the potential risk this has of breaking layout export in 3.4 for desktop users. So I'm not going to approve the backport, but if another dev is willing to take on this risk and approve the backport then I won't stand in the way. Nyall > > Reagrds, > René-Luc > > Le 19/04/2019 à 09:34, René-Luc Dhont a écrit : > > Hi devs, > > > > I have cherry-picked the changes > > > > I have tested it without regressions or issues. > > > > Now I need some review to merge and fix 2 issues. > > https://github.com/qgis/QGIS/pull/9692 > > > > Regards, > > René-Luc > > > > Le 17/04/2019 à 14:18, René-Luc Dhont a écrit : > >> Hi devs, > >> > >> Thanks Paolo for your agreement. > >> > >> I'd like to fix the QGIS Sever regression before friday and the > >> version 3.4.7 released. > >> > >> So I'd like to have other point of view about backporting : > >> [needs-docs][layouts] Add checkbox to disable raster tiling for > >> PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 > >> and finalizing Fix regression server print selection pdf release 3.4 > >> https://github.com/qgis/QGIS/pull/9692 > >> > >> Thanks. > >> René-Luc > >> > >> Le 12/04/2019 à 12:06, Paolo Cavallini a écrit : > >>> Hi René, > >>> > >>> On 12/04/19 12:05, René-Luc Dhont wrote: > >>> > I would like to know if I can backport all the commits made by > Nyall to > fix issue 19500 even if it updates the User Interface ? > >>> +1 from my side, but obviously Nyall has the final word on this. > >>> Thanks. > >>> > >> > > > > ___ > QGIS-Developer mailing list > QGIS-Developer@lists.osgeo.org > List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer > Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi René On 10/05/19 10:31, René-Luc Dhont wrote: > Hi devs, > > I am still waiting for a review about fixing 2 issues in printing for > QGIS and QGIS Server 3.4 LTR. https://github.com/qgis/QGIS/pull/9692 > > This PR wil fix an issue https://issues.qgis.org/issues/19500 `Layout > export - raster divided into tiles, edges evident in pdf/svg`. This > issue has been identifed in version 3.2 and has been fixed in 3.6. > This PR will also fix a regression in QGIS Server `Printing selection in > PDF and SVG`. The selection is already printed in image output. > > The next LTR will be released in 10 mounths. QGIS Server 3.6, which > already have the fix, is not available on Debian Stretch because it > requires Qt 5.9 and Debian Buster will be freezed in 8 mounths. So the > QGIS server regression will not be available since the end of 2019. > > I will appreciate a decision about this fix. Do you think QGIS Server > users have to wait for the next LTR or Debian Buster release ? I believe it is very important to keep the LTR server in good shape, and fix whatever is possible. Do you (or anybody else) have reasons to suspect these fixes could be harmful or have side effects? Cheers. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi devs, I am still waiting for a review about fixing 2 issues in printing for QGIS and QGIS Server 3.4 LTR. https://github.com/qgis/QGIS/pull/9692 This PR wil fix an issue https://issues.qgis.org/issues/19500 `Layout export - raster divided into tiles, edges evident in pdf/svg`. This issue has been identifed in version 3.2 and has been fixed in 3.6. This PR will also fix a regression in QGIS Server `Printing selection in PDF and SVG`. The selection is already printed in image output. The next LTR will be released in 10 mounths. QGIS Server 3.6, which already have the fix, is not available on Debian Stretch because it requires Qt 5.9 and Debian Buster will be freezed in 8 mounths. So the QGIS server regression will not be available since the end of 2019. I will appreciate a decision about this fix. Do you think QGIS Server users have to wait for the next LTR or Debian Buster release ? Reagrds, René-Luc Le 19/04/2019 à 09:34, René-Luc Dhont a écrit : Hi devs, I have cherry-picked the changes I have tested it without regressions or issues. Now I need some review to merge and fix 2 issues. https://github.com/qgis/QGIS/pull/9692 Regards, René-Luc Le 17/04/2019 à 14:18, René-Luc Dhont a écrit : Hi devs, Thanks Paolo for your agreement. I'd like to fix the QGIS Sever regression before friday and the version 3.4.7 released. So I'd like to have other point of view about backporting : [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 and finalizing Fix regression server print selection pdf release 3.4 https://github.com/qgis/QGIS/pull/9692 Thanks. René-Luc Le 12/04/2019 à 12:06, Paolo Cavallini a écrit : Hi René, On 12/04/19 12:05, René-Luc Dhont wrote: I would like to know if I can backport all the commits made by Nyall to fix issue 19500 even if it updates the User Interface ? +1 from my side, but obviously Nyall has the final word on this. Thanks. ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi devs, I have cherry-picked the changes I have tested it without regressions or issues. Now I need some review to merge and fix 2 issues. https://github.com/qgis/QGIS/pull/9692 Regards, René-Luc Le 17/04/2019 à 14:18, René-Luc Dhont a écrit : Hi devs, Thanks Paolo for your agreement. I'd like to fix the QGIS Sever regression before friday and the version 3.4.7 released. So I'd like to have other point of view about backporting : [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 and finalizing Fix regression server print selection pdf release 3.4 https://github.com/qgis/QGIS/pull/9692 Thanks. René-Luc Le 12/04/2019 à 12:06, Paolo Cavallini a écrit : Hi René, On 12/04/19 12:05, René-Luc Dhont wrote: I would like to know if I can backport all the commits made by Nyall to fix issue 19500 even if it updates the User Interface ? +1 from my side, but obviously Nyall has the final word on this. Thanks. ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi devs, Thanks Paolo for your agreement. I'd like to fix the QGIS Sever regression before friday and the version 3.4.7 released. So I'd like to have other point of view about backporting : [needs-docs][layouts] Add checkbox to disable raster tiling for PDF/SVG exports https://github.com/qgis/QGIS/pull/9016 and finalizing Fix regression server print selection pdf release 3.4 https://github.com/qgis/QGIS/pull/9692 Thanks. René-Luc Le 12/04/2019 à 12:06, Paolo Cavallini a écrit : Hi René, On 12/04/19 12:05, René-Luc Dhont wrote: I would like to know if I can backport all the commits made by Nyall to fix issue 19500 even if it updates the User Interface ? +1 from my side, but obviously Nyall has the final word on this. Thanks. ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi René, On 12/04/19 12:05, René-Luc Dhont wrote: > I would like to know if I can backport all the commits made by Nyall to > fix issue 19500 even if it updates the User Interface ? +1 from my side, but obviously Nyall has the final word on this. Thanks. -- Paolo Cavallini - www.faunalia.eu QGIS.ORG Chair: http://planet.qgis.org/planet/user/28/tag/qgis%20board/ ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
[QGIS-Developer] Can I backport bugfix with UI updates and fixing QGIS Server regression
Hi Dev, I have worked on fixing a regression in QGIS Server. https://github.com/qgis/QGIS/pull/9692 This regression exists in QGIS 3.4 but has been fixed by Nyall in QGIS 3.6 by fixing an other issue. The issue fixed by Nyall was *Layout export - raster divided into tiles, edges evident in pdf/svg* https://issues.qgis.org/issues/19500 The issue has been found in QGIS 3.2. It has been fixed in QGIS 3.6 but the fix has not been backported to QGIS 3.4. I suppose that the backport has not been done because the fix updates the User Interface. https://github.com/qgis/QGIS/pull/9016 I would like to know if I can backport all the commits made by Nyall to fix issue 19500 even if it updates the User Interface ? I think that this backport has to be done in QGIS 3.4 to fix a desktop issue and a server regression because it is the LTR version, but I need to know if it's the right thing to do. René-Luc ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
