Re: [QGIS-Developer] Processing Split with lines algorithm broken

[G. Allegri]

I also agree to step back to single-part output.

giovanni

2017-11-15 11:13 GMT+01:00 Alexandre Neto :

> +1
>
> Nathan Woodrow  escreveu no dia quarta, 15/11/2017
> às 05:10:
>
>> IMO go with the principle of least astonishment.  I think the expected
>> outcome is single part features as it's not clear that you need to run
>> another step.
>>
>> - Nathan
>>
>> On Wed, Nov 15, 2017 at 2:48 PM, Nyall Dawson 
>> wrote:
>>
>>> On 15 November 2017 at 00:33, matteo  wrote:
>>> > Hi devs,
>>> >
>>> > the algorithm Split with lines seems not working. No output error but
>>> > both lines or polygons in output are not split. The same algorithm with
>>> > the same data works in QGIS 2.18
>>>
>>> I suspect it's working OK, but you're hitting a change in 3.0 where
>>> the output of this algorithm is a multi-line, with the individual
>>> split parts still forming a single feature. You need to run multiparts
>>> to singleparts on it afterward.
>>>
>>> However
>>>
>>> This was a change I requested in
>>> https://github.com/qgis/QGIS/pull/3798, since it seemed like a logical
>>> move. Having used this algorithm extensively since (and also been
>>> confused in thinking that the algorithm was broken!) I'm not convinced
>>> this was the right move anymore, and think that we should probably
>>> always output single-part features from this algorithm.
>>>
>>> What's everyone's thoughts?
>>>
>>> Nyall
>>> ___
>>> QGIS-Developer mailing list
>>> QGIS-Developer@lists.osgeo.org
>>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>>
>>
>> ___
>> QGIS-Developer mailing list
>> QGIS-Developer@lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
> --
> Alexandre Neto
> -
> @AlexNetoGeo
> http://sigsemgrilhetas.wordpress.com
> http://gisunchained.wordpress.com
>
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing Split with lines algorithm broken

[Alexandre Neto]

+1

Nathan Woodrow  escreveu no dia quarta, 15/11/2017 às
05:10:

> IMO go with the principle of least astonishment.  I think the expected
> outcome is single part features as it's not clear that you need to run
> another step.
>
> - Nathan
>
> On Wed, Nov 15, 2017 at 2:48 PM, Nyall Dawson 
> wrote:
>
>> On 15 November 2017 at 00:33, matteo  wrote:
>> > Hi devs,
>> >
>> > the algorithm Split with lines seems not working. No output error but
>> > both lines or polygons in output are not split. The same algorithm with
>> > the same data works in QGIS 2.18
>>
>> I suspect it's working OK, but you're hitting a change in 3.0 where
>> the output of this algorithm is a multi-line, with the individual
>> split parts still forming a single feature. You need to run multiparts
>> to singleparts on it afterward.
>>
>> However
>>
>> This was a change I requested in
>> https://github.com/qgis/QGIS/pull/3798, since it seemed like a logical
>> move. Having used this algorithm extensively since (and also been
>> confused in thinking that the algorithm was broken!) I'm not convinced
>> this was the right move anymore, and think that we should probably
>> always output single-part features from this algorithm.
>>
>> What's everyone's thoughts?
>>
>> Nyall
>> ___
>> QGIS-Developer mailing list
>> QGIS-Developer@lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

-- 
Alexandre Neto
-
@AlexNetoGeo
http://sigsemgrilhetas.wordpress.com
http://gisunchained.wordpress.com
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing Split with lines algorithm broken

[matteo]

Hi Nyall,


> I suspect it's working OK, but you're hitting a change in 3.0 where
> the output of this algorithm is a multi-line, with the individual
> split parts still forming a single feature. You need to run multiparts
> to singleparts on it afterward.

uh... sorry I missed that the multipart is now the output.

However, I think that users (me included) is expecting single part
features as output. I was really confused yesterday and as you can seen
I thought that the algorithm was broken.

So +1 for me to single part output

Thanks for the clarification

Cheers

Matteo
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing Split with lines algorithm broken

[Anita Graser]

On Wed, Nov 15, 2017 at 6:09 AM, Nathan Woodrow  wrote:

> IMO go with the principle of least astonishment.  I think the expected
> outcome is single part features as it's not clear that you need to run
> another step.
>

​+1 Anita​
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing Split with lines algorithm broken

[Nathan Woodrow]

IMO go with the principle of least astonishment.  I think the expected
outcome is single part features as it's not clear that you need to run
another step.

- Nathan

On Wed, Nov 15, 2017 at 2:48 PM, Nyall Dawson 
wrote:

> On 15 November 2017 at 00:33, matteo  wrote:
> > Hi devs,
> >
> > the algorithm Split with lines seems not working. No output error but
> > both lines or polygons in output are not split. The same algorithm with
> > the same data works in QGIS 2.18
>
> I suspect it's working OK, but you're hitting a change in 3.0 where
> the output of this algorithm is a multi-line, with the individual
> split parts still forming a single feature. You need to run multiparts
> to singleparts on it afterward.
>
> However
>
> This was a change I requested in
> https://github.com/qgis/QGIS/pull/3798, since it seemed like a logical
> move. Having used this algorithm extensively since (and also been
> confused in thinking that the algorithm was broken!) I'm not convinced
> this was the right move anymore, and think that we should probably
> always output single-part features from this algorithm.
>
> What's everyone's thoughts?
>
> Nyall
> ___
> QGIS-Developer mailing list
> QGIS-Developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [QGIS-Developer] Processing Split with lines algorithm broken

[Nyall Dawson]

On 15 November 2017 at 00:33, matteo  wrote:
> Hi devs,
>
> the algorithm Split with lines seems not working. No output error but
> both lines or polygons in output are not split. The same algorithm with
> the same data works in QGIS 2.18

I suspect it's working OK, but you're hitting a change in 3.0 where
the output of this algorithm is a multi-line, with the individual
split parts still forming a single feature. You need to run multiparts
to singleparts on it afterward.

However

This was a change I requested in
https://github.com/qgis/QGIS/pull/3798, since it seemed like a logical
move. Having used this algorithm extensively since (and also been
confused in thinking that the algorithm was broken!) I'm not convinced
this was the right move anymore, and think that we should probably
always output single-part features from this algorithm.

What's everyone's thoughts?

Nyall
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[QGIS-Developer] Processing Split with lines algorithm broken

[matteo]

Hi devs,

the algorithm Split with lines seems not working. No output error but
both lines or polygons in output are not split. The same algorithm with
the same data works in QGIS 2.18

Should I open a ticket?

Thanks

Cheers


Matteo
___
QGIS-Developer mailing list
QGIS-Developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer