Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Spencer Gardner]

>>> Does anyone object to this change landing for 3.0 and 2.18?

>> I wonder if it would be good to also:
>>
>> * set "show selected features" on by default
>> * add a warning "no elemenent selected, please do a selection" or
>> similar, to avoid the user to think the table is empty.

> What about adding a msg+button after opening an empty table:
> "Nothing selected so nothing shown" and a dropdown or button: "select
> ALL" and "select ALL in current extent"

+1 on adding this to 2.18.

Would it be possible to include a dropdown arrow on the "Open Attribute
Table" icon, similar to the behavior of the Feature Selection tool? This
way a user can trigger the default option (show all features) by clicking
on the icon, but can also choose "Show selected features" by clicking the
dropdown.

[image to illustrate]
https://www.dropbox.com/s/p394jykld3dc931/select.png?dl=0
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Matthias Kuhn]

On 08/03/2017 18:45, Giovanni Manghi wrote:

> Hi all,
>
>> Hi I agree with Nathan, empty table by default will freak out users.
>> Could we imagine some heuristics that will let the whole table being seen
>> for reasonable sized tables, and only a subset for huge tables, advertised
>> by a warning bar ?
>>
>> I think of displaying visible items in mapcanvas if their number is not too
>> high, and if still too high, remember to show only selected items?
>> We need an exception of course for non geometric tables on that.
>>
>> I would not be shocked by such messages, huge tables should not be entirely
>> fetched, raising a security fence to the user sounds reasonable to me.
> +1
>
> but also... why not
>
> https://github.com/qgis/QGIS/pull/2518

Thanks Giovanni, same thoughts here.

>
> ?
>
> cheers!
>
> -- G --
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>

___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Giovanni Manghi]

Hi all,

> Hi I agree with Nathan, empty table by default will freak out users.
> Could we imagine some heuristics that will let the whole table being seen
> for reasonable sized tables, and only a subset for huge tables, advertised
> by a warning bar ?
>
> I think of displaying visible items in mapcanvas if their number is not too
> high, and if still too high, remember to show only selected items?
> We need an exception of course for non geometric tables on that.
>
> I would not be shocked by such messages, huge tables should not be entirely
> fetched, raising a security fence to the user sounds reasonable to me.

+1

but also... why not

https://github.com/qgis/QGIS/pull/2518

?

cheers!

-- G --
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Régis Haubourg]

Hi I agree with Nathan, empty table by default will freak out users.
Could we imagine some heuristics that will let the whole table being seen
for reasonable sized tables, and only a subset for huge tables, advertised
by a warning bar ?

I think of displaying visible items in mapcanvas if their number is not too
high, and if still too high, remember to show only selected items?
We need an exception of course for non geometric tables on that.

I would not be shocked by such messages, huge tables should not be entirely
fetched, raising a security fence to the user sounds reasonable to me.
Régis

2017-03-07 8:46 GMT+01:00 Nathan Woodrow :

> Yeah I'm not really ok with a empty table as the default.  I understand
> the point but users are going freak at that.
>
> One option might be to ask users what they want when a table is first
> opened for the first time.  E.g what default mode would you like with some
> notes on each.  This is only asked once and never again but gives the user
> the choice.
>
> On Tue, 7 Mar 2017 5:43 pm Denis Rouzaud  wrote:
>
>> Thanks for the precision.
>>
>> Then
>> +1 for showing nothing when no selection
>> +0 for "show only selected" as default mode.
>>
>>
>> Le mar. 7 mars 2017 à 08:30, Nyall Dawson  a
>> écrit :
>>
>> On 7 March 2017 at 17:23, Denis Rouzaud  wrote:
>> >
>> > I'm a bit confused here.
>> >
>> > At the moment, there is a global option for attribute table widget "show
>> > only selected".
>> > If you choose this option and have a selection, you won't have any mean
>> to
>> > show all the layer unless you deselect and reopen the attribute table
>> (hence
>> > showing all). In other words, switching between show all and show
>> selected
>> > only has no effect and shows only selected features.
>> >
>> > Does your work will fix this i.e. really show all features?
>>
>> In current master and 2.18 branch if you set the attribute table to
>> show only selected, and then open the table and change the filter in
>> the bottom left to "show all", then ALL features will be loaded
>> (regardless of the current/original selection)
>>
>> Nyall
>>
>> ___
>> Qgis-developer mailing list
>> Qgis-developer@lists.osgeo.org
>> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
>
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Denis Rouzaud]

What about dropping that option and just use the mode last used in the
table display?


Le mar. 7 mars 2017 à 08:46, Nathan Woodrow  a écrit :

Yeah I'm not really ok with a empty table as the default.  I understand the
point but users are going freak at that.

One option might be to ask users what they want when a table is first
opened for the first time.  E.g what default mode would you like with some
notes on each.  This is only asked once and never again but gives the user
the choice.

On Tue, 7 Mar 2017 5:43 pm Denis Rouzaud  wrote:

Thanks for the precision.

Then
+1 for showing nothing when no selection
+0 for "show only selected" as default mode.


Le mar. 7 mars 2017 à 08:30, Nyall Dawson  a écrit :

On 7 March 2017 at 17:23, Denis Rouzaud  wrote:
>
> I'm a bit confused here.
>
> At the moment, there is a global option for attribute table widget "show
> only selected".
> If you choose this option and have a selection, you won't have any mean to
> show all the layer unless you deselect and reopen the attribute table
(hence
> showing all). In other words, switching between show all and show selected
> only has no effect and shows only selected features.
>
> Does your work will fix this i.e. really show all features?

In current master and 2.18 branch if you set the attribute table to
show only selected, and then open the table and change the filter in
the bottom left to "show all", then ALL features will be loaded
(regardless of the current/original selection)

Nyall

___


Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Nathan Woodrow]

Yeah I'm not really ok with a empty table as the default.  I understand the
point but users are going freak at that.

One option might be to ask users what they want when a table is first
opened for the first time.  E.g what default mode would you like with some
notes on each.  This is only asked once and never again but gives the user
the choice.

On Tue, 7 Mar 2017 5:43 pm Denis Rouzaud  wrote:

> Thanks for the precision.
>
> Then
> +1 for showing nothing when no selection
> +0 for "show only selected" as default mode.
>
>
> Le mar. 7 mars 2017 à 08:30, Nyall Dawson  a
> écrit :
>
> On 7 March 2017 at 17:23, Denis Rouzaud  wrote:
> >
> > I'm a bit confused here.
> >
> > At the moment, there is a global option for attribute table widget "show
> > only selected".
> > If you choose this option and have a selection, you won't have any mean
> to
> > show all the layer unless you deselect and reopen the attribute table
> (hence
> > showing all). In other words, switching between show all and show
> selected
> > only has no effect and shows only selected features.
> >
> > Does your work will fix this i.e. really show all features?
>
> In current master and 2.18 branch if you set the attribute table to
> show only selected, and then open the table and change the filter in
> the bottom left to "show all", then ALL features will be loaded
> (regardless of the current/original selection)
>
> Nyall
>
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Denis Rouzaud]

Thanks for the precision.

Then
+1 for showing nothing when no selection
+0 for "show only selected" as default mode.


Le mar. 7 mars 2017 à 08:30, Nyall Dawson  a écrit :

> On 7 March 2017 at 17:23, Denis Rouzaud  wrote:
> >
> > I'm a bit confused here.
> >
> > At the moment, there is a global option for attribute table widget "show
> > only selected".
> > If you choose this option and have a selection, you won't have any mean
> to
> > show all the layer unless you deselect and reopen the attribute table
> (hence
> > showing all). In other words, switching between show all and show
> selected
> > only has no effect and shows only selected features.
> >
> > Does your work will fix this i.e. really show all features?
>
> In current master and 2.18 branch if you set the attribute table to
> show only selected, and then open the table and change the filter in
> the bottom left to "show all", then ALL features will be loaded
> (regardless of the current/original selection)
>
> Nyall
>
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Nyall Dawson]

On 7 March 2017 at 17:23, Denis Rouzaud  wrote:
>
> I'm a bit confused here.
>
> At the moment, there is a global option for attribute table widget "show
> only selected".
> If you choose this option and have a selection, you won't have any mean to
> show all the layer unless you deselect and reopen the attribute table (hence
> showing all). In other words, switching between show all and show selected
> only has no effect and shows only selected features.
>
> Does your work will fix this i.e. really show all features?

In current master and 2.18 branch if you set the attribute table to
show only selected, and then open the table and change the filter in
the bottom left to "show all", then ALL features will be loaded
(regardless of the current/original selection)

Nyall
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Richard Duivenvoorde]

On 07-03-17 08:08, Paolo Cavallini wrote:
> Il 07/03/2017 05:28, Nyall Dawson ha scritto:
> 
>> Does anyone object to this change landing for 3.0 and 2.18?
> 
> Of course it's a +1 from me.
> I wonder if it would be good to also:
> * set "show selected features" on by default
> * add a warning "no elemenent selected, please do a selection" or
> similar, to avoid the user to think the table is empty.

I'm in favour of this too, just because untill now, the behaviour worked
on small data, but as soon as you work with larger datasets it was bad...

BUT, it should be intuitive for users... people are used to see always a
filled table behaviour...

What about adding a msg+button after opening an empty table:
"Nothing selected so nothing shown" and a dropdown or button: "select
ALL" and "select ALL in current extent"

Setting 'show selected features' on by default...mmm as as it warns me
or is easily stoppable when I load the table for my 12,000,000
postgistable.
I would say: not on by default, but the state saved in the project
configuration, so as soon as user A has selected it for his project with
small tables... keep it like this for a project. For User R which works
with larger datasets, it just works :-)

Regards,

Richard
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Denis Rouzaud]

I'm a bit confused here.

At the moment, there is a global option for attribute table widget "show
only selected".
If you choose this option and have a selection, you won't have any mean to
show all the layer unless you deselect and reopen the attribute table
(hence showing all). In other words, switching between show all and show
selected only has no effect and shows only selected features.

Does your work will fix this i.e. really show all features?

In such case, I'm fine with Paolo's proposal (and yours!)
Otherwise I'm -1: opening the table will show nothing (i.e. no selection)
and you won't be able to show the features.

Please enlighten me!

Cheers,
Denis





Le mar. 7 mars 2017 à 08:08, Paolo Cavallini  a
écrit :

> Il 07/03/2017 05:28, Nyall Dawson ha scritto:
>
> > Does anyone object to this change landing for 3.0 and 2.18?
>
> Of course it's a +1 from me.
> I wonder if it would be good to also:
> * set "show selected features" on by default
> * add a warning "no elemenent selected, please do a selection" or
> similar, to avoid the user to think the table is empty.
> All the best.
> --
> Paolo Cavallini - www.faunalia.eu
> QGIS & PostGIS courses: http://www.faunalia.eu/training.html
> https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Neumann, Andreas]

Hi Paolo, 

I am a -1 on having "show only selected features" on by default. I think
that huge/gigantic tables with performance issues are more an exception
than the rule. Of course in such cases the "show selected only" makes
sense and the project should probably retain this state. But in the
majority of other cases the tables are small enough that this is not an
issue and it would be annoying that one has to select features first for
seeing all the features. 

I also don't think we need any warnings. The top window bars clearly
shows the status of total / filtered / selected features. No need for
extra warnings. 

Andreas 

On 2017-03-07 08:08, Paolo Cavallini wrote:

> Il 07/03/2017 05:28, Nyall Dawson ha scritto:
> 
>> Does anyone object to this change landing for 3.0 and 2.18?
> 
> Of course it's a +1 from me.
> I wonder if it would be good to also:
> * set "show selected features" on by default
> * add a warning "no elemenent selected, please do a selection" or
> similar, to avoid the user to think the table is empty.
> All the best.

  ___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Mathieu Pellerin]

Big +1 too. I always found the current behavior (show all of nothing is
selected) slightly counter-intuitive.

On Tue, Mar 7, 2017 at 11:28 AM, Nyall Dawson 
wrote:

> Hi all,
>
> I'd like to raise discussion about changing the behaviour of the "show
> selected features" mode in the attribute table.
>
> Over the last couple of weeks I've pushed fixes to both 3.0 and
> (shortly) 2.18 to improve the performance of the attribute table when
> this mode is selected (Thanks to Faunalia and ENEL for sponsoring
> this!). With these changes *only* the selected features are fetched
> from providers to show in the attribute table, vs the current
> behaviour of fetching *everything* and then filtering out to the
> selection. It makes a huge difference for working with large layers.
>
> Now - there's one last piece of this I'd like to land, but it changes
> the behaviour of this mode. Currently if you have the table set to
> "show selected features", but there's nothing selected, then ALL
> features are shown.
>
> This kills the benefit of setting the table to show in this mode. If
> you accidentally open the table for a large layer with no selection,
> it'll force every feature to be fetched again.
>
> I'd like to change this, so that no selection = nothing shows in the
> table. This means that users can safely set the attribute table to
> always show in "selected features" mode and be confident that they'll
> never hit the situation where every feature is fetched (unless of
> course they have selected *every* feature!).
>
> Does anyone object to this change landing for 3.0 and 2.18?
>
> Nyall
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Neumann, Andreas]

Hi Nyall, 

I am fine with your proposal. 

In fact, the current behaviour as you described it, can be regarded as a
bug. I agree with you. 

Andreas 

On 2017-03-07 05:28, Nyall Dawson wrote:

> Hi all,
> 
> I'd like to raise discussion about changing the behaviour of the "show
> selected features" mode in the attribute table.
> 
> Over the last couple of weeks I've pushed fixes to both 3.0 and
> (shortly) 2.18 to improve the performance of the attribute table when
> this mode is selected (Thanks to Faunalia and ENEL for sponsoring
> this!). With these changes *only* the selected features are fetched
> from providers to show in the attribute table, vs the current
> behaviour of fetching *everything* and then filtering out to the
> selection. It makes a huge difference for working with large layers.
> 
> Now - there's one last piece of this I'd like to land, but it changes
> the behaviour of this mode. Currently if you have the table set to
> "show selected features", but there's nothing selected, then ALL
> features are shown.
> 
> This kills the benefit of setting the table to show in this mode. If
> you accidentally open the table for a large layer with no selection,
> it'll force every feature to be fetched again.
> 
> I'd like to change this, so that no selection = nothing shows in the
> table. This means that users can safely set the attribute table to
> always show in "selected features" mode and be confident that they'll
> never hit the situation where every feature is fetched (unless of
> course they have selected *every* feature!).
> 
> Does anyone object to this change landing for 3.0 and 2.18?
> 
> Nyall
> ___
> Qgis-developer mailing list
> Qgis-developer@lists.osgeo.org
> List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
> Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

  ___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

Re: [Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Paolo Cavallini]

Il 07/03/2017 05:28, Nyall Dawson ha scritto:

> Does anyone object to this change landing for 3.0 and 2.18?

Of course it's a +1 from me.
I wonder if it would be good to also:
* set "show selected features" on by default
* add a warning "no elemenent selected, please do a selection" or
similar, to avoid the user to think the table is empty.
All the best.
-- 
Paolo Cavallini - www.faunalia.eu
QGIS & PostGIS courses: http://www.faunalia.eu/training.html
https://www.google.com/trends/explore?date=all=IT=qgis,arcgis
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer

[Qgis-developer] Changing behaviour of "show selected features" mode for attribute table

[Nyall Dawson]

Hi all,

I'd like to raise discussion about changing the behaviour of the "show
selected features" mode in the attribute table.

Over the last couple of weeks I've pushed fixes to both 3.0 and
(shortly) 2.18 to improve the performance of the attribute table when
this mode is selected (Thanks to Faunalia and ENEL for sponsoring
this!). With these changes *only* the selected features are fetched
from providers to show in the attribute table, vs the current
behaviour of fetching *everything* and then filtering out to the
selection. It makes a huge difference for working with large layers.

Now - there's one last piece of this I'd like to land, but it changes
the behaviour of this mode. Currently if you have the table set to
"show selected features", but there's nothing selected, then ALL
features are shown.

This kills the benefit of setting the table to show in this mode. If
you accidentally open the table for a large layer with no selection,
it'll force every feature to be fetched again.

I'd like to change this, so that no selection = nothing shows in the
table. This means that users can safely set the attribute table to
always show in "selected features" mode and be confident that they'll
never hit the situation where every feature is fetched (unless of
course they have selected *every* feature!).

Does anyone object to this change landing for 3.0 and 2.18?

Nyall
___
Qgis-developer mailing list
Qgis-developer@lists.osgeo.org
List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer