Re: [Qgis-developer] Field calculator does attribute changes silently

2014-01-07 Thread Marco Hugentobler
Hi Matthias I remember there was a performance consideration leading to the emitSignal parameter in changeAttributeValue. But I don't know if it is still needed, seems to be only used from field calculator, offline editing and a label tool. So +1 for your proposal. Regards, Marco On

Re: [Qgis-developer] Field calculator does attribute changes silently

2014-01-07 Thread Martin Dobias
Hi Matthias On Mon, Jan 6, 2014 at 8:01 PM, Matthias Kuhn matthias.k...@gmx.ch wrote: So my proposal is: * Remove the blockSignal calls and let attribute changes always be promoted * If there are problems introduced, lets fix the problems instead of working around them at the cost of

Re: [Qgis-developer] Field calculator does attribute changes silently

2014-01-07 Thread Matthias Kuhn
Implemented as proposed in 5c38775 [1] If there are followup issues, please respond to this thread or open an issue in the bugtracker. Thank you for your comments, Marco and Martin. Best Matthias https://github.com/qgis/QGIS/commit/5c38775be47e683798b587f0382ca9cd81442565

[Qgis-developer] Field calculator does attribute changes silently

2014-01-06 Thread Matthias Kuhn
Hi, Currently,when the field calculator does changes to attributes (modification, not adding a new column) it blocks signals of the vector layer while doing this. This leads e.g. to bug #9268 [1], that the attribute table is not updating properly. The fix would be very easy (i.e. remove the