Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Tue, Oct 18, 2016 at 11:00:54AM +0200, Mark Johnson wrote: > Inside QgsOgrProvider all of this is done as needed, but when using the > OGR-API directly each step must be done manually. This is done in multi-step already, is it not ?

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Tue, Oct 18, 2016 at 11:55:21AM +0200, Mark Johnson wrote: > > > > The problem, as Germán found out, is that the URI passed as parameter > > is not necessarely an OGR provider URI, but a generic QGIS uri, from > > any provider, so it cannot always be opened via ogr.Open. > > Yes, ogr-sysntax

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

I made a fix to the check that verifies if a string parameter is left blank or not. Before, it just checked that it was None, so empty strings where considered valid values. However, an empty string should be considered a null one (mainly, to raise an exception if that is used for a parameter that

Re: [Qgis-developer] Backport of master feature in QGIS 2.18

2016-10-18 11:40 GMT+02:00 Jürgen E. Fischer : > Hi Harrissou, > > On Tue, 18. Oct 2016 at 11:30:57 +0200, DelazJ wrote: > > > Transifex is already target for QGIS3 (as it sticked with master). > > > > @Jürgen, are you sure about that? > > Yes. But it's not updated regularly. So

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Mon, Oct 17, 2016 at 04:31:51PM +0200, Mark Johnson wrote: > In this case, if I have now understood correctly, you are opening the > source before retrieving the layer. What do you mean by "opening the source" and "retrieving the layer" ? They sound like the same operation to me ? --strk;

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

> > The problem, as Germán found out, is that the URI passed as parameter > is not necessarely an OGR provider URI, but a generic QGIS uri, from > any provider, so it cannot always be opened via ogr.Open. Yes, ogr-sysntax must be used. # -- Spatialite provider # dbname='/tmp/x.sqlite'

[Qgis-developer] Add scripts from file Processing

Hi devs, I'm trying to duplicate the "Add script from file" in Processing also for R algorithms. I'm struggling with an error that happens both with "my" code but also with the default "Add script from file" method. When you click the "Add script from file" menu a dialog opens and you can

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

> > But the above is NOT an ogrDataSource yes, but you are using the OGR-API directly - so you must use the OGR-Syntax i.e. you must 'translate' the syntax used in QgsSpatiaLiteProvider to something OGR will understand. ___ Qgis-developer mailing list

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Tue, Oct 18, 2016 at 12:41:32PM +0200, Mark Johnson wrote: > > > > > Running the automated test is done via: > > > > > > ctest -V -R ProcessingToolsTest > > I have never used this before, from where should it be called? From the root of the build tree. The corresponding code is in

Re: [Qgis-developer] Master_2: error: ‘isinf’ was not declared in this scope

Thanks Matthias, it works! can I push this bugfix and backport it ? Or do I have to create a PR ? Regards, René-Luc Le 17/10/2016 à 18:41, Matthias Kuhn a écrit : Hmmm... What about replacing isinf with qIsInf? (and if required #include "qgis.h")? On 10/17/2016 06:32 PM, René-Luc Dhont

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Mon, Oct 17, 2016 at 09:37:36AM -0500, Germán Carrillo wrote: > Hi All, > > > I've been studying ogrLayerName and GDAL/OGR algorithms in recent days. I > understand ogrLayerName expects a URI from QGIS layers. Of *any* provider, right ? And there's no way to know the provider name from the

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

> > What do you mean by "opening the source" and "retrieving the layer" ? > They sound like the same operation to me ? In the Python code you are using the OGR Interface ds = ogr.Open(ogruri) in c++ (as used in QgsOgrProvider) this corresponds to: OGRDataSourceH hDS = OGROpen( pszPath,

Re: [Qgis-developer] Backport of master feature in QGIS 2.18

Hi, 2016-10-18 2:02 GMT+02:00 Jürgen E. Fischer : > Hi Even, > > On Thu, 13. Oct 2016 at 12:18:38 +0200, Even Rouault wrote: > > - this PR adds new strings to translate (the DBManager changes might > also). > > Will translators do another round of translations for 2.18.x ? If

[Qgis-developer] [processing] OGR imports full of "None" strings, lately

I've noticed lots of "None" strings in the ogr2ogr call from master_2 branch onward and it looks like what you get from unicode(None) in python. The code checks for parameter values's length being > 0 before adding params to ogr2ogr call but all the empty param are now real "None" strings (due to

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

> > It sounds like having getParamaterValue() always return a string > (possibly empty) would reduce regression probabilities. > > Or do you think it's important to distinguish between empty string > and None ? > sounds safe to me. And it would be nicer to make that distinction, but i think it is

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

On Tue, Oct 18, 2016 at 12:45:10PM +0200, Sandro Santilli wrote: > On Tue, Oct 18, 2016 at 12:37:39PM +0200, Victor Olaya wrote: > > I made a fix to the check that verifies if a string parameter is left > > blank or not. Before, it just checked that it was None, so empty > > strings where

Re: [Qgis-developer] Master_2: error: ‘isinf’ was not declared in this scope

Already done yesterday [1]. Nothing to port (yet) ;) Cheers [1] https://github.com/qgis/QGIS/commit/9a962524cae2010d1e22e3e28d081bc057c1134d On 10/18/2016 09:53 AM, René-Luc Dhont wrote: > Thanks Matthias, > > it works! > > can I push this bugfix and backport it ? Or do I have to create a PR

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

> > > Running the automated test is done via: > > > > ctest -V -R ProcessingToolsTest I have never used this before, from where should it be called? Mark ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org List info:

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

Sorry, but I often have problems with python ... Are you supposed to configure something beforehand? This is what I get: UpdateCTestConfiguration from :.../QGIS/build_release-2_16/DartConfiguration.tcl Parse Config

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

On Tue, Oct 18, 2016 at 12:37:39PM +0200, Victor Olaya wrote: > I made a fix to the check that verifies if a string parameter is left > blank or not. Before, it just checked that it was None, so empty > strings where considered valid values. However, an empty string should > be considered a null

[Qgis-developer] PG credentials

Hi all, if I open a project without saved credentials for PostgreSQL access, they seem to be taken from the system (the last used credentials). Is this confirmed, and the expected behaviour? All the best, and thanks. -- Paolo Cavallini - www.faunalia.eu QGIS & PostGIS courses:

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

Le mardi 18 octobre 2016 11:59:04, Sandro Santilli a écrit : > On Tue, Oct 18, 2016 at 11:55:21AM +0200, Mark Johnson wrote: > > > The problem, as Germán found out, is that the URI passed as parameter > > > is not necessarely an OGR provider URI, but a generic QGIS uri, from > > > any provider, so

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

> > Didn't you use "ctest" ? Yes, the first list of errors was from that > PYTHONPATH to include ${BUILDDIR}/output/python/plugins. Have done that and now am building the latest branch > using latest tree > in release-2_16 branch Before you wrote branch 'master_2' - that is what I checked

Re: [Qgis-developer] PG credentials

Hi Paolo, hm - not sure. If you have a .pgpass file it may take credentials from the .pgpass file. Not sure what you mean "from the system" - you mean the credentials from the operating system? Yes - this is another fallback mechanism - but it depends how you configured your PostgreSQL

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

On Tue, Oct 18, 2016 at 12:48:18PM +0200, Victor Olaya wrote: > > > > It sounds like having getParamaterValue() always return a string > > (possibly empty) would reduce regression probabilities. > > > > Or do you think it's important to distinguish between empty string > > and None ? > > sounds

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

On Tue, Oct 18, 2016 at 03:38:27PM +0200, Sandro Santilli wrote: > On Tue, Oct 18, 2016 at 12:48:18PM +0200, Victor Olaya wrote: > > > > > > It sounds like having getParamaterValue() always return a string > > > (possibly empty) would reduce regression probabilities. > > > > > > Or do you think

[Qgis-developer] Building QGIS master on Windows

I'm having trouble running a self built QGIS 2.99 from Visual Studio 2015. In QgsPythonUtilsImpl::initPython I get an exception when running the line: runString( "qgis.utils.initInterface(" + QString::number(( unsigned long ) interface ) + ')' ); Debug output:

Re: [Qgis-developer] ogrLayerName in processing/tools/vector.py

On Tue, Oct 18, 2016 at 01:36:14PM +0200, Mark Johnson wrote: > Sorry, but I often have problems with python ... > > Are you supposed to configure something beforehand? > This is what I get: > > python ToolsTest.py Didn't you use "ctest" ? > Traceback (most recent call last): > File

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

I just made this fix, which should solve those issues https://github.com/qgis/QGIS/commit/d7bd5dc50705eec3f37ef82fc819b5bc47cce0f0 Let me know if we need to do something else. 2016-10-18 17:40 GMT+02:00 Sandro Santilli : > German, I think the best way would be to: > > 1) File a

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

On Tue, Oct 18, 2016 at 05:44:43PM +0200, Victor Olaya wrote: > I just made this fix, which should solve those issues > > https://github.com/qgis/QGIS/commit/d7bd5dc50705eec3f37ef82fc819b5bc47cce0f0 > > Let me know if we need to do something else. I still think a testcase would be very useful.

[Qgis-developer] Plugin [284] Semi-Automatic Classification Plugin approval notification.

Plugin Semi-Automatic Classification Plugin approval by pcav. The plugin version "[284] Semi-Automatic Classification Plugin 5.1.3" is now approved Link: http://plugins.qgis.org/plugins/SemiAutomaticClassificationPlugin/ ___ Qgis-developer mailing list

Re: [Qgis-developer] PG credentials

Il 18/10/2016 18:23, Matthias Kuhn ha scritto: > Something else that is able to cache passwords persistently is the auth > system > > https://docs.qgis.org/2.14/en/docs/user_manual/auth_system/auth_overview.html Yes, but this has to be done explicitly, the base mechanism is transparent (and may

[Qgis-developer] Plugin [1104] wfsOutputExtension approval notification.

Plugin wfsOutputExtension approval by pcav. The plugin version "[1104] wfsOutputExtension 1.0.1 Experimental" is now approved Link: http://plugins.qgis.org/plugins/wfsOutputExtension/ ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org List

Re: [Qgis-developer] PG credentials

Hi Paolo On 10/18/2016 06:19 PM, Paolo Cavallini wrote: > Il 18/10/2016 17:58, Jürgen E. Fischer ha scritto: >> H Paolo, >> >> On Tue, 18. Oct 2016 at 16:44:31 +0200, Paolo Cavallini wrote: >>> thanks for the feedback. The situation is: >>> * a qgs project pointing to PostgreSQL, without username

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

German, I think the best way would be to: 1) File a ticket, targetted at 2.18 and marked as Sever/Regression 2) Make a PR containing an automated testcase showing the problem 3) Add a revert of the offending commit in the PR, showing how it fixes the testcase. Do you agree, Victor ?

Re: [Qgis-developer] PG credentials

H Paolo, On Tue, 18. Oct 2016 at 16:44:31 +0200, Paolo Cavallini wrote: > thanks for the feedback. The situation is: > * a qgs project pointing to PostgreSQL, without username and password > * if one inserts the credentials at project startup, these seem to be > remembered upon further opening of

Re: [Qgis-developer] PG credentials

Il 18/10/2016 17:58, Jürgen E. Fischer ha scritto: > H Paolo, > > On Tue, 18. Oct 2016 at 16:44:31 +0200, Paolo Cavallini wrote: >> thanks for the feedback. The situation is: >> * a qgs project pointing to PostgreSQL, without username and password >> * if one inserts the credentials at project

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

Yes, they should. I will take care of that 2016-10-18 17:48 GMT+02:00 Sandro Santilli : > On Tue, Oct 18, 2016 at 05:44:43PM +0200, Victor Olaya wrote: >> I just made this fix, which should solve those issues >> >>

[Qgis-developer] Plugin [976] QAD approval notification.

Plugin QAD approval by pcav. The plugin version "[976] QAD 2.8.13" is now approved Link: http://plugins.qgis.org/plugins/qad/ ___ Qgis-developer mailing list Qgis-developer@lists.osgeo.org List info:

Re: [Qgis-developer] PG credentials

Il 18/10/2016 13:54, Neumann, Andreas ha scritto: > Hi Paolo, > > hm - not sure. > > If you have a .pgpass file it may take credentials from the .pgpass file. > > Not sure what you mean "from the system" - you mean the credentials from > the operating system? Yes - this is another fallback

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 8:42 GMT-05:00 Sandro Santilli : > https://github.com/qgis/qgis/commit/61a10df45283a47782bf49ac62f9c5 > e5f9b27b21 Hi All, what would be the way to deal with this? It's currently preventing me from pushing my final commit to this PR [1], which I hope can make it into

Re: [Qgis-developer] Newbie question re: Qt, PyQt on MAC Yosemite, Sierra

Ah, the Designer part is now a problem. You could try using Pacifist to manually extract the needed parts from the Qt installer, 4.8 still uses Apple's installer packaging (Qt5 started using their own packaging mechanism, bleh), and either skip the /usr/* stuff or put it somewhere else. I

Re: [Qgis-developer] Building and debugging QGIS on Windows x64

Hi Casper I have recently build QGIS on my Windows10 system with Visual Studio 2010 with partial success. I could run and debug QGIS, but Python support did not work (yet). This is my shortlist of fixes to get my build working: add libs to qgis_core: setupapi.lib C:\OSGeo4W64\lib\lwgeom.lib