Re: [QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18
Nyall Dawson wrote > I've re-opened the > original PR and closed the revised version, and if Travis is ok > (fingers crossed) I'll merge it. Thank you again Nyall! - Andrea Giudiceandrea -- Sent from: http://osgeo-org.1560.x6.nabble.com/QGIS-Developer-f4099106.html ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18
On 10 April 2018 at 22:21, andreaerdna wrote: > Dear developers, > about two months ago I reported a longstanding bug in QGIS 2.18 > (https://issues.qgis.org/issues/18132) about a wrong dpi resolution in > images exported from composer. > > Two weeks later I sent a pull request > (https://github.com/qgis/QGIS/pull/6524) with a little commit that would fix > the bug, and about a month ago Nyall Dawson (thanks you!) slightly revised > and tweaked the commit (https://github.com/qgis/QGIS/pull/6620). > > Since then, the pull request was not yet merged. > > I don't know well the procedures, so I'd like to know if there is anything I > have to do to get the pull request merged in time for the next 2.18 point > release. Sorry - this is totally my fault. My revised PR caused rendering test fails on Travis and honestly, I'm finding the 2.18 code so painful/stressful to work with now that I just couldn't get up the motivation to fix these tests in my volunteer time. I've re-opened the original PR and closed the revised version, and if Travis is ok (fingers crossed) I'll merge it. Nyall ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18
On Thu, Apr 12, 2018 at 10:56 AM, andreaerdna wrote: > Dear Alessandro, > thanks for the tips. > > The strange thing is that my original pull request (#6524) passed all the > tests so it would have been possible to merge it, but it was later closed > by > Nyall Dawson that slightly modified my commit and submitted a new pull > request (#6620) that doesn't pass the tests. > > Do you think it would be appropriate to submit again the original pull > request in order to circumvent this "impasse"? > > Best regards. > > No: I think that what you need to do is to check the failure (which appears to be a minor difference of 1 pixel in the size of the generate image) and replace the reference image in order to make the test pass. -- Alessandro Pasotti w3: www.itopen.it ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18
Dear Alessandro, thanks for the tips. The strange thing is that my original pull request (#6524) passed all the tests so it would have been possible to merge it, but it was later closed by Nyall Dawson that slightly modified my commit and submitted a new pull request (#6620) that doesn't pass the tests. Do you think it would be appropriate to submit again the original pull request in order to circumvent this "impasse"? Best regards. - Andrea Giudiceandrea -- Sent from: http://osgeo-org.1560.x6.nabble.com/QGIS-Developer-f4099106.html ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
Re: [QGIS-Developer] About merging a commit to fix the bug #18132 in QGIS 2.18
On Tue, Apr 10, 2018 at 2:21 PM, andreaerdna wrote: > Dear developers, > about two months ago I reported a longstanding bug in QGIS 2.18 > (https://issues.qgis.org/issues/18132) about a wrong dpi resolution in > images exported from composer. > > Two weeks later I sent a pull request > (https://github.com/qgis/QGIS/pull/6524) with a little commit that would > fix > the bug, and about a month ago Nyall Dawson (thanks you!) slightly revised > and tweaked the commit (https://github.com/qgis/QGIS/pull/6620). > > Since then, the pull request was not yet merged. > > I don't know well the procedures, so I'd like to know if there is anything > I > have to do to get the pull request merged in time for the next 2.18 point > release. > > Thank you in advance. > > Andrea Giudiceandrea > > Hi Andrea, I'm sorry for the delay, looks like there is at least one failing test: https://travis-ci.org/qgis/QGIS/jobs/354180088#L1367 this must be fixed before anybody could possibly merge. If the failure is a false negative, you should just create a new reference image for the the test (and possibly a mask image). Unfortunately this is not trivial if you've not done it before, and requires some time even if you've done it before. See: https://docs.qgis.org/testing/en/docs/developers_guide/unittesting.html#comparing-images-for-rendering-tests See also: https://dash.orfeo-toolbox.org/testDetails.php?test=68355414&build=312657 (look at the very end of the page) Hope this helps. -- Alessandro Pasotti w3: www.itopen.it ___ QGIS-Developer mailing list QGIS-Developer@lists.osgeo.org List info: https://lists.osgeo.org/mailman/listinfo/qgis-developer Unsubscribe: https://lists.osgeo.org/mailman/listinfo/qgis-developer
