Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-19 Thread Germán Carrillo
My bad, Victor. I was testing against an old build. Just re-built QGIS and the None is gone. Thanks for the fix. Regards, Germán 2016-10-19 16:05 GMT-05:00 Victor Olaya : > hmm, it's strange that you get None...If the value pased is empty or None, > it should set an empty

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-19 Thread Victor Olaya
hmm, it's strange that you get None...If the value pased is empty or None, it should set an empty string as value see: https://github.com/qgis/QGIS/commit/d911671b0669d3654d85954b52e38a9f5e952d4a I adapted the test to check that, and it is passing see:

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-19 Thread Germán Carrillo
After rebasing a few hours ago, I'm still having issues (None appearing in ogr2ogr commands) with the same example described in this comment [1] (OGR "Convert format" algorithm). Am I doing something wrong? Should I fix/adjust/add something to OGR algorithms? Regards, Germán -- [1]

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Victor Olaya
Yes, they should. I will take care of that 2016-10-18 17:48 GMT+02:00 Sandro Santilli : > On Tue, Oct 18, 2016 at 05:44:43PM +0200, Victor Olaya wrote: >> I just made this fix, which should solve those issues >> >>

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
On Tue, Oct 18, 2016 at 05:44:43PM +0200, Victor Olaya wrote: > I just made this fix, which should solve those issues > > https://github.com/qgis/QGIS/commit/d7bd5dc50705eec3f37ef82fc819b5bc47cce0f0 > > Let me know if we need to do something else. I still think a testcase would be very useful.

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Victor Olaya
I just made this fix, which should solve those issues https://github.com/qgis/QGIS/commit/d7bd5dc50705eec3f37ef82fc819b5bc47cce0f0 Let me know if we need to do something else. 2016-10-18 17:40 GMT+02:00 Sandro Santilli : > German, I think the best way would be to: > > 1) File a

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
German, I think the best way would be to: 1) File a ticket, targetted at 2.18 and marked as Sever/Regression 2) Make a PR containing an automated testcase showing the problem 3) Add a revert of the offending commit in the PR, showing how it fixes the testcase. Do you agree, Victor ?

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Germán Carrillo
2016-10-18 8:42 GMT-05:00 Sandro Santilli : > https://github.com/qgis/qgis/commit/61a10df45283a47782bf49ac62f9c5 > e5f9b27b21 Hi All, what would be the way to deal with this? It's currently preventing me from pushing my final commit to this PR [1], which I hope can make it into

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
On Tue, Oct 18, 2016 at 03:38:27PM +0200, Sandro Santilli wrote: > On Tue, Oct 18, 2016 at 12:48:18PM +0200, Victor Olaya wrote: > > > > > > It sounds like having getParamaterValue() always return a string > > > (possibly empty) would reduce regression probabilities. > > > > > > Or do you think

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
On Tue, Oct 18, 2016 at 12:48:18PM +0200, Victor Olaya wrote: > > > > It sounds like having getParamaterValue() always return a string > > (possibly empty) would reduce regression probabilities. > > > > Or do you think it's important to distinguish between empty string > > and None ? > > sounds

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Victor Olaya
> > It sounds like having getParamaterValue() always return a string > (possibly empty) would reduce regression probabilities. > > Or do you think it's important to distinguish between empty string > and None ? > sounds safe to me. And it would be nicer to make that distinction, but i think it is

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
On Tue, Oct 18, 2016 at 12:45:10PM +0200, Sandro Santilli wrote: > On Tue, Oct 18, 2016 at 12:37:39PM +0200, Victor Olaya wrote: > > I made a fix to the check that verifies if a string parameter is left > > blank or not. Before, it just checked that it was None, so empty > > strings where

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Sandro Santilli
On Tue, Oct 18, 2016 at 12:37:39PM +0200, Victor Olaya wrote: > I made a fix to the check that verifies if a string parameter is left > blank or not. Before, it just checked that it was None, so empty > strings where considered valid values. However, an empty string should > be considered a null

Re: [Qgis-developer] [processing] OGR imports full of "None" strings, lately

2016-10-18 Thread Victor Olaya
I made a fix to the check that verifies if a string parameter is left blank or not. Before, it just checked that it was None, so empty strings where considered valid values. However, an empty string should be considered a null one (mainly, to raise an exception if that is used for a parameter that