Re: [qi4j-dev] SQL related codebase review

2011-04-07 Thread Stanislav Muhametsin
Quoting Stanislav Muhametsin : Quoting Paul Merlin : @Stanislav: as you know I tried to add Derby support in java-sql-generator without success. Could you take a look ? I will look at the issue in the next few days and report what I find. Ah, seems that there was simply missing testRunt

Re: [qi4j-dev] SQL related codebase review

2011-04-04 Thread Rickard Öberg
On 4/4/11 23:34 , Paul Merlin wrote: libraries/sql = The new DataSource handling code pushed by Rickard has many advantages over the old one: - support the CircuitBreaker pattern - expose configuration and restart operations through JMX On the other side this new code is actually co

Re: [qi4j-dev] SQL related codebase review

2011-04-04 Thread Stanislav Muhametsin
Quoting Paul Merlin : indexing-sql I do not use this extension myself so I can't say a lot appart from the fact that in the default build there are no unit tests running for real against a database. Only one implementation of indexing-sql is available for PostgreSQL. Once java-

Re: [qi4j-dev] SQL related codebase review

2011-04-04 Thread Stanislav Muhametsin
Quoting Paul Merlin : @Stanislav: as you know I tried to add Derby support in java-sql-generator without success. Could you take a look ? I will look at the issue in the next few days and report what I find. ___ qi4j-dev mailing list qi4j-dev@lis

Re: [qi4j-dev] SQL related codebase review

2011-04-04 Thread Niclas Hedhman
On Tue, Apr 5, 2011 at 12:34 AM, Niclas Hedhman wrote: > On Mon, Apr 4, 2011 at 11:34 PM, Paul Merlin wrote: >> @Niclas & @Rickard: Do we try to put that in 1.3 final? What would be a >> reasonable deadline for this to be in the final 1.3? And I have a need for Qi4j 1.3 'as soon as possible', bu

Re: [qi4j-dev] SQL related codebase review

2011-04-04 Thread Niclas Hedhman
On Mon, Apr 4, 2011 at 11:34 PM, Paul Merlin wrote: > @Niclas & @Rickard: Do we try to put that in 1.3 final? What would be a > reasonable deadline for this to be in the final 1.3? I don't use SQL myself, and don't have any opinion in either way. Thanks for taking some cycles on this. Cheers -

[qi4j-dev] SQL related codebase review

2011-04-04 Thread Paul Merlin
Gang, I made a quick code review in the SQL related Qi4j codebase, here are my thoughts. libraries/sql = The new DataSource handling code pushed by Rickard has many advantages over the old one: - support the CircuitBreaker pattern - expose configuration and restart operations thro