Re: [qooxdoo-devel] Small issue with VirtualCombobox

2012-10-12 Thread Benjamin Dreux 
Hi
 Here is the bug report http://bugzilla.qooxdoo.org/show_bug.cgi?id=6895
I Hope this will help.

Regards

2012/10/12 thron7 

>  You should open a bug for it, and add the pull request link in a comment.
> Pull requests alone won't help.
>
> T.
>
>
> On 10/11/2012 08:39 PM, Benjamin Dreux wrote:
>
> Hi
>
>  To make everyone work easier, i've made a fork of the qooxdoo repo, and
> I've send a pull request for it to be analysed
>
> Regards
> 2012/10/11 Benjamin Dreux 
>
>> Hi
>> In the code of virtualCombobox
>> There is a method called __onSelectionChange
>>
>>   /**
>>
>>
>>  * Handler to synchronize selection changes with the value property.
>>
>>
>>
>>  *
>>  * @param event {qx.event.type.Data} The change event from the 
>> qx.data.Array.
>>
>>
>>
>>  */
>>
>>
>>
>>
>> __onSelectionChange : function(event) {
>>
>>
>>
>>   if (this.__ignoreChangeSelection == true) {
>>
>>
>>
>> return;
>>   }
>>
>>   var selected = this.__selection.getItem(0);
>>
>>
>>
>>   selected = this.__convertValue(selected);
>>
>>
>>
>>   this.setValue(selected);
>>
>>
>>
>> },
>>
>> I think this should be modified. Because if the currentSelection is
>> empty, then
>> getItem(0) return undefined
>> __convert(undefined) will return undefined
>> Then set value will fail. I suspect that is because the undefined value
>> can't be matched with any item of the list.
>>
>>  Before submitting a bug report, i want to be sure that it wont be an
>> issue if this method do a early return
>>
>>
>>  --
>> Benjamin Dreux
>> Analyste-Programmeur
>> Chaire de logiciel libre-Finance Social et solidaire
>> UQAM
>> Montréal
>>
>
>
>
>  --
> Benjamin Dreux
> Analyste-Programmeur
> Chaire de logiciel libre-Finance Social et solidaire
> UQAM
> Montréal
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt 
> too!http://p.sf.net/sfu/newrelic-dev2dev
>
>
>
> ___
> qooxdoo-devel mailing 
> [email protected]://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
>
>
> --
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> ___
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
>


-- 
Benjamin Dreux
Analyste-Programmeur
Chaire de logiciel libre-Finance Social et solidaire
UQAM
Montréal
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Re: [qooxdoo-devel] Small issue with VirtualCombobox

2012-10-12 Thread thron7 
You should open a bug for it, and add the pull request link in a 
comment. Pull requests alone won't help.


T.

On 10/11/2012 08:39 PM, Benjamin Dreux wrote:

Hi

To make everyone work easier, i've made a fork of the qooxdoo repo, 
and I've send a pull request for it to be analysed


Regards
2012/10/11 Benjamin Dreux >


Hi
In the code of virtualCombobox
There is a method called __onSelectionChange

/**
* Handler to synchronize selection changes with the value property.
*
* @param event {qx.event.type.Data} The change event from the
qx.data.Array.



*/
__onSelectionChange : function(event) {



if (this.__ignoreChangeSelection == true) {



return;

}
var selected = this.__selection.getItem(0);



selected = this.__convertValue(selected);



this.setValue(selected);



},

I think this should be modified. Because if the currentSelection
is empty, then
getItem(0) return undefined
__convert(undefined) will return undefined
Then set value will fail. I suspect that is because the undefined
value can't be matched with any item of the list.

Before submitting a bug report, i want to be sure that it wont be
an issue if this method do a early return


-- 
Benjamin Dreux

Analyste-Programmeur
Chaire de logiciel libre-Finance Social et solidaire
UQAM
Montréal




--
Benjamin Dreux
Analyste-Programmeur
Chaire de logiciel libre-Finance Social et solidaire
UQAM
Montréal


--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev


___
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Re: [qooxdoo-devel] Small issue with VirtualCombobox

2012-10-11 Thread Benjamin Dreux 
Hi

To make everyone work easier, i've made a fork of the qooxdoo repo, and
I've send a pull request for it to be analysed

Regards
2012/10/11 Benjamin Dreux 

> Hi
> In the code of virtualCombobox
> There is a method called __onSelectionChange
>
>  /**
>
>  * Handler to synchronize selection changes with the value property.
>
>  *
>  * @param event {qx.event.type.Data} The change event from the 
> qx.data.Array.
>
>  */
>
>
> __onSelectionChange : function(event) {
>
>   if (this.__ignoreChangeSelection == true) {
>
> return;
>   }
>
>   var selected = this.__selection.getItem(0);
>
>   selected = this.__convertValue(selected);
>
>
>   this.setValue(selected);
>
> },
>
> I think this should be modified. Because if the currentSelection is empty,
> then
> getItem(0) return undefined
> __convert(undefined) will return undefined
> Then set value will fail. I suspect that is because the undefined value
> can't be matched with any item of the list.
>
> Before submitting a bug report, i want to be sure that it wont be an issue
> if this method do a early return
>
>
> --
> Benjamin Dreux
> Analyste-Programmeur
> Chaire de logiciel libre-Finance Social et solidaire
> UQAM
> Montréal
>



-- 
Benjamin Dreux
Analyste-Programmeur
Chaire de logiciel libre-Finance Social et solidaire
UQAM
Montréal
--
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev___
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel