Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
On Thu, 28 Apr 2005, Gerald wrote: I get the diff -ur on 4.0.7 -> 4.0.8. Forget I asked. After I hit send I realized that was a goofy request. I'll diff it myself. 4.0.5 -> 4.0.8 so fast kind of caught me by surprise. G
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
On Thu, 28 Apr 2005, Randall Gellens wrote: Turns out that on some platforms you need to include . This fix will be in 4.0.8. Crap. Almost had a patch ready for 4.0.7 to submit to ports. Is this in CVS? Can I get the diff -ur on 4.0.7 -> 4.0.8. Gerald
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
At 4:23 PM -0700 4/27/05, Randall Gellens wrote: At 9:09 AM -0700 4/27/05, Ken A wrote: pop_pass.c: In function `check_password': pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast I get the same warnings on SunOS. Looking into it a bit more, it appears that, even though unistd.h is being included, the prototype for crypt() is never hit. Turns out that on some platforms you need to include . This fix will be in 4.0.8. -- Randall Gellens Opinions are personal;facts are suspect;I speak for myself only -- Randomly-selected tag: --- There will be no lasting peace on our earth as long as politicians and dictators continue to lead masses of people who are endemically neurotic and sexually sick.--Wilhelm Reich
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
At 9:09 AM -0700 4/27/05, Ken A wrote: pop_pass.c: In function `check_password': pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast I get the same warnings on SunOS. Looking into it a bit more, it appears that, even though unistd.h is being included, the prototype for crypt() is never hit. The SunOS unistd.h has two prototypes for crypt(), both guarded by #if (defined(_XOPEN_SOURCE) && (_XOPEN_VERSION - 0 >= 4)) || \ defined(__EXTENSIONS__) I'm not sure why there are two, but it seems that both are skipped. The warnings are annoying, but not serious. Still, it would be nice to fix this. Can you check /usr/include/unistd.h on your platform and see what the crypt() prototype looks like and if it is guarded by #ifdef conditions? -- Randall Gellens Opinions are personal;facts are suspect;I speak for myself only -- Randomly-selected tag: --- There is always an easy solution to every human problem -- neat, plausible, and wrong.--H.L. Mencken
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
Randall Gellens wrote: At 9:09 AM -0700 4/27/05, Ken A wrote: pop_pass.c: In function `check_password': pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast I get the same warnings on SunOS. Looking into it a bit more, it appears that, even though unistd.h is being included, the prototype for crypt() is never hit. The SunOS unistd.h has two prototypes for crypt(), both guarded by #if (defined(_XOPEN_SOURCE) && (_XOPEN_VERSION - 0 >= 4)) || \ defined(__EXTENSIONS__) I'm not sure why there are two, but it seems that both are skipped. The warnings are annoying, but not serious. Still, it would be nice to fix this. Can you check /usr/include/unistd.h on your platform and see what the crypt() prototype looks like and if it is guarded by #ifdef conditions? Yep: --- snip --- /* XPG4.2 specifies that prototypes for the encryption functions must be defined here. */ #ifdef __USE_XOPEN /* Encrypt at most 8 characters from KEY using salt to perturb DES. */ extern char *crypt (__const char *__key, __const char *__salt) __THROW __nonnull ((1, 2)); /* Encrypt data in BLOCK in place if EDFLAG is zero; otherwise decrypt block in place. */ extern void encrypt (char *__block, int __edflag) __THROW __nonnull ((1)); /* Swab pairs bytes in the first N bytes of the area pointed to by FROM and copy the result to TO. The value of TO must not be in the range [FROM - N + 1, FROM - 1]. If N is odd the first byte in FROM is without partner. */ extern void swab (__const void *__restrict __from, void *__restrict __to, ssize_t __n) __THROW __nonnull ((1, 2)); #endif --- snip --- Ken
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
I still see the same warnings, now on a different line. pop_pass.c: In function `check_password': pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:1365: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast Thanks, Ken A Randall Gellens wrote: At 1:36 PM -0700 4/26/05, Ken A wrote: pop_pass.c: In function `check_password': pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast This does not happen with 4.0.6b3 Anything to be concerned about? I've been trying to figure this one out myself. You might try with the enclosed patch against pop_pass.c.
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
At 7:27 PM +0200 4/26/05, [EMAIL PROTECTED] wrote: Tried to install on HP-UX 11.11 where I already are running 4.0.5 Got this: gcc -c -I.. -I.. -I. Ö -I../mmangle -I../common Ö -g -O2 -DHAVE_CONFIG_H -DHPUX -DSPEC_POP_AUTH -DUNIX pop_pass.c -o pop_ pass.o pop_pass.c: In function écheck_password': pop_pass.c:204: warning: passing arg 1 of éstrcmp' makes pointer from integer wi thout a cast In file included from pop_pass.c:771: /usr/include/prot.h: At top level: /usr/include/prot.h:664: error: conflicting types for 'bigcrypt' pop_pass.c:204: error: previous implicit declaration of 'bigcrypt' was here makeÄ1Å: *** Äpop_pass.oÅ Error 1 makeÄ1Å: Leaving directory é/tmp/qpopper4.0.7/popper' make: *** Äpopper_serverÅ Error 2 Likely check_password() needs to be moved below the special includes for HPUX etc. Please try applying the attached patch to popper/pop_pass.c, which does just that. Please let me know if this fixes the problem. -- Randall Gellens Opinions are personal;facts are suspect;I speak for myself only -- Randomly-selected tag: --- Do not condemn the judgement of another because it differs from your own. You may both be wrong. --Dandemis pop_pass.c.patch Description: Binary data
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
At 1:36 PM -0700 4/26/05, Ken A wrote: pop_pass.c: In function `check_password': pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast This does not happen with 4.0.6b3 Anything to be concerned about? I've been trying to figure this one out myself. You might try with the enclosed patch against pop_pass.c. -- Randall Gellens Opinions are personal;facts are suspect;I speak for myself only -- Randomly-selected tag: --- Honk if you hate bumper stickers that say "Honk if ..." pop_pass.c.patch Description: Binary data
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
At 04:36 PM 4/26/2005, Ken A wrote: On Fedora Core 3, I get this running make: pop_pass.c: In function `check_password': pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast This does not happen with 4.0.6b3 Anything to be concerned about? Yeah, especially if you look at the source code for line 210, and notice there's no call to strlen there. Not sure quite what gcc is up to with this line of code. Thanks, Ken Pacific.Net - [EMAIL PROTECTED] wrote: Randall Gellens wrote .. The 4.0.6 tarball accidently omitted man pages. I've replaced it with 4.0.7. Sorry about that. -- Tried to install on HP-UX 11.11 where I already are running 4.0.5 Got this: gcc -c -I.. -I.. -I. Ö -I../mmangle -I../common Ö -g -O2 -DHAVE_CONFIG_H -DHPUX -DSPEC_POP_AUTH -DUNIX pop_pass.c -o pop_ pass.o pop_pass.c: In function écheck_password': pop_pass.c:204: warning: passing arg 1 of éstrcmp' makes pointer from integer wi thout a cast In file included from pop_pass.c:771: /usr/include/prot.h: At top level: /usr/include/prot.h:664: error: conflicting types for 'bigcrypt' pop_pass.c:204: error: previous implicit declaration of 'bigcrypt' was here makeÄ1Å: *** Äpop_pass.oÅ Error 1 makeÄ1Å: Leaving directory é/tmp/qpopper4.0.7/popper' make: *** Äpopper_serverÅ Error 2 # Best Regards Lars Ebeling
Re: Fwd: Qpopper 4.0.7 available -- 4.0.6 omitted man pages
On Fedora Core 3, I get this running make: pop_pass.c: In function `check_password': pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `strlen' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast pop_pass.c:210: warning: passing arg 1 of `__builtin_strcmp' makes pointer from integer without a cast This does not happen with 4.0.6b3 Anything to be concerned about? Thanks, Ken Pacific.Net - [EMAIL PROTECTED] wrote: Randall Gellens wrote .. The 4.0.6 tarball accidently omitted man pages. I've replaced it with 4.0.7. Sorry about that. -- Tried to install on HP-UX 11.11 where I already are running 4.0.5 Got this: gcc -c -I.. -I.. -I. Ö -I../mmangle -I../common Ö -g -O2 -DHAVE_CONFIG_H -DHPUX -DSPEC_POP_AUTH -DUNIX pop_pass.c -o pop_ pass.o pop_pass.c: In function écheck_password': pop_pass.c:204: warning: passing arg 1 of éstrcmp' makes pointer from integer wi thout a cast In file included from pop_pass.c:771: /usr/include/prot.h: At top level: /usr/include/prot.h:664: error: conflicting types for 'bigcrypt' pop_pass.c:204: error: previous implicit declaration of 'bigcrypt' was here makeÄ1Å: *** Äpop_pass.oÅ Error 1 makeÄ1Å: Leaving directory é/tmp/qpopper4.0.7/popper' make: *** Äpopper_serverÅ Error 2 # Best Regards Lars Ebeling
