Re: [Qt-creator] Code review process for Qt Creator patches

2017-04-18 Thread Tobias Hunger
On Tue, 2017-04-18 at 04:42 +, Roessler, Alexander wrote: > Hello, > > > I have made some changes to the Autotoolsprojectmanager plugin for Qt Creator > which I would like to push upstream. Thank you for considering to upstream your work! That is appreciated:-) > How can I submit my patch

Re: [Qt-creator] Code review process for Qt Creator patches

2017-04-18 Thread Oswald Buddenhagen
On Tue, Apr 18, 2017 at 09:32:13AM +0200, André Hartmann wrote: > There are several pages describing how to start, best read [2] first > and [...] > > [2] https://wiki.qt.io/Setting_up_Gerrit > the canonical landing page is http://wiki.qt.io/Qt_Contribution_Guidelines

Re: [Qt-creator] Code review process for Qt Creator patches

2017-04-18 Thread André Hartmann
Hi Alexander, All contributions to the Qt Project have to go thought Gerrit [1] due to licensing. There are several pages describing how to start, best read [2] first and follow the links there. After you pushed your patches to Gerrit, you have to add reviewers. This could be a bit

[Qt-creator] Code review process for Qt Creator patches

2017-04-17 Thread Roessler, Alexander
Hello, I have made some changes to the Autotoolsprojectmanager plugin for Qt Creator which I would like to push upstream. How can I submit my patch to the code review process for Qt Creator? Best regards, Alexander ___ Qt-creator mailing list