[quagga-dev 15038] Re: [PATCH] HACKING: update coding style documentation

2016-04-11 Thread Lennart Sorensen
On Mon, Apr 11, 2016 at 10:42:41AM -0400, Donald Sharp wrote: > I agree, the GNU coding style is a bit counter-intuitive. Not sure that I > care a whole lot though. I'll try to stick to the style in the current > file I am working on. > > About the only thing I do care about is the use of

[quagga-dev 15034] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

2016-04-11 Thread Paul Jakma
On Mon, 11 Apr 2016, Donald Sharp wrote: I think there is value to know the number of times an interface has flapped in addition to the last time it happened. The interface flapped over the weekend? Not sure I care that much. The interface last flapped over the weekend and the counter went

[quagga-dev 15033] Re: [PATCH 2/2] zebra: count iface up/down events and keep last time of their occurrence

2016-04-11 Thread Donald Sharp
I think there is value to know the number of times an interface has flapped in addition to the last time it happened. The interface flapped over the weekend? Not sure I care that much. The interface last flapped over the weekend and the counter went up 6000 times? I probably need to check it

[quagga-dev 15032] Re: [PATCH] HACKING: update coding style documentation

2016-04-11 Thread Paul Jakma
On Thu, 31 Mar 2016, David Lamparter wrote: FWIW, I would go further and accept Linux style on a per-file basis in other parts of Quagga. I can't find hard data on it, but it seems to be the most commonly used style in FOSS projects. Feedback appreciated, I'd rather leave it at GNU style