[quagga-dev 15468] CI Testresult: PASSED (Re: [quagga-dev, 15454] pimd: Add ability to safely ignore route-maps)

2016-06-06 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15466] CI Testresult: PASSED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

2016-06-06 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15465] Re: CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

2016-06-06 Thread Martin Winter
On 6 Jun 2016, at 18:45, Donald Sharp wrote: Martin - Looks like something went wrong with your test system? Yes. Added some patches and it seems it didn’t come back up all correct. Ignore it - I’ll rerun in a few minutes and will trigger a new email at the end. - Martin donald On

[quagga-dev 15464] Re: [PATCH] bgpd: fix potential crash in community_list_dup_check

2016-06-06 Thread Donald Sharp
Acked-by: Donald Sharp On Mon, Jun 6, 2016 at 4:22 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke > > extcommunity_list_set may set the ->config for an entry > to NULL. In this case, the old code in

[quagga-dev 15463] CI Testresult: FAILED (Re: [quagga-dev, 15454] pimd: Add ability to safely ignore route-maps)

2016-06-06 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 1965: http://patchwork.quagga.net/patch/1965

[quagga-dev 15462] Re: [PATCH] zebra: make fpm netlink_route_info_fill more robust

2016-06-06 Thread Donald Sharp
Christian - How is this possible? In zfpm_encode_route we set cmd == RTM_DELROUTE if rib == NULL. Is this setup for some new code? donald On Mon, Jun 6, 2016 at 4:04 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke > > Having an

[quagga-dev 15461] CI Testresult: FAILED (Re: [quagga-dev, 15453] pimd: Add support for displaying ip mroute)

2016-06-06 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 1964: http://patchwork.quagga.net/patch/1964

[quagga-dev 15460] Re: CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

2016-06-06 Thread Donald Sharp
Martin - Looks like something went wrong with your test system? donald On Mon, Jun 6, 2016 at 9:40 PM, wrote: > Continous Integration Result: FAILED > > See below for issues. > This is an EXPERIMENTAL automated CI system. > For questions and feedback, feel free to email >

[quagga-dev 15459] CI Testresult: FAILED (Re: [quagga-dev, 15452, 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter)

2016-06-06 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 1961: http://patchwork.quagga.net/patch/1961

[quagga-dev 15458] Re: [PATCH] isisd: exit if daemonizing fails

2016-06-06 Thread Donald Sharp
Acked-by: Donald Sharp On Mon, Jun 6, 2016 at 3:13 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke > > The other daemons in Quagga exit with an error if they cannot fork. > Change isisd to behave consistently. >

[quagga-dev 15455] Re: [PATCH] ospf6d: remove unused broken function

2016-06-06 Thread Donald Sharp
Acked-by: Donald Sharp On Mon, Jun 6, 2016 at 3:49 PM, Christian Franke < ch...@opensourcerouting.org> wrote: > From: Christian Franke > > ospf6_interface_if_del has not been in use since for quite some > years and is broken. (Will crash ospf6d if

[quagga-dev 15454] [PATCH] pimd: Add ability to safely ignore route-maps

2016-06-06 Thread Donald Sharp
pim was not parsing route-map code and causing issues using vtysh because of this. Add code to safely ignore the route-map code and set us up for future expansion into route-maps if neeeded. Signed-off-by: Donald Sharp --- pimd/Makefile.am| 3 ++-

[quagga-dev 15452] [PATCH 3/3] pimd: Remove igmp_add_group_by_addr unneeded parameter

2016-06-06 Thread Donald Sharp
The interface name is already passed in as part of the 'struct igrmp *group' pointer. No need to do it twice. Signed-off-by: Donald Sharp --- pimd/pim_igmp.c | 13 ++--- pimd/pim_igmp.h | 3 +-- pimd/pim_igmpv3.c | 11 +-- 3 files changed, 12

[quagga-dev 15451] [PATCH 2/3] pimd: Remove source_new unneeded parameter

2016-06-06 Thread Donald Sharp
The interface name is already passed in as part of the 'struct igmp_group *group' pointer. No need to do it twice. Signed-off-by: Donald Sharp --- pimd/pim_igmp.h | 3 +++ pimd/pim_igmpv3.c | 40 2 files changed, 19

[quagga-dev 15449] [PATCH] bgpd: Fix route-map and redistribution

2016-06-06 Thread Donald Sharp
Commit f3cfc46 introduced this issue. A route-map lookup was being done for IPv6, using IPv4 information. Signed-off-by: Donald Sharp --- bgpd/bgp_routemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_routemap.c

[quagga-dev 15448] CI Testresult: PASSED (Re: [quagga-dev, 15443] bgpd: fix potential crash in community_list_dup_check)

2016-06-06 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15444] CI Testresult: PASSED (Re: [quagga-dev, 15437] isisd: exit if daemonizing fails)

2016-06-06 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied :

[quagga-dev 15443] [PATCH] bgpd: fix potential crash in community_list_dup_check

2016-06-06 Thread Christian Franke
From: Christian Franke extcommunity_list_set may set the ->config for an entry to NULL. In this case, the old code in community_list_dup_check would cause a NULL pointer dereference. Adjust the code so it behaves the same in the absence of NULL pointers and otherwise checks

[quagga-dev 15441] [PATCH] zebra: make fpm netlink_route_info_fill more robust

2016-06-06 Thread Christian Franke
From: Christian Franke Having an RTM_ADDROUTE with a rib == NULL would lead to a crash due to a NULL pointer dereference. Since an RTM_ADDROUTE without a rib object doesn't make much sense, print a warning and remove the concerned route instead. Signed-off-by: Christian

[quagga-dev 15437] [PATCH] isisd: exit if daemonizing fails

2016-06-06 Thread Christian Franke
From: Christian Franke The other daemons in Quagga exit with an error if they cannot fork. Change isisd to behave consistently. Signed-off-by: Christian Franke --- isisd/isis_main.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[quagga-dev 15438] Re: round 7, can you test?

2016-06-06 Thread Martin Winter
It’s already tested. At least the basic run. https://ci1.netdef.org/chain/viewChain.action?planKey=QUAGGA-QMASTER9 (Part of the “Master” Plan - just select the branch on top to see different branches. My CI system should automatically pick up any proposed/* branches) I’ll start a full pass

[quagga-dev 15434] Re: Quagga Release Process Meeting Notes

2016-06-06 Thread Jafar Al-Gharaibeh
On 6/5/2016 9:30 AM, Michael Richardson wrote: Jafar Al-Gharaibeh wrote: Identical releases: Quagga-CE-1.0-0.0 Quagga-YE-1.0 How would a Quagga-YE-1.0 that has had a security patch applied to it be numbered? I thought about this (and yes, we are overthinking it :) ) ... we

[quagga-dev 15433] Re: Round 8

2016-06-06 Thread Jafar Al-Gharaibeh
Paul, Great to see this long list of patches queued up finally. Good work, your effort is appreciated. Regards, Jafar On 6/6/2016 11:09 AM, Paul Jakma wrote: Hi, As an FYI. I've gone through patchwork and gotten most the bulkd of it queued up. Bar some issues with conflicts and what

[quagga-dev 15431] Re: [PATCH 00/10] VNC: L3 & L2 VPN application support

2016-06-06 Thread Philippe Guibert
Hi Lou, I am looking deeper at EVPN implementation, with patch "VNC; L3 & L2 VPN application support". To get more familiar with this, I tried to mount a setup based on Mesh NVA configuration example that can be found on doc/vnc.texi file, and make a BGP exchange between the two BGP speakers. At

[quagga-dev 15430] round 7, can you test?

2016-06-06 Thread Paul Jakma
Hi, Not sure why it's been sitting there untouched for so long, but could you do some of your smoke-tests on r7? So we can get it into master? As it was apparently a limited bugfix-only round, it perhaps needs only a basic run. regards, -- Paul Jakma | p...@jakma.org | @pjakma | Key ID:

[quagga-dev 15429] Re: Quagga Release Process Meeting Notes

2016-06-06 Thread Lou Berger
On 6/5/2016 10:34 AM, Michael Richardson wrote: > Lou Berger wrote: > >> What do you (anyone) think? > I think we are thinking too much about it. > > Michael, If I'm not mistaken, you were around since quagga was set up as a gnu project. What's your perspective on all