Acked-by: Donald Sharp <sha...@cumulusnetworks.com>
On Tue, Jun 14, 2016 at 2:07 PM, Christian Franke <
ch...@opensourcerouting.org> wrote:
> From: Christian Franke <nob...@nowhere.ws>
>
> bgp_attr_flag_invalid can access beyond the last element of
> attr_flags_values.
> Fix this by initializing attr_flags_values_max to the correct value.
>
> Signed-off-by: Christian Franke <ch...@opensourcerouting.org>
> ---
> bgpd/bgp_attr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
> index f34e649..95c35fb 100644
> --- a/bgpd/bgp_attr.c
> +++ b/bgpd/bgp_attr.c
> @@ -998,8 +998,7 @@ const u_int8_t attr_flags_values [] = {
> [BGP_ATTR_AS4_PATH] = BGP_ATTR_FLAG_OPTIONAL |
> BGP_ATTR_FLAG_TRANS,
> [BGP_ATTR_AS4_AGGREGATOR] = BGP_ATTR_FLAG_OPTIONAL |
> BGP_ATTR_FLAG_TRANS,
> };
> -static const size_t attr_flags_values_max =
> - sizeof (attr_flags_values) / sizeof (attr_flags_values[0]);
> +static const size_t attr_flags_values_max = array_size(attr_flags_values)
> - 1;
>
> static int
> bgp_attr_flag_invalid (struct bgp_attr_parser_args *args)
> --
> 2.8.0
>
>
> _______________________________________________
> Quagga-dev mailing list
> Quagga-dev@lists.quagga.net
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
