[quagga-dev 16129] Re: round-8: tentative proposed head for master

2016-09-29 Thread Paul Jakma
On Thu, 22 Sep 2016, Paul Jakma wrote: Just the session setup with the test tools the final issue. I've been adapting Martin's bgptool test code to test BGP collision handling. Not found the problem so far. Unfortunately, I have other stuff occupying me until early next week now. So, the

[quagga-dev 16128] CI Testresult: FAILED (Re: [quagga-dev, 16115, 2/2] bgpd: multiple label stack support)

2016-09-29 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2059: http://patchwork.quagga.net/patch/2059

[quagga-dev 16130] BGP VRF Route Distinguisher configuration

2016-09-29 Thread Philippe Guibert
Hi Quagga-dev, This series of patches introduces the ability for a BGP router, to configure a route distinguisher and associate import and export route targets. This permits for a BGP update to be sent with BGP extended communities associated to the exported route targets of the RD. This permits

[quagga-dev 16131] [PATCH 2/2] bgpd: vpnv4 af exports extended communities

2016-09-29 Thread Philippe Guibert
If the user preconfigures a vrf with import and export rules, before creating a new network on vpnv4 address, then BGP update emitted will contain the exported rts mentioned by the vrf export rule. Signed-off-by: Philippe Guibert --- bgpd/bgp_route.c | 11 +++

[quagga-dev 16133] CI Testresult: FAILED (Re: [quagga-dev, 16124, v2, 11/11] lib: clean/restore memory debugging functions)

2016-09-29 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2063: http://patchwork.quagga.net/patch/2063

[quagga-dev 16135] [PATCH] Extend BGP_SEND_ASPATH_CHECK to cover confederations

2016-09-29 Thread Thorvald Natvig
Extend the check for BGP_SEND_ASPATH_CHECK to also cover confederations. --- bgpd/bgp_route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c index c364372..30daa02 100644 --- a/bgpd/bgp_route.c +++ b/bgpd/bgp_route.c @@ -901,7 +901,6 @@

[quagga-dev 16134] CI Testresult: FAILED (Re: [quagga-dev, 16131, 2/2] bgpd: vpnv4 af exports extended communities)

2016-09-29 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2073: http://patchwork.quagga.net/patch/2073

[quagga-dev 16136] CI Testresult: FAILED (Re: [quagga-dev, 16135] Extend BGP_SEND_ASPATH_CHECK to cover confederations)

2016-09-29 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2074: http://patchwork.quagga.net/patch/2074

[quagga-dev 16137] Re: round-8: tentative proposed head for master

2016-09-29 Thread Lou Berger
Just walked through the code a bit -- looks like quagga needs to add support for DelayOpen(Timer) when receiving a new tcp connection... Lou On 9/29/2016 9:29 AM, Paul Jakma wrote: > On Thu, 22 Sep 2016, Paul Jakma wrote: > >> Just the session setup with the test tools the final issue. I've

[quagga-dev 16138] Re: CI Testresult: FAILED (Re: [quagga-dev, 16135] Extend BGP_SEND_ASPATH_CHECK to cover confederations)

2016-09-29 Thread Martin Winter
Hmm… my updated CI tests with a setup verification seems to fail including any errors of it. The issue here is that RIPng failed to bring up any neighbors (may have crashed at startup), so no RIPng test were executed. - Martin On 29 Sep 2016, at 12:00, cisys...@netdef.org wrote: Continous

[quagga-dev 16118] [PATCH v2 04/11] lib: remove constructor reference

2016-09-29 Thread Philippe Guibert
because some compilers do not use this feature, it is provided an API that forces the user to call its mem group and memtypes init. Signed-off-by: Philippe Guibert --- lib/memory.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff

[quagga-dev 16119] [PATCH v2 03/11] lib: add new extensible memory-type handling

2016-09-29 Thread Philippe Guibert
From: David Lamparter This rewrites Quagga's memory per-type allocation counting, without using a fixed global list of types. Instead, source files can declare memory types which get handled through constructor functions called by the dynamic linker during

[quagga-dev 16120] [PATCH v2 02/11] lib: move memory.[ch] out of the way

2016-09-29 Thread Philippe Guibert
From: David Lamparter The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- lib/Makefile.am | 8 +- lib/memory.c | 486

[quagga-dev 16124] [PATCH v2 11/11] lib: clean/restore memory debugging functions

2016-09-29 Thread Philippe Guibert
This adapts the dump-at-exit handler and removes the old leftover code. (Note the text in log_memtype_stderr was actually incorrect as the only caller in bgpd cleans up configuration before calling it, i.e. any remaining allocations are missing-cleanup bugs.) Signed-off-by: David Lamparter

[quagga-dev 16122] [PATCH v2 05/11] lib: migrate to new memory-type handling

2016-09-29 Thread Philippe Guibert
From: David Lamparter Move over to the new allocation counting added in the previous commit. (This is mostly mechanical.) Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert ---

[quagga-dev 16125] [PATCH v2 08/11] *: declare and init mgroup and mtype for all lib/daemons

2016-09-29 Thread Philippe Guibert
This commit centralises the memory group and memory types declarations into one single place for each daemon/library. In this case, files affected are /_memory.[ch]. In order to be used, the memory groups and memory types have to be manually initialised. This is why the daemons are initialising

[quagga-dev 16121] [PATCH v2 07/11] *: stop (re|ab)using lib/ MTYPEs

2016-09-29 Thread Philippe Guibert
From: David Lamparter bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the library for its own use. This is bad practice and will break with the later commit making the library's MTYPEs static. Signed-off-by: David Lamparter

[quagga-dev 16127] [PATCH v2 10/11] *: enhance memtype and memgroup generation across lib and daemons

2016-09-29 Thread Philippe Guibert
This commit introduces a bash script called from Makefile from each lib/daemon. Upon call, this script takes as input a txt file describing the various memory group and type that need to be defined, initialised and declared. The output of this script is 2 .c and .h files used for compilation

[quagga-dev 16126] [PATCH v2 06/11] *: split & distribute memtypes

2016-09-29 Thread Philippe Guibert
From: David Lamparter This is a rather large mechanical commit that splits up the memory types defined in lib/memtypes.c and distributes them into *_memory.[ch] files in the individual daemons. The zebra change is slightly annoying because there is no nice place to

[quagga-dev 16139] Re: round-8: tentative proposed head for master

2016-09-29 Thread Lou Berger
looks like the NHT code is generating an event into the state machine that it shouldn't be. I removed this and checked it into my work area. See https://github.com/LabNConsulting/quagga-vnc/commit/7162337f9261b91056b95a673a54ad595aef3e5f Kudos to Martin for logs/pcaps/discussion and the system

[quagga-dev 16115] [PATCH 2/2] bgpd: multiple label stack support

2016-09-29 Thread Philippe Guibert
From: David Lamparter Support for multiple label support handling in NLRI messages. Ability to receive and sent BGP updates with NLRI containing multiple labels. The commit follows label encoding rules, contained in RFC3107. Signed-off-by: David Lamparter

[quagga-dev 16114] BGP multiple label support

2016-09-29 Thread Philippe Guibert
Hi Quagga-dev, This work is enhancing RFC3107 encoding format for label in BGP NLRI messages. This applies for instance to VPNv4 address family. It is to be noted that this commit does not bring any API enhancement regarding VTY configuration. However, the mecanic is ready to receive BGP updates

[quagga-dev 16113] [PATCH 1/2] lib: 3byte stream foo

2016-09-29 Thread Philippe Guibert
From: David Lamparter API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- lib/stream.c | 77