[quagga-dev 16234] [PATCH v3 01/11] *: memory type NEXTHOP renamed to LIB_NEXTHOP to ease identification

2016-10-11 Thread Philippe Guibert
This memory type allocator is used in both bgpd and library part. to ease identification of the memory type, the allocator is put in lib folder, instead of zebra folder. Signed-off-by: Philippe Guibert --- bgpd/bgp_nexthop.c | 2 +- lib/memtypes.c | 2 +- lib/nexthop.c | 4 ++-- 3 files

[quagga-dev 16237] [PATCH v3 07/11] *: stop (re|ab)using lib/ MTYPEs

2016-10-11 Thread Philippe Guibert
From: David Lamparter bgpd, ospf6d, isisd and some tests were reusing MTYPEs defined in the library for its own use. This is bad practice and will break with the later commit making the library's MTYPEs static. Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- isisd/isis_mem

[quagga-dev 16235] [PATCH v3 04/11] lib: remove constructor reference

2016-10-11 Thread Philippe Guibert
because some compilers do not use this feature, it is provided an API that forces the user to call its mem group and memtypes init. Signed-off-by: Philippe Guibert --- lib/memory.h | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git a/lib/memory.h b/lib/me

[quagga-dev 16233] [PATCH v3 0/11] scrap & rewrite memtypes handling

2016-10-11 Thread Philippe Guibert
Hi quagga-dev, This is a rework from [quagga-dev 14733], made by David Lamparter. Among the changes done with previous version, the "contructor" usage has been removed. This then should make possible to continue using quagga on all platforms not supporting this compiler enhancement. This patchset

[quagga-dev 16236] [PATCH v3 02/11] lib: move memory.[ch] out of the way

2016-10-11 Thread Philippe Guibert
From: David Lamparter The following commit will recreate memory.[ch]. Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- lib/Makefile.am | 6 +- lib/memory.c | 484 --- lib/memory.h | 98 +-- lib/memory_vt

[quagga-dev 16238] [PATCH v3 09/11] *: static mgroup and mtypes are locally declared and initialised

2016-10-11 Thread Philippe Guibert
On some specific cases, the user may wish not to export its memory type and group. The user can then declare and initialises this memory type, provided that he ensures also the initialisation. The goal of that commit is initialising in quagga the static mtypes. Signed-off-by: Philippe Guibert ---

[quagga-dev 16241] [PATCH v3 06/11] *: split & distribute memtypes

2016-10-11 Thread Philippe Guibert
From: David Lamparter This is a rather large mechanical commit that splits up the memory types defined in lib/memtypes.c and distributes them into *_memory.[ch] files in the individual daemons. The zebra change is slightly annoying because there is no nice place to put the #include "zebra_memory.

[quagga-dev 16240] [PATCH v3 11/11] lib: clean/restore memory debugging functions

2016-10-11 Thread Philippe Guibert
This adapts the dump-at-exit handler and removes the old leftover code. (Note the text in log_memtype_stderr was actually incorrect as the only caller in bgpd cleans up configuration before calling it, i.e. any remaining allocations are missing-cleanup bugs.) Signed-off-by: David Lamparter Signe

[quagga-dev 16239] [PATCH v3 05/11] lib: migrate to new memory-type handling

2016-10-11 Thread Philippe Guibert
From: David Lamparter Move over to the new allocation counting added in the previous commit. (This is mostly mechanical.) Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- bgpd/bgp_main.c | 1 + bgpd/bgp_vty.c | 1 + isisd/isis_main.c |

[quagga-dev 16234] [PATCH v3 03/11] lib: add new extensible memory-type handling

2016-10-11 Thread Philippe Guibert
From: David Lamparter This rewrites Quagga's memory per-type allocation counting, without using a fixed global list of types. Instead, source files can declare memory types which get handled through constructor functions called by the dynamic linker during startup. Signed-off-by: David Lamparte

[quagga-dev 16242] [PATCH v3 08/11] *: declare and init mgroup and mtype for all lib/daemons

2016-10-11 Thread Philippe Guibert
This commit centralises the memory group and memory types declarations into one single place for each daemon/library. In this case, files affected are /_memory.[ch]. In order to be used, the memory groups and memory types have to be manually initialised. This is why the daemons are initialising the

[quagga-dev 16243] [PATCH v3 10/11] *: enhance memtype and memgroup generation across lib and daemons

2016-10-11 Thread Philippe Guibert
This commit introduces a bash script called from Makefile from each lib/daemon. Upon call, this script takes as input a txt file describing the various memory group and type that need to be defined, initialised and declared. The output of this script is 2 .c and .h files used for compilation within

[quagga-dev 16245] [PATCH V4 0/3] BGP multiple label support

2016-10-11 Thread Philippe Guibert
This work is enhancing RFC3107 encoding format for label in BGP NLRI messages. This applies for instance to VPNv4 address family. It is to be noted that this commit does not bring any API enhancement regarding VTY configuration. However, the mecanic is ready to receive BGP updates with multiple l

[quagga-dev 16244] [PATCH v4 1/3] lib: 3byte stream foo

2016-10-11 Thread Philippe Guibert
From: David Lamparter API enhancement to be able to write and read 3 byte series in stream structures. Signed-off-by: David Lamparter Signed-off-by: Philippe Guibert --- lib/stream.c | 77 lib/stream.h | 4 2 files changed, 81

[quagga-dev 16246] [PATCH v4 3/3] tests: enhance bgpd testing with label value

2016-10-11 Thread Philippe Guibert
bgp NLRI has a specific format for label, terminating with bottom of stack bit. This value is updated in all BGP attribute tests. A specific test has been added to check for a list of labels contained in a single NLRI. Signed-off-by: Philippe Guibert --- tests/bgp_mp_attr_test.c | 87 +

[quagga-dev 16247] [PATCH v4 2/3] bgpd: multiple label stack support

2016-10-11 Thread Philippe Guibert
From: David Lamparter Support for multiple label support handling in NLRI messages. Ability to receive and sent BGP updates with NLRI containing multiple labels. The commit follows label encoding rules, contained in RFC3107. Signed-off-by: David Lamparter Signed-off-by: Christian Franke Signed

[quagga-dev 16249] [PATCH v2 1/2] bgpd: VRF vty configuration, RIB table creation

2016-10-11 Thread Philippe Guibert
This commit introduces the BGP VRF configuration, and BGP VRF RIB table. It includes the ability for a BGP to configure its own route distinguisher ( aka VRF). New vty commands introduced: (config-router)# vrf rd This structure permits configuring import and export route targets, which is define

[quagga-dev 16250] [PATCH v2 2/2] bgpd: vpnv4 af exports extended communities

2016-10-11 Thread Philippe Guibert
If the user preconfigures a vrf with import and export rules, before creating a new network on vpnv4 address, then BGP update emitted will contain the exported rts mentioned by the vrf export rule. Signed-off-by: Philippe Guibert --- bgpd/bgp_route.c | 11 +++ bgpd/bgp_route.h | 2 ++ 2

[quagga-dev 16248] [PATCH v2 0/2] BGP VRF Route Distinguisher configuration

2016-10-11 Thread Philippe Guibert
This series of patches introduces the ability for a BGP router, to configure a route distinguisher and associate import and export route targets. This permits for a BGP update to be sent with BGP extended communities associated to the exported route targets of the RD. This permits for a BGP update

[quagga-dev 16251] CI Testresult: PASSED (Re: [quagga-dev, 16232] bgpd: rename new -S (--skip_runas) to -U (--no_user) command line option)

2016-10-11 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2089: http://patchwork.quagga.net/patch/

[quagga-dev 16252] Re: [PATCH] bgp: restore missing check from original ignore NHT change

2016-10-11 Thread Paul Jakma
I don't understand the subject. This isn't restoring anything, but adding a missing check from the patch to make NHT work without zebra? Or did I somehow drop that chunk from the original patch? Also, what about the tests on NEXTHOP_VALID in evaluate_paths? Do they need to take bgp_zebra_num_c

[quagga-dev 16253] CI Testresult: FAILED (Re: [quagga-dev, 16240, v3, 11/11] lib: clean/restore memory debugging functions)

2016-10-11 Thread cisystem
Continous Integration Result: FAILED See below for issues. This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2093: http://patchwork.quagga.net/patch/2093 [quagga-dev,16234,v3,01/11] *: memory type NEXTH

[quagga-dev 16254] Re: [PATCH] bgp: restore missing check from original ignore NHT change

2016-10-11 Thread Lou Berger
On 10/11/2016 7:04 AM, Paul Jakma wrote: > I don't understand the subject. This isn't restoring anything, but > adding a missing check from the patch to make NHT work without zebra? Or > did I somehow drop that chunk from the original patch? Yes, I patched a different spot - that is the one tha

[quagga-dev 16255] CI Testresult: PASSED (Re: [quagga-dev, 16246, v4, 3/3] tests: enhance bgpd testing with label value)

2016-10-11 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2103: http://patchwork.quagga.net/patch/

[quagga-dev 16256] CI Testresult: PASSED (Re: [quagga-dev, 16250, v2, 2/2] bgpd: vpnv4 af exports extended communities)

2016-10-11 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2108: http://patchwork.quagga.net/patch/

[quagga-dev 16257] [PATCHv2] bgp: add bgp_isvalid_nexthop helper and additional NHT zebra checks (also restores check from original patch)

2016-10-11 Thread Lou Berger
--- bgpd/bgp_nht.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/bgpd/bgp_nht.c b/bgpd/bgp_nht.c index b5d830e..171cb20 100644 --- a/bgpd/bgp_nht.c +++ b/bgpd/bgp_nht.c @@ -52,6 +52,13 @@ static int make_prefix(int afi, struct bgp_info *ri, struct prefix *p

[quagga-dev 16258] CI Testresult: PASSED (Re: [quagga-dev, 16257, PATCHv2] bgp: add bgp_isvalid_nexthop helper and additional NHT zebra checks (also restores check from original patch))

2016-10-11 Thread cisystem
Continous Integration Result: SUCCESSFUL Congratulations, this patch passed basic tests Tested-by: NetDEF CI System This is an EXPERIMENTAL automated CI system. For questions and feedback, feel free to email Martin Winter . Patches applied : Patchwork 2109: http://patchwork.quagga.net/patch/

[quagga-dev 16259] Re: Proposed 8 testing Update

2016-10-11 Thread Andrew Lunn
> - Systematic way to collect patches could be: > > * Patchwork (it has issues over longer time spans, but prob ok on > short ones) > > * Bugzilla > > * automated list crawler and applier (I'd prefer not to put closed > tools in the middle of this though) > > Nothing is perfect