Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-05 Thread Viacheslav Chimishuk
> Hey, > > (re-adding the list to the Cc, I assume you accidentally didn't include > it in your reply) Hi, Florian. Yes. Sorry, my fault. Thanks for adding it back. > That's true, and a valid concern. Currently we just can test for > membership of a host in a set, which is O(1). Host blocking lo

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-05 Thread Florian Bruhin
Hey, (re-adding the list to the Cc, I assume you accidentally didn't include it in your reply) On Sun, Nov 04, 2018 at 09:19:23PM +0200, Viacheslav Chimishuk wrote: > > On Sun, Nov 04, 2018 at 07:16:45PM +0200, Viacheslav Chimishuk wrote: > > > > > I propose to treat `~` prefix as a substring ins

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-04 Thread Florian Bruhin
On Sun, Nov 04, 2018 at 07:16:45PM +0200, Viacheslav Chimishuk wrote: > > > I propose to treat `~` prefix as a substring instead of domain > > > name. For example, next file parses to substrings list. > > > > Again, use URL patterns. I will not accept any contributions inventing > > yet another URL

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-04 Thread Viacheslav Chimishuk
> > I propose to treat `~` prefix as a substring instead of domain > > name. For example, next file parses to substrings list. > > Again, use URL patterns. I will not accept any contributions inventing > yet another URL format, no matter how simple. Let's be consistent with > what the rest of quteb

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-03 Thread Jay Kamat
Viacheslav Chimishuk writes: >> How would the line to block Youtube ads look like? >> >> FWIW I'm against introducing another URL pattern format, and I'd rather >> use the existing URL pattern class which is also used for ":set -u" >> (aka "per-domain settings"). See: >> https://github.com/quteb

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-02 Thread Florian Bruhin
On Fri, Nov 02, 2018 at 08:28:30PM +0200, Viacheslav Chimishuk wrote: > > How would the line to block Youtube ads look like? > > > > FWIW I'm against introducing another URL pattern format, and I'd rather > > use the existing URL pattern class which is also used for ":set -u" > > (aka "per-domain s

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-02 Thread Viacheslav Chimishuk
I can see ublock uses regexp for its list. Implementing regexp support we can reuse their files, which will get us a huge benefit. Unfortunately their format is not compatible with UrlPattern we use and looks much more complicated than a simple regexp. IMHO, it is better to start with simple substr

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-02 Thread Viacheslav Chimishuk
> Sounds great. The Compiler is currently working on a plugin system, > which I believe would make this even easier to implement. If I recall > correctly, even the current hostblocking would be extracted to a plugin > so we could just extend that to include the functionality you > described. Yeah,

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-02 Thread Viacheslav Chimishuk
> How would the line to block Youtube ads look like? > > FWIW I'm against introducing another URL pattern format, and I'd rather > use the existing URL pattern class which is also used for ":set -u" > (aka "per-domain settings"). See: > https://github.com/qutebrowser/qutebrowser/issues/4188 I was

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-02 Thread Florian Bruhin
Hey! On Thu, Nov 01, 2018 at 11:03:43PM +0200, Viacheslav Chimishuk wrote: > I'm thinking about extending existing ad blocking module to allow > single URL blocking. For now we support two file formats: > host-per-line and UNIX hosts file format. My idea is the add third > format support: URL subs

Re: [qutebrowser] Extend ad blocking to allow single URL blocking.

2018-11-01 Thread Felix Van der Jeugt
Hi, Sounds great. The Compiler is currently working on a plugin system, which I believe would make this even easier to implement. If I recall correctly, even the current hostblocking would be extracted to a plugin so we could just extend that to include the functionality you described. Sincerely,