Re: [Rd] [RFC] readtable enhancement

2019-03-27 Thread Gabriel Becker
Kurt, Cool idea and great "seeing new faces" on here proposing things on here and engaging with R-core on here. Some comments on the issue of fallbacks below. On Wed, Mar 27, 2019 at 10:33 PM Kurt Van Dijck < dev.k...@vandijck-laurijssen.be> wrote: > Hey, > > In the meantime, I submitted a

Re: [Rd] [RFC] readtable enhancement

2019-03-27 Thread Kurt Van Dijck
Hey, In the meantime, I submitted a bug. Thanks for the assistence on that. >and I'm not convinced that >coercion failures should fallback gracefully to the default. the gracefull fallback: - makes the code more complex + keeps colConvert implementations limited + requires the user to

Re: [Rd] default for 'signif.stars'

2019-03-27 Thread Abs Spurdle
I read through the editorial. This is the one of the most mega-ultra-super-biased articles I've ever read. e.g. The authors encourage Baysian methods, and literally encourage subjective approaches. However, there's only one reference to robust methods and one reference to nonparametric methods,

Re: [Bioc-devel] Bioc_check on devel - Checking R Version dependency warning

2019-03-27 Thread Ahmed Mohamed
Thanks Lori for the clarification. If the purpose of the check is to capture the R version upon submission to Bioconductor, then it makes sense. I would suggest a bit of clarification in the docs though. Also, a warning is not produced when "Depends: R (xxx)" is completely missing in DESCRIPTION.

Re: [Rd] SUGGESTION: Proposal to mitigate problem with stray processes left behind by parallel::makeCluster()

2019-03-27 Thread Henrik Bengtsson
Thank you Tomas. For the record, I'm confirming that the stray background R worker process now times out properly after 'setup_timeout' (= 120) seconds: {0s}$ Rscript -e 'parallel::makeCluster(1L, port=80)' Error in socketConnection("localhost", port = port, server = TRUE, blocking = TRUE, :

Re: [Rd] issue with latest release of R-devel

2019-03-27 Thread Henrik Bengtsson
Could this be related to "SIGNIFICANT USER-VISIBLE CHANGES The default method for generating from a discrete uniform distribution (used in sample(), for instance) has been changed. This addresses the fact, pointed out by Ottoboni and Stark, that the previous method made sample() noticeably

[Rd] issue with latest release of R-devel

2019-03-27 Thread Therneau, Terry M., Ph.D. via R-devel
I'm getting ready to submit an update of survival, and is my habit I run the checks on all packages that depend/import/suggest  survival.  I am getting some very odd behaviour wrt non-reproducability.  It came to a head when some things failed on one machine and worked on another.   I found

Re: [Rd] Discrepancy between is.list() and is(x, "list")

2019-03-27 Thread Abs Spurdle
> the prison made by ancient design choices That prison of ancient design choices isn't so bad. I have no further comments on object oriented semantics. However, I'm planning to follow the following design pattern. If I set the class of an object, I will append the new class to the existing

Re: [Rd] [RFC] readtable enhancement

2019-03-27 Thread Ben Bolker
Just to clarify/amplify: on the bug tracking system there's a drop-down menu to specify severity, and "enhancement" is one of the choices, so you don't have to worry that you're misrepresenting your patch as fixing a bug. The fact that an R-core member (Michael Lawrence) thinks this is worth

Re: [Rd] [RFC] readtable enhancement

2019-03-27 Thread Michael Lawrence via R-devel
This has some nice properties: 1) It self-documents the input expectations in a similar manner to colClasses. 2) The implementation could eventually "push down" the coercion, e.g., calling it on each chunk of an iterative read operation. The implementation needs work though, and I'm not

Re: [Rd] [RFC] readtable enhancement

2019-03-27 Thread Kurt Van Dijck
Thank you for your answers. I rather do not file a new bug, since what I coded isn't really a bug. The problem I (my colleagues) have today is very stupid: We read .csv files with a lot of columns, of which most contain date-time stamps, coded in DD/MM/ HH:MM. This is not exotic, but the base

Re: [Rd] SUGGESTION: Proposal to mitigate problem with stray processes left behind by parallel::makeCluster()

2019-03-27 Thread Tomas Kalibera
The problem causing the stray worker processes when the master fails to open a server socket to listen to connections from workers is not related to timeout in socketConnection(), because socketConnection() will fail right away. It is caused by a bug in checking the setup timeout (PR

Re: [Bioc-devel] package RBGL requires CRAN dependency on devel branch

2019-03-27 Thread Vincent Carey
On Wed, Mar 27, 2019 at 9:05 AM Kasper Daniel Hansen < kasperdanielhan...@gmail.com> wrote: > On Wed, Mar 27, 2019 at 1:06 AM Aaron Lun < > infinite.monkeys.with.keyboa...@gmail.com> wrote: > > > > well, we can't fix this in old branches of Bioc. > > > > Sure, but one could say that about

Re: [Bioc-devel] package RBGL requires CRAN dependency on devel branch

2019-03-27 Thread Kasper Daniel Hansen
On Wed, Mar 27, 2019 at 1:06 AM Aaron Lun < infinite.monkeys.with.keyboa...@gmail.com> wrote: > > well, we can't fix this in old branches of Bioc. > > Sure, but one could say that about breaking changes to any CRAN package. > Nothing particularly special about BH on that point. > Indeed, and

Re: [R-pkg-devel] Re :Re: Re :Re: package cartograflow_0.0.0.9000.tar.gz

2019-03-27 Thread Uwe Ligges
On 27.03.2019 12:56, cartograf...@gmail.com wrote: Hi, thanks to your propositions and I will take into account. I make dev_tools::check directly in rstudio. I would like to know if I can do R CMD directly in R interface with the command :  #bash R-devel CMD check --as-cran

Re: [R-pkg-devel] Re :Re: Re :Re: package cartograflow_0.0.0.9000.tar.gz

2019-03-27 Thread Maëlle SALMON via R-package-devel
--- Begin Message --- Hi, To be able to run R CMD check on R devel, on top of your local checks, you might want to have a a look at the R-hub package builder that allows you to run R CMD check on several platforms (R versions, OS) for free. You can use the rhub package for that,

[R-pkg-devel] Re :Re: Re :Re: package cartograflow_0.0.0.9000.tar.gz

2019-03-27 Thread cartograf...@gmail.com
Hi, thanks to your propositions and I will take into account.I make dev_tools::check directly in rstudio. I would like to know if I can do R CMD directly in R interface with the command : #bash R-devel CMD check --as-cran cartograflow.tar.gzIt will be better  Thanks Sylvain  Envoyé depuis Yahoo 

Re: [Rd] Discrepancy between is.list() and is(x, "list")

2019-03-27 Thread Hadley Wickham
I would recommend reading https://adv-r.hadley.nz/base-types.html and https://adv-r.hadley.nz/s3.html. Understanding the distinction between base types and S3 classes is very important to make this sort of question precise, and in my experience, you'll find R easier to understand if you carefully

Re: [Bioc-devel] Bioc_check on devel - Checking R Version dependency warning

2019-03-27 Thread Shepherd, Lori
Bioconductor has release cycles to ensure that packages are building cleaning and working with dependency at any given time. The version would not have to be updated each release, it is an indication of the version of R used at the time of submission and to give a base line of what versions

Re: [Rd] [PATCH 1/2] readtable: add hook for type conversions per column

2019-03-27 Thread Martin Maechler
> Kurt Van Dijck > on Tue, 26 Mar 2019 21:20:07 +0100 writes: > On di, 26 mrt 2019 12:48:12 -0700, Michael Lawrence wrote: >> Please file a bug on bugzilla so we can discuss this >> further. > All fine. I didn't find a way to create an account on >