[R-pkg-devel] How to get rid of R CMD check warning/note for new S4 classes

2021-01-02 Thread Sebastien Bihorel
Hi I am creating a few S4 classes for a package. These classes include slots set to classes obtained using setClassUnion (some common across the new S4 classes). The code is functional but `R CMD check` keeps on reporting notes or warnings whatever I try. I am pulling my hair on this one and

Re: [Rd] `merge()` not consistent in how it treats list columns

2021-01-02 Thread Gabriel Becker
Hi Antoine, On Sat, Jan 2, 2021 at 11:16 AM Antoine Fabri wrote: > Dear R-devel, > > When trying to merge 2 data frames by an "id" column, with this column a > character in one of them, and a list of character in the other, merge > behaves differently depending which is given first. > >

Re: [Rd] `merge()` not consistent in how it treats list columns

2021-01-02 Thread Avi Gross via R-devel
Antoine, Have you considered converting the non-list to a list explicitly so this does not matter? For a long time, few people used lists in this context, albeit in the tidyverse it is now better supported and probably more common. This is an area many have found annoying when you have implicit

[Rd] `merge()` not consistent in how it treats list columns

2021-01-02 Thread Antoine Fabri
Dear R-devel, When trying to merge 2 data frames by an "id" column, with this column a character in one of them, and a list of character in the other, merge behaves differently depending which is given first. Example : ``` df1 <- data.frame(a=1) df2 <- data.frame(b=2) df1$id <- "ID" df2$id <-

Re: [Bioc-devel] Recent change in MultiAssayExperiment for inferred MAE-level colData

2021-01-02 Thread Levi Waldron
Hi Dario and Andrea, I don't think you'll have to do anything - it was meant to be a feature that shouldn't have affected your use cases of not specifying the sampleMap. I've opened an issue at https://github.com/waldronlab/MultiAssayExperiment/issues/291. -- Levi Waldron Associate Professor