[Rd] 答复: patch about timezone name of China Standard Time on windows

2023-01-06 Thread gong yu
understand your concerns. for registerTZ.c itself , IMHO , the most important part is the definition of tztable[] . which come form http://unicode.org/cldr/data/diff/supplemental/windows_tzid.html ,but it can��t access now, the lasted version is

Re: [Rd] patch about timezone name of China Standard Time on windows

2023-01-06 Thread Simon Urbanek
Just a quick comment here - this is not as easy as it sounds, because the code is in the "extra" directory which means it is based on upstream sources, so those sources are typically not patched manually as it would be hard to apply upstream updates. In this case the standards have changed

Re: [R-pkg-devel] S3 generic/method consistency false positive when dplyr imported

2023-01-06 Thread Aaron A. King
Excellent suggestion, Ivan. Thanks for pointing out just where to look. I stepped through tools::checkS3methods("pomp") and it does appear to be roughly as I conjectured. Namely, all functions are extracted from the pomp namespace and checked against a list of generics. The check that is

Re: [Rd] Not documenting a function and not getting a check error?

2023-01-06 Thread Duncan Murdoch
On 06/01/2023 5:25 a.m., Kevin Coombes wrote: I am fairly certain that the check for documentation is really just a check for the presence of the function name in an "alias" line. Yes, that's what the test does, and that's fine. The problem is with the usage test in tools::codoc(). If I

Re: [Rd] Not documenting a function and not getting a check error?

2023-01-06 Thread Kevin Coombes
I am fairly certain that the check for documentation is really just a check for the presence of the function name in an "alias" line. My circumstantial evidence, from a package in the early stages of development, came from changing the name of a function. I updated everything else (usage,

Re: [Rd] Not documenting a function and not getting a check error?

2023-01-06 Thread Duncan Murdoch
On 05/01/2023 10:10 p.m., Deepayan Sarkar wrote: On Fri, Jan 6, 2023 at 1:49 AM Duncan Murdoch wrote: I'm in the process of a fairly large overhaul of the exports from the rgl package, with an aim of simplifying maintenance of the package. During this work, I came across the reverse

[Rd] 回复: patch about timezone name of China Standard Time on windows

2023-01-06 Thread gong yu
Thanks Ivan! I really missed the information on https://www.r-project.org/bugs.html . Instead , browse https://bugs.r-project.org and didn't found where to registration and login, then send email to this list. will send a email to

Re: [R-pkg-devel] S3 generic/method consistency false positive when dplyr imported

2023-01-06 Thread Ivan Krylov
(Sorry for the unfinished message. I've got to do something about my mailer to make it harder to send them accidentally.) On Fri, 6 Jan 2023 11:21:49 +0300 Ivan Krylov wrote: > to see where 'filter' appears in the list of generics and where the filter.traj function gets matched to it as a

Re: [R-pkg-devel] S3 generic/method consistency false positive when dplyr imported

2023-01-06 Thread Ivan Krylov
On Thu, 5 Jan 2023 17:58:47 -0500 "Aaron A. King" wrote: > However, since the S3 dispatch system is not itself confused, I > suppose it must be the case that the S3 generic/method consistency > checker itself is confused. I wonder, how does the checker decide > when to throw a NOTE? Is it a