[Rd] src/main/par.c (PR#14214)

2010-02-15 Thread A . R . Runnalls
At lines 1154-5 in par.c (at the latest svn revision 47460), in function do_par(): if (new_spec && GRecording(call, dd)) GErecordGraphicOperation(op, originalArgs, dd); if the call GErecordGraphicOperation gives rise to a garbage collection (as it may), the return value of do_par will

[Rd] src/library/grid/src/grid.c (PR#14199)

2010-01-28 Thread A . R . Runnalls
At around line 2590, in function gridRect() in src/library/grid/src/grid.c (at the latest svn revision, 50745), ought not temp, www and hhh to be PROTECTed within this block? Andrew __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/list

[Rd] src/main/platform.c (PR#14198)

2010-01-28 Thread A . R . Runnalls
At line 312 in src/main/platform.c (at the latest svn revision, 51039): if (length(tl) >= 1 || !isNull(STRING_ELT(tl, 0))) should not '||' read '&&'? Likewise four lines later. Andrew __ R-devel@r-project.org mailing list https://stat.ethz.ch/mai

[Rd] Mac OS X 2.5.1 / reg-plot.R / tr (PR#10781)

2008-02-17 Thread A . R . Runnalls
In building R 2.6.2 from source for Mac OS X 2.5.1 (with i686-apple-darwin9-gcc-4.0.1), 'make check' fails. The failure is in reg-plot.R, and occurs because Mac OS X's 'tr' command (invoked by Rdiff to strip carriage returns) regards the dagger sign in reg-plot.ps as an illegal byte sequence. I'm

[Rd] strsignif.c, util.c (PR#10635)

2008-01-25 Thread A . R . Runnalls
In R 2.6.1, a couple of places (discovered using valgrind) where the requested size of string buffers fails to account correctly for the trailing null byte: 1. In src/appl/strsignif.c, 'f0' and 'form' at l. 108-9 each need at least 1 extra byte. 2. In src/main/util.c, 'out' at l. 1081 needs at le

[Rd] do_gsub (PR#10540)

2008-01-02 Thread A . R . Runnalls
In character.c within R 2.6.1, the function do_gsub contains the following code: 1199if (STRING_ELT(pat, 0) == NA_STRING) { 1200PROTECT(ans = allocVector(STRSXP, n)); 1201for(i = 0; i < n; i++) SET_STRING_ELT(ans, i, NA_STRING); 1202UNPROTECT(1); 1203