Re: [R-pkg-devel] Trouble with long-running tests on CRAN debian server

2023-08-23 Thread Scott Ritchie
software design point of view, it might be nicer to set that in > the examples + tests. > > > > Regards, > > Berry > > > > > > From: R-package-devel on behalf > of Scott Ritchie > > Sent: Monday, August 21, 2023 19:23 > > To: Dirk

Re: [R-pkg-devel] Trouble with long-running tests on CRAN debian server

2023-08-21 Thread Scott Ritchie
Thanks Dirk and Ivan, I took a slightly different work-around of forcing the number of threads to 1 when running functions of the test dataset in the package, by adding the following to each user facing function: ``` # Check if running on package test_data, and if so, force data.table to be

Re: [R-pkg-devel] Trouble with long-running tests on CRAN debian server

2023-08-21 Thread Scott Ritchie
at 13:16, Ivan Krylov wrote: > On Mon, 21 Aug 2023 12:02:55 +0100 > Scott Ritchie wrote: > > > remotes::install_github("sritchie73/ukbnmr") > > library(ukbnmr) > > system.time({ remove_technical_variation(test_data) }) > > data.tables, you say? Can you

[R-pkg-devel] Trouble with long-running tests on CRAN debian server

2023-08-21 Thread Scott Ritchie
}) ``` Kind Regards, Scott Ritchie [[alternative HTML version deleted]] __ R-package-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-package-devel

[Rd] Rinternals.h could expose macros for ISNA and ISNAN for CPLXSXP

2020-01-29 Thread Scott Ritchie
(x.i)) #define ISNAN_COMPLEX(x) (ISNAN(x.r) || ISNAN(x.i)) ``` Best, Scott Ritchie [[alternative HTML version deleted]] __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-22 Thread Scott Ritchie
erence > is > > by numerical index then changing the column name shouldn't break it. > > > I don't know if you need to update the documentation as part of your > > patch, or if whoever applies it would be happy to do that. Somebody > > from R core want to weigh i

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-20 Thread Scott Ritchie
looks to me like the recent patch is identical to > the previous one, can you confirm this? > > Frederick > > On Mon, Feb 19, 2018 at 07:19:32AM +1100, Scott Ritchie wrote: > > Thanks Gabriel, > > > > I think your suggested approach is 100% backwards compatible > > > &g

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-18 Thread Scott Ritchie
t;> > >> > There are lots of cases where "I would have done that differently", but >> > most of them are far too much trouble to change now that R is more than >> 20 >> > years old. And in many cases it will turn out that the way R does it >> >

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-17 Thread Scott Ritchie
to change now that R is more than 20 > years old. And in many cases it will turn out that the way R does it > actually does make more sense than the way I would have done it. > > Duncan Murdoch > > > >> Cheers, >> >> Frederick >> >> On Sat, F

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-17 Thread Scott Ritchie
The attached patch.diff will make merge.data.frame() append the suffixes to columns with common names between by.x and names(y). Best, Scott Ritchie On 17 February 2018 at 11:15, Scott Ritchie <s.ritchi...@gmail.com> wrote: > Hi Frederick, > > I would expect that any

Re: [Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-16 Thread Scott Ritchie
gt; appended to try to make the names of the result unique. > > Since the first "name" column was used in merging, leaving both > without a suffix seems consistent with the documentation... > > Frederick > > On Fri, Feb 16, 2018 at 09:08:29AM +1100, Scott Ritchie wrote:

[Rd] Duplicate column names created by base::merge() when by.x has the same name as a column in y

2018-02-15 Thread Scott Ritchie
sex.y age.y 1 Max M43 Sebastian M 8 2 Qin F36 Kai-lee F 7 3 Sarah F41Oliver M 5 Warning message: In merge.data.frame(parents, children, by.x = "name", by.y = "parent") : column name ‘name’ is duplicated in the result ``` Kind Regards, Scott Ritchie [[alternative HTML version deleted]] __ R-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/r-devel