Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-18 Thread peter dalgaard
I think that, also in R core, it is well recognized that it is unfortunate design that some formula manipulation tools rely on going via textual representation of the entire formula. I'd be strongly tempted to replace the current reformulate() with something like this > x <- c("a

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-18 Thread Saren Tasciyan
So here is it as txt file. It is funny that a R file is restricted in R-devel mailing list. Anyhow, in this case R-core have a few choices here: * ignore my solution * show that it is actually bad or worse * consider adding it Considering, that it is a minor change from previous version

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-18 Thread Martin Maechler
> Ben Bolker > on Thu, 18 Apr 2019 11:51:33 -0400 writes: > Your file didn't make it through the mailing list (which is quite > restrictive about which types/extensions it will take). > I appreciate your enthusiasm and persistence for this issue, but I > suspect you

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-18 Thread Ben Bolker
Your file didn't make it through the mailing list (which is quite restrictive about which types/extensions it will take). I appreciate your enthusiasm and persistence for this issue, but I suspect you may have trouble convincing R-core to adopt your changes -- they are "better", "easier",

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-18 Thread Saren Tasciyan
Hi, Sorry for writing this late, I was very busy. I started this discussion here. I wish I could write to bugs.r-project.org, but I don't have an account and I will write here instead. Meanwhile, I solved my problem with a simpler fix (please see attached file)/. / This requires that term

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-05 Thread Martin Maechler
> Ben Bolker > on Thu, 4 Apr 2019 12:46:37 -0400 writes: > Proposed patch Thank you Ben! [the rest is technical nit-picking .. but hopefully interesting to the smart R-devel reader base:] There was a very subtle thinko in your patch which is not easily diagnosed from R's

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-04 Thread Ben Bolker
Proposed patch (I think .txt files work OK as attachments to the list?) On 2019-04-04 2:21 a.m., Martin Maechler wrote: >> Ben Bolker >> on Fri, 29 Mar 2019 12:34:50 -0400 writes: > > > I suspect that the issue is addressed (obliquely) in the examples, > > which shows

Re: [Rd] Bug in the "reformulate" function in stats package

2019-04-04 Thread Martin Maechler
> Ben Bolker > on Fri, 29 Mar 2019 12:34:50 -0400 writes: > I suspect that the issue is addressed (obliquely) in the examples, > which shows that variables with spaces in them (or otherwise > 'non-syntactic', i.e. not satisfying the constraints of legal R symbols) >

Re: [Rd] Bug in the "reformulate" function in stats package

2019-03-29 Thread Ben Bolker
I suspect that the issue is addressed (obliquely) in the examples, which shows that variables with spaces in them (or otherwise 'non-syntactic', i.e. not satisfying the constraints of legal R symbols) can be handled by protecting them with backticks (``) ## using non-syntactic names:

Re: [Rd] Bug in the "reformulate" function in stats package

2019-03-29 Thread J C Nash
The main thing is to post the "small reproducible example". My (rather long term experience) can be written if (exists("reproducible example") ) { DeveloperFixHappens() } else { NULL } JN On 2019-03-29 11:38 a.m., Saren Tasciyan wrote: > Well, first I can't sign in bugzilla

Re: [Rd] Bug in the "reformulate" function in stats package

2019-03-29 Thread Saren Tasciyan
Well, first I can't sign in bugzilla myself, that is why I wrote here first. Also, I don't know if I have the time at the moment to provide tests, multiple examples or more. If that is not ok or welcomed, that is fine, I can come back, whenever I have more time to properly report the bug. I

Re: [Rd] Bug in the "reformulate" function in stats package

2019-03-29 Thread Martin Maechler
> Saren Tasciyan > on Thu, 28 Mar 2019 17:02:10 +0100 writes: > Hi, > I have found a bug in reformulate function and have a solution for it. I > was wondering, where I can submit it? > Best, > Saren Well, you could have given a small reproducible example

[Rd] Bug in the "reformulate" function in stats package

2019-03-29 Thread Saren Tasciyan
Hi, I have found a bug in reformulate function and have a solution for it. I was wondering, where I can submit it? Best, Saren -- Saren Tasciyan /PhD Student / Sixt Group/ Institute of Science and Technology Austria Am Campus 1 3400 Klosterneuburg, Austria