Re: [Rd] Coercion of 'exclude' in function 'factor' (was 'droplevels' inappropriate change)

> Martin Maechler > on Tue, 13 Sep 2016 18:33:35 +0200 writes: > Suharto Anggono Suharto Anggono via R-devel > on Fri, 2 Sep 2016 16:10:00 + writes: >> I am basically fine with the change. >> How about using

Re: [Rd] Coercion of 'exclude' in function 'factor' (was 'droplevels' inappropriate change)

> Suharto Anggono Suharto Anggono via R-devel > on Fri, 2 Sep 2016 16:10:00 + writes: > I am basically fine with the change. > How about using just the following? > if(!is.character(exclude)) > exclude <- as.vector(exclude, typeof(x)) #

[Rd] Coercion of 'exclude' in function 'factor' (was 'droplevels' inappropriate change)

I am basically fine with the change. How about using just the following? if(!is.character(exclude)) exclude <- as.vector(exclude, typeof(x)) # may result in NA x <- as.character(x) It looks simpler and is, more or less, equivalent. In factor.Rd, in description of argument