Re: [Rd] does subset.data.frame need to accept extra arguments?

2013-07-11 Thread Hadley Wickham
It needs to have ... in the formal argument list because the generic subset() does. It could enforce a run-time warning that some arguments were being skipped (by testing length(list(...)) for example), but then NextMethod might fail, in a case where an object has a complicated class vector.

Re: [Rd] does subset.data.frame need to accept extra arguments?

2013-07-11 Thread Duncan Murdoch
On 13-07-11 12:59 PM, Hadley Wickham wrote: It needs to have ... in the formal argument list because the generic subset() does. It could enforce a run-time warning that some arguments were being skipped (by testing length(list(...)) for example), but then NextMethod might fail, in a case where

Re: [Rd] does subset.data.frame need to accept extra arguments?

2013-07-08 Thread Duncan Murdoch
On 13-07-07 11:09 PM, Peter Meilstrup wrote: The formal list for subset.data.frame accepts a ... args(subset.data.frame) function (x, subset, select, drop = FALSE, ...) NULL But it appears that subset.data.frame does not actually use the ... or pass it along: ... %in%

[Rd] does subset.data.frame need to accept extra arguments?

2013-07-07 Thread Peter Meilstrup
The formal list for subset.data.frame accepts a ... args(subset.data.frame) function (x, subset, select, drop = FALSE, ...) NULL But it appears that subset.data.frame does not actually use the ... or pass it along: ... %in% all.names(body(subset.data.frame)) [1] FALSE Is there any reason why