Re: [Rd] translateChar in NewName in bind.c

2017-08-01 Thread Suharto Anggono Suharto Anggono via R-devel
eturn value, " However, currently, the NEWS item is for R-devel, not R 3.4.1 patched. On Mon, 31/7/17, Martin Maechler <maech...@stat.math.ethz.ch> wrote: Subject: Re: [Rd] translateChar in NewName in bind.c Cc: r-devel@r-project.o

Re: [Rd] translateChar in NewName in bind.c

2017-07-31 Thread Martin Maechler
2(84|92) but I wonder if it is desirable in this case. I'm glad for further reasoning. Given current "knowledge"/"evidence", I would not revert R-patched to R 3.4.1's behavior. Martin > > On Tue, 13/6/17, Tomas

Re: [Rd] translateChar in NewName in bind.c

2017-07-30 Thread Suharto Anggono Suharto Anggono via R-devel
ple. x <- 0 names(x) <- "\xe7" Encoding(names(x)) <- "latin1" res <- c(x) Encoding(names(res)) charToRaw(names(res)) On Tue, 13/6/17, Tomas Kalibera <tomas.kalib...@gmail.com> wrote: Subject: Re: [Rd] translateChar in

Re: [Rd] translateChar in NewName in bind.c

2017-06-13 Thread Tomas Kalibera
Thanks, fixed in R-devel. Best Tomas On 06/11/2017 02:30 PM, Suharto Anggono Suharto Anggono via R-devel wrote: I see another thing in function 'NewName' in bind.c. In else if (*CHAR(tag)) , 'ans' is basically copied from 'tag'. Could the whole thing there be just the following? ans = tag; It

Re: [Rd] translateChar in NewName in bind.c

2017-06-11 Thread Suharto Anggono Suharto Anggono via R-devel
I see another thing in function 'NewName' in bind.c. In else if (*CHAR(tag)) , 'ans' is basically copied from 'tag'. Could the whole thing there be just the following? ans = tag; It seems to me that it can also replace ans = R_BlankString; in 'else'; so, else if (*CHAR(tag)) and else can be

[Rd] translateChar in NewName in bind.c

2017-06-10 Thread Suharto Anggono Suharto Anggono via R-devel
In function 'NewName' in bind.c (https://svn.r-project.org/R/trunk/src/main/bind.c), in else if (*CHAR(base)) , 'translateChar' is used. Should it be 'translateCharUTF8' instead? The end result is marked as UTF-8: mkCharCE(cbuf, CE_UTF8) Other cases already use 'translateCharUTF8'.