Re: [Bioc-devel] ChIPseeker failing on r-devel on CRAN checks

2021-03-23 Thread Hervé Pagès
Hi Onur, AFAICT ChIPseeker is currently available on all platforms in BioC devel: https://bioconductor.org/packages/3.13/ChIPseeker Same for all the other Bioconductor packages that the CRAN check results for cinaR say are not available: - CRAN check results:

Re: [Bioc-devel] adding maintainers to SpatialExperiment repo

2021-03-23 Thread Lukas Weber
Thanks Dario. Could we please use my gmail address for this (this address), which is the one I used for registering my Bioconductor account. (Sorry for possible duplicate email - I previously tried replying from my other address, which is not registered to the Bioc-devel list so email possibly

[Bioc-devel] ChIPseeker failing on r-devel on CRAN checks

2021-03-23 Thread Onur Karakaslar
Hi all, I have a CRAN package called cinaR which depends on ChIPseeker. Yet, I recently learned that ChIPseeker is actually failing on r-devel checks of CRAN, which possibly fails my package as well. You can find the detailed info here: https://support.bioconductor.org/p/9135778/ Can anyone

Re: [Bioc-devel] adding maintainers to SpatialExperiment repo

2021-03-23 Thread Lukas Weber
Thanks Dario. Could we please use my gmail address for this (cc’d), which is the address I used for registering my Bioconductor account. Best regards, Lukas Lukas M. Weber, Ph.D. Postdoctoral Fellow Department of Biostatistics Johns Hopkins Bloomberg School of Public Health

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Hervé Pagès
On 3/23/21 1:31 PM, Murphy, Alan E wrote: Hi Hervé, My apologies but I don't think I follow your approach. I have put your code below into a utils.R script in ewceData: .my_internal_global_variables <- new.env(parent=emptyenv())    .get_eh <- function() get("eh",

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Murphy, Alan E
Hi Herv�, My apologies but I don't think I follow your approach. I have put your code below into a utils.R script in ewceData: .my_internal_global_variables <- new.env(parent=emptyenv()) .get_eh <- function() get("eh", envir=.my_internal_global_variables) .set_eh <- function(value)

[Bioc-devel] adding maintainers to SpatialExperiment repo

2021-03-23 Thread Dario Righelli
Hi Guys, we'd like to add Helena Crowell and Lukas Weber (CC) as maintainers of the SpatialExperiment repo so that they can push on the upstream. Thanks, Dario ___ Bioc-devel@r-project.org mailing list

Re: [Rd] [Solved] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Duncan Murdoch
With that change to the .desktop file, both the existing rgl and the rgl with a group_leader set behave the same: all x11() and rgl windows are collected together into the same R icon. If I don't make that change, then setting the group_leader causes all rgl windows from one process to group

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Hervé Pagès
Doesn't really matter where you put them but .my_internal_global_variables, .get_eh(), .set_eh(), and toto() don't need to be defined inside the .onLoad() hook, and it's actually cleaner/easier to not define them there. You can define there anywhere in your ewceData/R/* files. Here is a

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Murphy, Alan E
Hey Herv�, Thanks for this it is very helpful and I'm very sorry but I have one more question, where to put option 3? I thought making an onload r script for it: .onLoad <- function(libname, pkgname) { .my_internal_global_variables <- new.env(parent=emptyenv()) .get_eh <- function()

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Hervé Pagès
3 ways to do this, one that doesn't work, and two that work ;-) 1. Simple way that doesn't work: ## Just a place holder. Will be initialized at run-time the first ## time it's needed. .some_internal_global_variable <- NULL toto <- function() { if (is.null(.some_global_variable))

Re: [Rd] [Solved] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
It all works now, thanks mostly to some very detailed reading of the specs by Ivan. In short, I made the following changes: - add the missing WM hint to the .desktop file we install - add the svg logo as 'scalable' - create a new (square) 48x48 default png logo from the new one -

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Murphy, Alan E
Hey Herv�, I get the idea now thanks for clarifying. Where do I place the call to ExperimentHub in the package?: eh <- ExperimentHub() # the only call to ExperimentHub() in # the entire R session The package contains calls to the datasets in internal functions,

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Hervé Pagès
On 3/23/21 6:33 AM, Mike Smith wrote: ... Finally I'll point out there's a testthat::skip_on_bioc() function that will allow you to skip a test on the Bioc builder, but still run that test locally/on GitHub etc. What?! > testthat::skip_on_bioc function () { if

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Duncan Murdoch
On 23/03/2021 11:54 a.m., Ivan Krylov wrote: On Tue, 23 Mar 2021 11:41:39 -0400 Duncan Murdoch wrote: It would probably be nice to have rgl windows and other R graphics windows in the same group, but I don't see a way for rgl to know the group_leader that R is using (and it's probably not

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Hervé Pagès
On 3/23/21 4:11 AM, Murphy, Alan E wrote: Hi, Thank you very much Martin and Hervé for your suggestions. I have reverted my zzz.R on load function to that advised by ExperimentHub and had used the ID look up (system.time(tt_alzh <- eh[["EH5373"]])) on internal functions and unit tests.

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Ivan Krylov
On Tue, 23 Mar 2021 11:41:39 -0400 Duncan Murdoch wrote: > It would probably be nice to have rgl windows and other R graphics > windows in the same group, but I don't see a way for rgl to know the > group_leader that R is using (and it's probably not worth adding this > to the API to be able to

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Duncan Murdoch
On 23/03/2021 6:18 a.m., Ivan Krylov wrote: On Mon, 22 Mar 2021 16:57:48 -0500 Dirk Eddelbuettel wrote: Do you want to send a proper patch to bugzilla? Would be glad to, especially if we manage to solve that problem you uncovered while I was asleep. On Mon, 22 Mar 2021 22:23:47 -0500 Dirk

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
On 23 March 2021 at 09:38, Dirk Eddelbuettel wrote: | | On 23 March 2021 at 17:13, Ivan Krylov wrote: | | В Tue, 23 Mar 2021 08:58:49 -0500 | | Dirk Eddelbuettel пишет: | | | | > I still ship /usr/share/icons/hicolor/48x48/apps/rlogo_icon.png which | | > is from the 2012 patch, and I vaguely

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
On 23 March 2021 at 17:13, Ivan Krylov wrote: | В Tue, 23 Mar 2021 08:58:49 -0500 | Dirk Eddelbuettel пишет: | | > I still ship /usr/share/icons/hicolor/48x48/apps/rlogo_icon.png which | > is from the 2012 patch, and I vaguely recall the .desktop file being | > unhappy without it. Re-creating

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Ivan Krylov
В Tue, 23 Mar 2021 08:58:49 -0500 Dirk Eddelbuettel пишет: > I still ship /usr/share/icons/hicolor/48x48/apps/rlogo_icon.png which > is from the 2012 patch, and I vaguely recall the .desktop file being > unhappy without it. Re-creating a 48x48 from the svg may do. I think you could even link

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
On 23 March 2021 at 08:15, Dirk Eddelbuettel wrote: | Only one small downside: the regrouped icon switches to the old R icon (which | is probably the one we bitmapped). Would you know how we could force the new | one? Could well be my fault. =:-) I still ship

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Mike Smith
Hi Alan, I wonder if there are instances in your tests where you can use pseudo data or mock the behaviour of certain functions. For me the aim of unit testing is to confirm the behaviour of functions under controlled conditions, but it doesn't necessarily have to be done using 'real' data. For

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
On 23 March 2021 at 07:44, Dirk Eddelbuettel wrote: | On 23 March 2021 at 13:18, Ivan Krylov wrote: | | Apparently Xfce uses libwnck [*] which groups windows by WM_CLASS in | | addition to WM_HINTS (as far as understand the code). | | | | Here is what GNOME Shell does [**] besides looking at |

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Dirk Eddelbuettel
On 23 March 2021 at 13:18, Ivan Krylov wrote: | On Mon, 22 Mar 2021 16:57:48 -0500 | Dirk Eddelbuettel wrote: | | > Do you want to send a proper patch to bugzilla? | | Would be glad to, especially if we manage to solve that problem you | uncovered while I was asleep. | | On Mon, 22 Mar 2021

Re: [Bioc-devel] Recently accepted package not appearing in nightly builds

2021-03-23 Thread James Perkins
OK that makes sense - apologies, it stated in the issue that "Your package will be included in the next nigthly 'devel' build" and I misinterpreted. Thanks for clarifying! Cheers On Tue, 23 Mar 2021 at 11:40, Kern, Lori wrote: > Your package was identified as a workflow package based you the

Re: [Bioc-devel] Methods to speed up R CMD Check

2021-03-23 Thread Murphy, Alan E
Hi, Thank you very much Martin and Hervé for your suggestions. I have reverted my zzz.R on load function to that advised by ExperimentHub and had used the ID look up (system.time(tt_alzh <- eh[["EH5373"]])) on internal functions and unit tests. However, the check is still taking ~18 minutes so

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Ivan Krylov
On Mon, 22 Mar 2021 16:57:48 -0500 Dirk Eddelbuettel wrote: > Do you want to send a proper patch to bugzilla? Would be glad to, especially if we manage to solve that problem you uncovered while I was asleep. On Mon, 22 Mar 2021 22:23:47 -0500 Dirk Eddelbuettel wrote: > Close, close, close

Re: [Bioc-devel] Recently accepted package not appearing in nightly builds

2021-03-23 Thread Kern, Lori
Your package was identified as a workflow package based you the biocViews you selected. The workflow packages did not build last Friday and next run is today. You should check the following page for your workflow package build results:

Re: [Rd] Possible x11 window manager window aggregation under one icon?

2021-03-23 Thread Martin Maechler
> Dirk Eddelbuettel > on Mon, 22 Mar 2021 22:23:47 -0500 writes: > On 22 March 2021 at 16:57, Dirk Eddelbuettel wrote: > | > | On 23 March 2021 at 00:01, Ivan Krylov wrote: > | | The surrounding code and > | |

[Bioc-devel] Recently accepted package not appearing in nightly builds

2021-03-23 Thread James Perkins
Dear all, I am the maintainer of the package ExpHunterSuite. This was accepted thursday, and on Friday (19/03) the issue raised on the Bioconductor/contributions github page was closed (ExpHunterSuite #1835, https://github.com/Bioconductor/Contributions/issues/1835 ). The last message on the

Re: [Bioc-devel] EXTERNAL: Resolve mismatch between master and release branches

2021-03-23 Thread Mike Smith
Hi Sarah, Just to reiterate Marcel's point, if these are new features or tweaks to your package, then they shouldn't be committed to the release branch at all. The Bioconductor ethos is that the release version of a package should remain stable for a 6 month window (the release cycle), and