Re: [Rd] codetools wrongly complains about lazy evaluation in S4 methods

2023-06-15 Thread Mikael Jagan
On 2023-06-15 5:25 pm, Hervé Pagès wrote: Oh but I see now that you've already tried this in your R/AllGenerics.R, sorry for missing that, but that you worry about the following message being disruptive on CRAN:     The following object is masked from 'package:base':     qr.X Why

Re: [Rd] codetools wrongly complains about lazy evaluation in S4 methods

2023-06-15 Thread Hervé Pagès
Oh but I see now that you've already tried this in your R/AllGenerics.R, sorry for missing that, but that you worry about the following message being disruptive on CRAN:     The following object is masked from 'package:base':     qr.X Why would that be? As long as you only define

Re: [Rd] codetools wrongly complains about lazy evaluation in S4 methods

2023-06-15 Thread Hervé Pagès
I'd argue that at the root of the problem is that your qr.X() generic dispatches on all its arguments, including the 'ncol' argument which I think the dispatch mechanism needs to evaluate **before** dispatch can actually happen. So yes lazy evaluation is a real feature but it does not play

Re: [Rd] https://cran.r-project.org/src/base-prerelease/ is not updating

2023-06-15 Thread peter dalgaard
Yes that was not intentional. Unexpected interaction between installed R version and build tools. Should be OK now. -pd > On 14 Jun 2023, at 14:57 , Gábor Csárdi wrote: > > https://cran.r-project.org/src/base-prerelease/ has not updated for > about a week now, I guess this is not intentional?

[Rd] Parts of test in datetime3.R not working

2023-06-15 Thread Korpela Mikko
In test file datetime3.R, one call to stopifnot() has an argument named "expr" which should probably be "exprs". There are three tests wrapped in braces of which only the last one, "omitted 195 entries", is currently checked. Proposed patch: --- tests/datetime3.R (revision 84544) +++