Re: [Rd] Unneeded if statements in RealFromComplex C code

2021-09-10 Thread Martin Maechler
> Hervé Pagès > on Thu, 9 Sep 2021 17:54:06 -0700 writes: > Hi, > I just stumbled across these 2 lines in RealFromComplex (lines 208 & 209 > in src/main/coerce.c): > double attribute_hidden > RealFromComplex(Rcomplex x, int *warn) > { > if (ISNAN(x.r)

Re: [Rd] Unneeded if statements in RealFromComplex C code

2021-09-10 Thread Hervé Pagès
Thanks Martin! Best, H. On 10/09/2021 02:24, Martin Maechler wrote: Hervé Pagès on Thu, 9 Sep 2021 17:54:06 -0700 writes: > Hi, > I just stumbled across these 2 lines in RealFromComplex (lines 208 & 209 > in src/main/coerce.c): > double attribute_hidden >

Re: [Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread Duncan Murdoch
On 10/09/2021 11:29 a.m., Hervé Pagès wrote: Hi, The first warning below is unexpected and confusing: > as.raw(c(3e9, 5.1)) [1] 00 05 Warning messages: 1: NAs introduced by coercion to integer range 2: out-of-range values treated as 0 in coercion to raw The reason we get

[Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread Hervé Pagès
Hi, The first warning below is unexpected and confusing: > as.raw(c(3e9, 5.1)) [1] 00 05 Warning messages: 1: NAs introduced by coercion to integer range 2: out-of-range values treated as 0 in coercion to raw The reason we get it is that coercion from numeric to raw is currently

Re: [Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread GILLIBERT, Andre
Hello, Integer overflow is undefined behavior by the C standard. For instance, on my computer, with GCC 5.4.0, with the optimization level 2, the following program never stops: include int main(void) { for(int i=1; i != 0; i++) { if ((i & 0xFFF) == 0) {

Re: [Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread Hervé Pagès
On 10/09/2021 09:12, Duncan Murdoch wrote: On 10/09/2021 11:29 a.m., Hervé Pagès wrote: Hi, The first warning below is unexpected and confusing:     > as.raw(c(3e9, 5.1))     [1] 00 05     Warning messages:     1: NAs introduced by coercion to integer range     2: out-of-range values

Re: [Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread Hervé Pagès
On 10/09/2021 12:53, brodie gaslam wrote: On Friday, September 10, 2021, 03:13:54 PM EDT, Hervé Pagès wrote: Good catch, thanks! Replacing if(ISNAN(vi) || (tmp = (int) vi) < 0 || tmp > 255) { tmp = 0; warn |= WARN_RAW; } pa[i] = (Rbyte) tmp;

Re: [Rd] Spurious warnings in coercion from double/complex/character to raw

2021-09-10 Thread brodie gaslam via R-devel
> On Friday, September 10, 2021, 03:13:54 PM EDT, Hervé Pagès > wrote: > > Good catch, thanks! > > Replacing > > if(ISNAN(vi) || (tmp = (int) vi) < 0 || tmp > 255) { > tmp = 0; > > warn |= WARN_RAW; > > } > pa[i] = (Rbyte) tmp; > > with > > if(ISNAN(vi) || vi <=

Re: [Bioc-devel] Git lfs support

2021-09-10 Thread Anatoly Sorokin
Hi Hervé, I've made a new package with metadata.csv, as described in CreateAnAnnotationPackage vignette. The data is located on the public service as a zipped SQLite database. So I've set both SourceType and DispatchClass as 'Zip'. >From AnnotationHub::DispatchClassList() I expect that I should

Re: [Bioc-devel] pdfTeX error, Windows build

2021-09-10 Thread Kern, Lori
There does not appear to be an error in the build report in the link you sent from yesterday's build. It appears that the error may have been intermittent. Lori Shepherd Bioconductor Core Team Roswell Park Comprehensive Cancer Center Department of Biostatistics & Bioinformatics Elm &

[Bioc-devel] pdfTeX error, Windows build

2021-09-10 Thread Pedro Madrigal
Hi Bioc-Devel Do you have any idea of what might be happening here http://bioconductor.org/checkResults/devel/bioc-LATEST/fCCAC/ Best, Pedro (Package author and maintainer) [[alternative HTML version deleted]]

Re: [Bioc-devel] Git lfs support

2021-09-10 Thread Kern, Lori
The paths will be given through the AnnotationHub interface. I would like to also point out that there is a SQLite DisplatchClass that might be more appropriate? It would load the database automatically using AnnotaionDbi::loadDb For a Zip DispatchClass, It will get the zipped file, unzip, and