Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-08-09 Thread Andrzej Oleś
Awesome, thank you Michael! On Mon, Aug 7, 2017 at 7:27 PM, Michael Lawrence wrote: > I ported that over. > > On Tue, Aug 1, 2017 at 5:50 AM, Andrzej Oleś > wrote: > >> Thank you Michael for updating the 3.4 branch, the `callNextMethod()` now

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-08-07 Thread Michael Lawrence
I ported that over. On Tue, Aug 1, 2017 at 5:50 AM, Andrzej Oleś wrote: > Thank you Michael for updating the 3.4 branch, the `callNextMethod()` now > works for `...` methods as expected. However, I'm still missing your other > patch fixing the handling of arguments in

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-08-01 Thread Andrzej Oleś
Thank you Michael for updating the 3.4 branch, the `callNextMethod()` now works for `...` methods as expected. However, I'm still missing your other patch fixing the handling of arguments in `...` methods. It would be really great if this bugfix could be integrated into the 3.4 branch as well,

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-07-28 Thread Michael Lawrence
I pushed the patch to the 3.4 branch. Feel free to test. Michael On Wed, Jul 26, 2017 at 4:02 AM, Andrzej Oleś wrote: > Hi Michael, > > it seems that your patch to S4 generics dispatching on `...` is still > available only in R-devel, and was not included in the minor

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-07-26 Thread Andrzej Oleś
Hi Michael, it seems that your patch to S4 generics dispatching on `...` is still available only in R-devel, and was not included in the minor R-3.4.1 release. I was wondering what is the policy of incorporating bug fixes from the devel branch into release, and whether there is any chance that

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-04-25 Thread Andrzej Oleś
You're right, I must have mixed up my R versions when running the example, as the problem seems to be resolved in R-devel. Sorry for the noise and thanks again for fixing this. Andrzej On Tue, Apr 25, 2017 at 3:55 PM, Michael Lawrence wrote: > I attempted to fix

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-04-25 Thread Michael Lawrence
I attempted to fix it, and that example seems to work for me. It's also a (passing) regression test in R. Are you sure you're using a new enough R-devel? On Tue, Apr 25, 2017 at 2:34 AM, Andrzej Oleś wrote: > Hi Michael, > > thanks again for your patch! I've tested it

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-04-25 Thread Andrzej Oleś
Hi Michael, thanks again for your patch! I've tested it and I'm happy to confirm that `callNextMethod()` works with methods dispatching on `...`. However, the second issue I reported still seems to be unresolved. Consider the following toy example, where the `f()` calls differ in result

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-04-21 Thread Andrzej Oleś
Great, thanks Michael for you quick response! I started off with a question on SO because I was not sure whether this was an actual bug or I was just missing something obvious. I'm looking forward to the patch. Cheers, Andrzej On Thu, Apr 20, 2017 at 10:28 PM, Michael Lawrence <

Re: [Rd] Problems with S4 methods dispatching on `...` (aka dotsMethods)

2017-04-20 Thread Michael Lawrence
Thanks for pointing out these issues. I have a fix that I will commit soon. Btw, I would never have seen the post on Stack Overflow. It's best to report bugs on the bugzilla. Michael On Thu, Apr 20, 2017 at 8:30 AM, Andrzej Oleś wrote: > Hi all, > > I recently